2020-08-29 00:05:12

by Randy Dunlap

Subject: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors

Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)

ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!

Mike had/has an alternate patch for Microblaze:
https://lore.kernel.org/lkml/[email protected]/

David suggested just exporting min_low_pfn & max_low_pfn in
mm/memblock.c:
https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Michal Simek <[email protected]>
---
arch/microblaze/mm/init.c | 3 +++
1 file changed, 3 insertions(+)

--- linux-next-20200825.orig/arch/microblaze/mm/init.c
+++ linux-next-20200825/arch/microblaze/mm/init.c
@@ -46,6 +46,9 @@ unsigned long memory_size;
EXPORT_SYMBOL(memory_size);
unsigned long lowmem_size;

+EXPORT_SYMBOL(min_low_pfn);
+EXPORT_SYMBOL(max_low_pfn);
+
#ifdef CONFIG_HIGHMEM
pte_t *kmap_pte;
EXPORT_SYMBOL(kmap_pte);

2020-08-29 21:38:42

by David Rientjes

Subject: Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors

On Fri, 28 Aug 2020, Randy Dunlap wrote:

> Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
>
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
> ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
>
> Mike had/has an alternate patch for Microblaze:
> https://lore.kernel.org/lkml/[email protected]/
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
> Cc: David Rientjes <[email protected]>
> Cc: Mike Rapoport <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: Michal Simek <[email protected]>

Acked-by: David Rientjes <[email protected]>

Thanks Randy!

2020-08-31 14:09:13

by Michal Simek

Subject: Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors

Hi,

On 29. 08. 20 2:01, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
>
> ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
> ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
> ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
> ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
> ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
> ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
> ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
>
> Mike had/has an alternate patch for Microblaze:
> https://lore.kernel.org/lkml/[email protected]/
>
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
> Cc: David Rientjes <[email protected]>
> Cc: Mike Rapoport <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: Michal Simek <[email protected]>
> ---
> arch/microblaze/mm/init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- linux-next-20200825.orig/arch/microblaze/mm/init.c
> +++ linux-next-20200825/arch/microblaze/mm/init.c
> @@ -46,6 +46,9 @@ unsigned long memory_size;
> EXPORT_SYMBOL(memory_size);
> unsigned long lowmem_size;
>
> +EXPORT_SYMBOL(min_low_pfn);
> +EXPORT_SYMBOL(max_low_pfn);
> +
> #ifdef CONFIG_HIGHMEM
> pte_t *kmap_pte;
> EXPORT_SYMBOL(kmap_pte);
>

Acked-by: Michal Simek <[email protected]>

Mike: Feel free to take it via memblock tree as you mentioned in
alternate patch.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs