2020-08-30 12:32:24

by Shawn Guo

[permalink] [raw]
Subject: [PATCH] get_maintainer: add email addresses from dts files

MAINTAINER file will get bloated quickly if individual section entry
is created for each .dts/.dtsi file. Add the email address from dts
files to get_maintainer output for saving unnecessary patching on
MAINTAINER file.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 484d2fbf5921..b8e104028359 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -436,7 +436,7 @@ sub maintainers_in_file {

return if ($file =~ m@\bMAINTAINERS$@);

- if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
+ if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
open(my $f, '<', $file)
or die "$P: Can't open $file: $!\n";
my $text = do { local($/) ; <$f> };
--
2.17.1


2020-09-30 10:58:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] get_maintainer: add email addresses from dts files

On Sun, 30 Aug 2020 at 14:31, Shawn Guo <[email protected]> wrote:
>
> MAINTAINER file will get bloated quickly if individual section entry
> is created for each .dts/.dtsi file. Add the email address from dts
> files to get_maintainer output for saving unnecessary patching on
> MAINTAINER file.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Shawn Guo <[email protected]>
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

I thought this was applied... but seems not, so my previous email
could be ignored.

I like this approach because contact details for specific boards are
useful. So +1 from me:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof