2020-08-24 07:17:12

by Krzysztof Kozlowski

Subject: [PATCH] arm64: dts: imx8mm-beacon-baseboard: Correct LED default state

There is no LED default state "none". leds-gpio driver maps it to
"off", so correct them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml:
leds: led0:default-state:0: 'none' is not one of ['on', 'off', 'keep']

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
index baa5f997d018..bf0859f1e1fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
@@ -10,19 +10,19 @@
led0 {
label = "gen_led0";
gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
- default-state = "none";
+ default-state = "off";
};

led1 {
label = "gen_led1";
gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
- default-state = "none";
+ default-state = "off";
};

led2 {
label = "gen_led2";
gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
- default-state = "none";
+ default-state = "off";
};

led3 {
--
2.17.1

2020-08-30 13:20:01

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mm-beacon-baseboard: Correct LED default state

On Mon, Aug 24, 2020 at 09:15:46AM +0200, Krzysztof Kozlowski wrote:
> There is no LED default state "none". leds-gpio driver maps it to
> "off", so correct them to fix dtbs_check warnings like:
>
> arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml:
> leds: led0:default-state:0: 'none' is not one of ['on', 'off', 'keep']
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thanks.