2020-08-30 17:38:53

by Grygorii Strashko

Subject: [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode

In RMII link mode it's required to set bit 15 IFCTL_A in MAC_SL MAC_CONTROL
register to enable support for 100Mbit link speed.

Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
Signed-off-by: Grygorii Strashko <[email protected]>
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index cb994f66c3be..9baf3f3da91e 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -174,6 +174,8 @@ void am65_cpsw_nuss_adjust_link(struct net_device *ndev)
if (phy->speed == 10 && phy_interface_is_rgmii(phy))
/* Can be used with in band mode only */
mac_control |= CPSW_SL_CTL_EXT_EN;
+ if (phy->speed == 100 && phy->interface == PHY_INTERFACE_MODE_RMII)
+ mac_control |= CPSW_SL_CTL_IFCTL_A;
if (phy->duplex)
mac_control |= CPSW_SL_CTL_FULLDUPLEX;

--
2.17.1

2020-08-31 22:49:27

by David Miller

Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: fix rmii 100Mbit link mode

From: Grygorii Strashko <[email protected]>
Date: Sun, 30 Aug 2020 20:34:32 +0300

> In RMII link mode it's required to set bit 15 IFCTL_A in MAC_SL MAC_CONTROL
> register to enable support for 100Mbit link speed.
>
> Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
> Signed-off-by: Grygorii Strashko <[email protected]>

Applied and queued up for v5.7+ -stable, thanks.