Hi everyone,
There is a problem that the output does not work at a resolution
exceeding FHD. To solve this, we need to adjust the bvb clock at a
resolution exceeding FHD.
Rebased on top of next-20200708 and [1].
[1] : [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline (Maxime's patchset)
Changes from v1:
- Added dt-bindings documents
- Change patch order, first fix driver and then device tree
Hoegeun Kwon (4):
clk: bcm: rpi: Add register to control pixel bvb clk
drm/vc4: hdmi: Add pixel bvb clock control
dt-bindings: display: vc4: hdmi: Add bvb clock-names property
ARM: dts: bcm2711: Add bvb clock for hdmi-pixel
.../bindings/display/brcm,bcm2711-hdmi.yaml | 12 ++++++---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 +++--
drivers/clk/bcm/clk-raspberrypi.c | 1 +
drivers/gpu/drm/vc4/vc4_hdmi.c | 25 +++++++++++++++++++
drivers/gpu/drm/vc4/vc4_hdmi.h | 1 +
5 files changed, 39 insertions(+), 6 deletions(-)
--
2.17.1
It is necessary to control the hdmi pixel bvb clock. Add bvb clock.
Signed-off-by: Hoegeun Kwon <[email protected]>
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
index b93eb30e1ddb..90dee4cb38bc 100644
--- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
@@ -172,12 +172,14 @@
};
&hdmi0 {
- clocks = <&firmware_clocks 13>, <&dvp 0>;
+ clocks = <&firmware_clocks 13>, <&dvp 0>, <&firmware_clocks 14>;
+ clock-names = "hdmi", "clk-108M", "bvb";
status = "okay";
};
&hdmi1 {
- clocks = <&firmware_clocks 13>, <&dvp 1>;
+ clocks = <&firmware_clocks 13>, <&dvp 1>, <&firmware_clocks 14>;
+ clock-names = "hdmi", "clk-108M", "bvb";
status = "okay";
};
--
2.17.1
On Tue, 2020-09-01 at 13:07 +0900, Hoegeun Kwon wrote:
> Hi everyone,
>
> There is a problem that the output does not work at a resolution
> exceeding FHD. To solve this, we need to adjust the bvb clock at a
> resolution exceeding FHD.
>
> Rebased on top of next-20200708 and [1].
>
> [1] : [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline (Maxime's patchset)
>
> Changes from v1:
> - Added dt-bindings documents
> - Change patch order, first fix driver and then device tree
>
> Hoegeun Kwon (4):
> clk: bcm: rpi: Add register to control pixel bvb clk
> drm/vc4: hdmi: Add pixel bvb clock control
> dt-bindings: display: vc4: hdmi: Add bvb clock-names property
> ARM: dts: bcm2711: Add bvb clock for hdmi-pixel
>
> .../bindings/display/brcm,bcm2711-hdmi.yaml | 12 ++++++---
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 +++--
> drivers/clk/bcm/clk-raspberrypi.c | 1 +
> drivers/gpu/drm/vc4/vc4_hdmi.c | 25 +++++++++++++++++++
> drivers/gpu/drm/vc4/vc4_hdmi.h | 1 +
> 5 files changed, 39 insertions(+), 6 deletions(-)
Small note to anyone reviewing this, patches 3 & 4 where squashed into this
series: https://lkml.org/lkml/2020/9/3/219
Regards,
Nicolas