2020-08-31 17:01:23

by Michal Suchánek

[permalink] [raw]
Subject: [PATCH] char: virtio: Select VIRTIO from VIRTIO_CONSOLE.

Make it possible to have virtio console built-in when
other virtio drivers are modular.

Signed-off-by: Michal Suchanek <[email protected]>
---
drivers/char/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 3a144c000a38..9bd9917ca9af 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -93,8 +93,9 @@ config PPDEV

config VIRTIO_CONSOLE
tristate "Virtio console"
- depends on VIRTIO && TTY
+ depends on TTY
select HVC_DRIVER
+ select VIRTIO
help
Virtio console for use with hypervisors.

--
2.28.0


2020-09-02 12:21:05

by Amit Shah

[permalink] [raw]
Subject: Re: [PATCH] char: virtio: Select VIRTIO from VIRTIO_CONSOLE.

On Mon, Aug 31, 2020 at 06:58:50PM +0200, Michal Suchanek wrote:
> Make it possible to have virtio console built-in when
> other virtio drivers are modular.
>
> Signed-off-by: Michal Suchanek <[email protected]>

Reviewed-by: Amit Shah <[email protected]>

> ---
> drivers/char/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 3a144c000a38..9bd9917ca9af 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -93,8 +93,9 @@ config PPDEV
>
> config VIRTIO_CONSOLE
> tristate "Virtio console"
> - depends on VIRTIO && TTY
> + depends on TTY
> select HVC_DRIVER
> + select VIRTIO
> help
> Virtio console for use with hypervisors.
>
> --
> 2.28.0
>