LinuxLists.cc - [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 16:27:41

Subject: [PATCH] RDMA/ucma: Fix resource leak on error path

In ucma_process_join(), if the call to xa_alloc() fails, the function
will return without freeing mc. Fix this by jumping to the correct line.

In the process I renamed the jump labels to something more memorable for
extra clarity.

Addresses-Coverity: ("Resource leak")
Fixes: 95fe51096b7a ("RDMA/ucma: Remove mc_list and rely on xarray")
Signed-off-by: Alex Dewar <[email protected]>
---
drivers/infiniband/core/ucma.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index f2c9ef6ae481..a5595bd489b0 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1453,7 +1453,7 @@ static ssize_t ucma_process_join(struct ucma_file *file,
mc = kzalloc(sizeof(*mc), GFP_KERNEL);
if (!mc) {
ret = -ENOMEM;
- goto err1;
+ goto err_put_ctx;
}

mc->ctx = ctx;
@@ -1464,7 +1464,7 @@ static ssize_t ucma_process_join(struct ucma_file *file,
if (xa_alloc(&multicast_table, &mc->id, NULL, xa_limit_32b,
GFP_KERNEL)) {
ret = -ENOMEM;
- goto err1;
+ goto err_free_mc;
}

mutex_lock(&ctx->mutex);
@@ -1472,13 +1472,13 @@ static ssize_t ucma_process_join(struct ucma_file *file,
join_state, mc);
mutex_unlock(&ctx->mutex);
if (ret)
- goto err2;
+ goto err_xa_erase;

resp.id = mc->id;
if (copy_to_user(u64_to_user_ptr(cmd->response),
&resp, sizeof(resp))) {
ret = -EFAULT;
- goto err3;
+ goto err_leave_multicast;
}

xa_store(&multicast_table, mc->id, mc, 0);
@@ -1486,15 +1486,16 @@ static ssize_t ucma_process_join(struct ucma_file *file,
ucma_put_ctx(ctx);
return 0;

-err3:
+err_leave_multicast:
mutex_lock(&ctx->mutex);
rdma_leave_multicast(ctx->cm_id, (struct sockaddr *) &mc->addr);
mutex_unlock(&ctx->mutex);
ucma_cleanup_mc_events(mc);
-err2:
+err_xa_erase:
xa_erase(&multicast_table, mc->id);
+err_free_mc:
kfree(mc);
-err1:
+err_put_ctx:
ucma_put_ctx(ctx);
return ret;
}
--
2.28.0

2020-09-02 20:12:34

by Jason Gunthorpe

[permalink] [raw]

Subject: Re: [PATCH] RDMA/ucma: Fix resource leak on error path

On Wed, Sep 02, 2020 at 05:24:51PM +0100, Alex Dewar wrote:
> In ucma_process_join(), if the call to xa_alloc() fails, the function
> will return without freeing mc. Fix this by jumping to the correct line.
>
> In the process I renamed the jump labels to something more memorable for
> extra clarity.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 95fe51096b7a ("RDMA/ucma: Remove mc_list and rely on xarray")
> Signed-off-by: Alex Dewar <[email protected]>

Applied to for-next, thanks

Jason

2020-09-03 00:31:29

by Gustavo A. R. Silva

[permalink] [raw]

Subject: Re: [PATCH] RDMA/ucma: Fix resource leak on error path

Hi Alex,

On 9/2/20 11:24, Alex Dewar wrote:
> In ucma_process_join(), if the call to xa_alloc() fails, the function
> will return without freeing mc. Fix this by jumping to the correct line.
>
> In the process I renamed the jump labels to something more memorable for
> extra clarity.
>
> Addresses-Coverity: ("Resource leak")

If you are using a public Coverity scan, please also include the Coverity ID.
In this case ID 1496814, something like:

Addresses-Coverity-ID: 1496814 ("Resource leak")

People that don't include an CID is because they are using a private Coverity
scan, so it doesn't make sense for them to add an ID because no one but
them have access to that scan report.

Thanks
--
Gustavo

2020-09-03 00:34:40

by Jason Gunthorpe

[permalink] [raw]

Subject: Re: [PATCH] RDMA/ucma: Fix resource leak on error path

On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote:
> Hi Alex,
>
> On 9/2/20 11:24, Alex Dewar wrote:
> > In ucma_process_join(), if the call to xa_alloc() fails, the function
> > will return without freeing mc. Fix this by jumping to the correct line.
> >
> > In the process I renamed the jump labels to something more memorable for
> > extra clarity.
> >
> > Addresses-Coverity: ("Resource leak")
>
> If you are using a public Coverity scan, please also include the Coverity ID.
> In this case ID 1496814, something like:
>
> Addresses-Coverity-ID: 1496814 ("Resource leak")

Thanks, I fixed it up

Jason

2020-09-03 00:46:48

by Gustavo A. R. Silva

[permalink] [raw]

Subject: Re: [PATCH] RDMA/ucma: Fix resource leak on error path

On 9/2/20 19:32, Jason Gunthorpe wrote:

>>> Addresses-Coverity: ("Resource leak")
>>
>> If you are using a public Coverity scan, please also include the Coverity ID.
>> In this case ID 1496814, something like:
>>
>> Addresses-Coverity-ID: 1496814 ("Resource leak")
>
> Thanks, I fixed it up
>

Awesome. :)

Thanks, Jason.
--
Gustavo

2020-09-03 09:36:14

by Alex Dewar

[permalink] [raw]