2020-09-06 16:23:34

by Martin Cerveny

[permalink] [raw]
Subject: [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction

The secondary video layer (VI) on "Allwinner V3s" displays
decoded video (YUV) in wrong colors. The secondary
CSC should be programmed.
Let's correct CSC register offset and extend regmap size.

Regards.

Martin Cerveny (2):
drm/sun4i: sun8i-csc: Secondary CSC register correction
drm/sun4i: mixer: Extend regmap max_register

drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--
2.17.1


2020-09-06 16:27:02

by Martin Cerveny

[permalink] [raw]
Subject: [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register

Better guess. Secondary CSC registers are from 0xF0000.

Signed-off-by: Martin Cerveny <[email protected]>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index cc4fb916318f..c3304028e3dc 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -307,7 +307,7 @@ static struct regmap_config sun8i_mixer_regmap_config = {
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
- .max_register = 0xbfffc, /* guessed */
+ .max_register = 0xffffc, /* guessed */
};

static int sun8i_mixer_of_get_id(struct device_node *node)
--
2.17.1

2020-09-08 17:32:20

by Jernej Skrabec

[permalink] [raw]
Subject: Re: [PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register

>Better guess. Secondary CSC registers are from 0xF0000.
>
>Signed-off-by: Martin Cerveny <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej


2020-09-10 11:19:29

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction

On Sun, Sep 06, 2020 at 06:21:38PM +0200, Martin Cerveny wrote:
> The secondary video layer (VI) on "Allwinner V3s" displays
> decoded video (YUV) in wrong colors. The secondary
> CSC should be programmed.
> Let's correct CSC register offset and extend regmap size.

Applied both, thanks

Maxime


Attachments:
(No filename) (306.00 B)
signature.asc (235.00 B)
Download all attachments