2020-09-07 08:41:20

by Jing Xiangfeng

Subject: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

Fix to return error code PTR_ERR() from the error handling case instead
of 0.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index ea7c8930592d..70daa0605082 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
if (IS_ERR(vhost->work_thread)) {
dev_err(dev, "Couldn't create kernel thread: %ld\n",
PTR_ERR(vhost->work_thread));
+ rc = PTR_ERR(vhost->work_thread);
goto free_host_mem;
}

--
2.17.1

2020-09-09 19:23:01

by Tyrel Datwyler

Subject: Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

On 9/7/20 1:39 AM, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Acked-by: Tyrel Datwyler <[email protected]>

> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index ea7c8930592d..70daa0605082 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> if (IS_ERR(vhost->work_thread)) {
> dev_err(dev, "Couldn't create kernel thread: %ld\n",
> PTR_ERR(vhost->work_thread));
> + rc = PTR_ERR(vhost->work_thread);
> goto free_host_mem;
> }
>
>

2020-09-10 02:19:46

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

Jing,

> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.

Applied to 5.10/scsi-staging. Thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-09-15 20:24:49

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

On Mon, 7 Sep 2020 16:39:49 +0800, Jing Xiangfeng wrote:

> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ibmvfc: Fix error return in ibmvfc_probe()
https://git.kernel.org/mkp/scsi/c/5e48a084f4e8

--
Martin K. Petersen Oracle Linux Engineering