2020-09-08 03:06:57

by Huazhong Tan

[permalink] [raw]
Subject: [PATCH net-next 0/7] net: hns3: misc updates

There are some misc updates for the HNS3 ethernet driver.

#1 narrows two local variable range in hclgevf_reset_prepare_wait().
#2 adds reset failure check in periodic service task.
#3~#7 adds some cleanups.

Guangbin Huang (2):
net: hns3: skip periodic service task if reset failed
net: hns3: fix a typo in struct hclge_mac

Guojia Liao (1):
net: hns3: remove some unused function hns3_update_promisc_mode()

Huazhong Tan (4):
net: hns3: narrow two local variable range in
hclgevf_reset_prepare_wait()
net: hns3: remove unused field 'io_base' in struct hns3_enet_ring
net: hns3: remove unused field 'tc_num_last_time' in struct hclge_dev
net: hns3: remove some unused macros related to queue

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 16 ----------------
drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 7 -------
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 3 +--
.../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 15 +++++++++------
5 files changed, 13 insertions(+), 31 deletions(-)

--
2.7.4


2020-09-08 03:07:18

by Huazhong Tan

[permalink] [raw]
Subject: [PATCH net-next 3/7] net: hns3: fix a typo in struct hclge_mac

From: Guangbin Huang <[email protected]>

The member link of struct hclge_mac stores the link status of
MAC and PHY if PHY exists, but its annotation uses word "exit",
so fix it.

Signed-off-by: Guangbin Huang <[email protected]>
Signed-off-by: Huazhong Tan <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
index 9bbdd45..33e1af1 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
@@ -266,7 +266,7 @@ struct hclge_mac {
u32 fec_mode; /* active fec mode */
u32 user_fec_mode;
u32 fec_ability;
- int link; /* store the link status of mac & phy (if phy exit) */
+ int link; /* store the link status of mac & phy (if phy exists) */
struct phy_device *phydev;
struct mii_bus *mdio_bus;
phy_interface_t phy_if;
--
2.7.4

2020-09-08 19:08:37

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net-next 0/7] net: hns3: misc updates

On Tue, 8 Sep 2020 10:59:47 +0800 Huazhong Tan wrote:
> There are some misc updates for the HNS3 ethernet driver.
>
> #1 narrows two local variable range in hclgevf_reset_prepare_wait().
> #2 adds reset failure check in periodic service task.
> #3~#7 adds some cleanups.

Looks trivial:

Reviewed-by: Jakub Kicinski <[email protected]>

2020-09-09 02:53:04

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next 0/7] net: hns3: misc updates

From: Jakub Kicinski <[email protected]>
Date: Tue, 8 Sep 2020 12:05:38 -0700

> On Tue, 8 Sep 2020 10:59:47 +0800 Huazhong Tan wrote:
>> There are some misc updates for the HNS3 ethernet driver.
>>
>> #1 narrows two local variable range in hclgevf_reset_prepare_wait().
>> #2 adds reset failure check in periodic service task.
>> #3~#7 adds some cleanups.
>
> Looks trivial:
>
> Reviewed-by: Jakub Kicinski <[email protected]>

Series applied, thanks everyone.