2020-09-04 13:02:15

by Wang Hai

Subject: [PATCH net-next] netfilter: ebt_stp: Remove unused macro BPDU_TYPE_TCN

BPDU_TYPE_TCN is never used after it was introduced.
So better to remove it.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
net/bridge/netfilter/ebt_stp.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c
index 0d6d20c9105e..8f68afda5f81 100644
--- a/net/bridge/netfilter/ebt_stp.c
+++ b/net/bridge/netfilter/ebt_stp.c
@@ -15,7 +15,6 @@
#include <linux/netfilter_bridge/ebt_stp.h>

#define BPDU_TYPE_CONFIG 0
-#define BPDU_TYPE_TCN 0x80

struct stp_header {
u8 dsap;
--
2.17.1

2020-09-08 10:58:33

by Pablo Neira Ayuso

Subject: Re: [PATCH net-next] netfilter: ebt_stp: Remove unused macro BPDU_TYPE_TCN

On Fri, Sep 04, 2020 at 08:56:53PM +0800, Wang Hai wrote:
> BPDU_TYPE_TCN is never used after it was introduced.
> So better to remove it.

Applied, thanks.