2020-09-09 07:40:19

by Sumera Priyadarsini

[permalink] [raw]
Subject: Re: [PATCH] scripts: coccicheck: Do not use shift command when rule is specified

On Wed, Sep 09, 2020 at 08:52:19AM +0200, Markus Elfring wrote:
> I find it helpful to avoid typos (like the following) in the change description.
>
>
> > … Makfeile. …
>
> … Makefile. …
>
>
> > … paasing …
>
> … passing …
>
>
> > …, resuting …
>
> …, resulting …
>
>
> > This patch modifies coccicheck …
>

I did make those errors but I also rectified them. This is strange
because my commit message shows the rectified version.
Either way, I will send a v2. Thanks for pointing this out.

> Would an imperative wording be preferred for the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8#n151
>
> Regards,
> Markus