2020-09-09 12:11:44

by Zheng Bin

Subject: [PATCH -next] xfs: Remove unneeded semicolon

Fixes coccicheck warning:

fs/xfs/xfs_icache.c:1214:2-3: Unneeded semicolon

Signed-off-by: Zheng Bin <[email protected]>
---
fs/xfs/xfs_icache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 101028ebb571..5e926912e507 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -1211,7 +1211,7 @@ xfs_reclaim_inodes(
while (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
xfs_ail_push_all_sync(mp->m_ail);
xfs_reclaim_inodes_ag(mp, &nr_to_scan);
- };
+ }
}

/*
--
2.26.0.106.g9fadedd

2020-09-09 18:56:38

by Darrick J. Wong

Subject: Re: [PATCH -next] xfs: Remove unneeded semicolon

On Wed, Sep 09, 2020 at 08:07:32PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> fs/xfs/xfs_icache.c:1214:2-3: Unneeded semicolon
>
> Signed-off-by: Zheng Bin <[email protected]>

Looks ok,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_icache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 101028ebb571..5e926912e507 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -1211,7 +1211,7 @@ xfs_reclaim_inodes(
> while (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
> xfs_ail_push_all_sync(mp->m_ail);
> xfs_reclaim_inodes_ag(mp, &nr_to_scan);
> - };
> + }
> }
>
> /*
> --
> 2.26.0.106.g9fadedd
>