2020-09-10 03:13:53

by Andrew Jeffery

Subject: [PATCH] ARM: dts: rainier: Disable internal pull-downs on eMMC pins

There's a veritable tug-of-war going on in the design, so disable one of
the warring parties.

Signed-off-by: Andrew Jeffery <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 1fa233d2da26..21ae880c7530 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -180,6 +180,10 @@ &emmc_controller {
status = "okay";
};

+&pinctrl_emmc_default {
+ bias-disable;
+};
+
&emmc {
status = "okay";
};
--
2.25.1

2020-09-10 03:20:58

by Joel Stanley

Subject: Re: [PATCH] ARM: dts: rainier: Disable internal pull-downs on eMMC pins

On Thu, 10 Sep 2020 at 03:12, Andrew Jeffery <[email protected]> wrote:
>
> There's a veritable tug-of-war going on in the design, so disable one of
> the warring parties.
>
> Signed-off-by: Andrew Jeffery <[email protected]>

Applied to the aspeed tree for 5.10.

Cheers,

Joel

> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 1fa233d2da26..21ae880c7530 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -180,6 +180,10 @@ &emmc_controller {
> status = "okay";
> };
>
> +&pinctrl_emmc_default {
> + bias-disable;
> +};
> +
> &emmc {
> status = "okay";
> };
> --
> 2.25.1
>