2020-09-09 15:46:44

by Yue Haibing

Subject: [PATCH -next] drm/panel: s6e63m0: Add missing MODULE_LICENSE

Kbuild warns when this file is built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-samsung-s6e63m0.o

Add the missing license/author/description tags.

Fixes: b7b23e447687 ("drm/panel: s6e63m0: Break out SPI transport")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
index 044294aafe27..3eee67e2d86a 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
@@ -534,3 +534,7 @@ int s6e63m0_remove(struct device *dev)
return 0;
}
EXPORT_SYMBOL_GPL(s6e63m0_remove);
+
+MODULE_AUTHOR("Paweł Chmiel <[email protected]>");
+MODULE_DESCRIPTION("s6e63m0 LCD Driver");
+MODULE_LICENSE("GPL v2");
--
2.17.1

2020-09-10 06:51:33

by Daniel Vetter

Subject: Re: [PATCH -next] drm/panel: s6e63m0: Add missing MODULE_LICENSE

On Wed, Sep 09, 2020 at 09:41:37PM +0800, YueHaibing wrote:
> Kbuild warns when this file is built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-samsung-s6e63m0.o
>
> Add the missing license/author/description tags.
>
> Fixes: b7b23e447687 ("drm/panel: s6e63m0: Break out SPI transport")
> Signed-off-by: YueHaibing <[email protected]>

Thanks for your patch, pushed to drm-misc-next.
-Daniel

> ---
> drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> index 044294aafe27..3eee67e2d86a 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> @@ -534,3 +534,7 @@ int s6e63m0_remove(struct device *dev)
> return 0;
> }
> EXPORT_SYMBOL_GPL(s6e63m0_remove);
> +
> +MODULE_AUTHOR("Paweł Chmiel <[email protected]>");
> +MODULE_DESCRIPTION("s6e63m0 LCD Driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.17.1
>
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch