2020-09-10 20:00:32

by Jason Yan

Subject: [PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

This function does nothing so remove it. This addresses the following
coccicheck warning:

drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15:
Unneeded variable: "callbacks". Return "0" on line 5105

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index 21691581b532..763e0ec583d7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -5085,13 +5085,6 @@ int brcms_c_up(struct brcms_c_info *wlc)
return 0;
}

-static uint brcms_c_down_del_timer(struct brcms_c_info *wlc)
-{
- uint callbacks = 0;
-
- return callbacks;
-}
-
static int brcms_b_bmac_down_prep(struct brcms_hardware *wlc_hw)
{
bool dev_gone;
@@ -5201,8 +5194,6 @@ uint brcms_c_down(struct brcms_c_info *wlc)
callbacks++;
wlc->WDarmed = false;
}
- /* cancel all other timers */
- callbacks += brcms_c_down_del_timer(wlc);

wlc->pub->up = false;

--
2.25.4

2020-09-16 06:06:54

by Kalle Valo

Subject: Re: [PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

Jason Yan <[email protected]> wrote:

> This function does nothing so remove it. This addresses the following
> coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15:
> Unneeded variable: "callbacks". Return "0" on line 5105
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

b86acf155c1c brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

--
https://patchwork.kernel.org/patch/11769045/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches