2020-09-10 08:11:12

by Yue Haibing

Subject: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings

If CONFIG_PM is n, gcc warns:

drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function]
static int mmpcam_resume(struct device *dev)
^~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function]
static int mmpcam_suspend(struct device *dev)
^~~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
static int mmpcam_runtime_suspend(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
static int mmpcam_runtime_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~

Mark them as __maybe_unused to fix this.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
index c4b28a00a3a2..032fdddbbecc 100644
--- a/drivers/media/platform/marvell-ccic/mmp-driver.c
+++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
@@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
* Suspend/resume support.
*/

-static int mmpcam_runtime_resume(struct device *dev)
+static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);
struct mcam_camera *mcam = &cam->mcam;
@@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
return 0;
}

-static int mmpcam_runtime_suspend(struct device *dev)
+static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);
struct mcam_camera *mcam = &cam->mcam;
@@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
return 0;
}

-static int mmpcam_suspend(struct device *dev)
+static int __maybe_unused mmpcam_suspend(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);

@@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
return 0;
}

-static int mmpcam_resume(struct device *dev)
+static int __maybe_unused mmpcam_resume(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);

--
2.17.1

2020-09-10 08:30:52

by Lubomir Rintel

Subject: Re: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings

On Thu, Sep 10, 2020 at 04:09:33PM +0800, YueHaibing wrote:
> If CONFIG_PM is n, gcc warns:
>
> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function]
> static int mmpcam_resume(struct device *dev)
> ^~~~~~~~~~~~~
> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function]
> static int mmpcam_suspend(struct device *dev)
> ^~~~~~~~~~~~~~
> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
> static int mmpcam_runtime_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
> static int mmpcam_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Your colleague seems to sent out an equivalent patch:
https://lore.kernel.org/lkml/[email protected]/

Cheers
Lubo

> ---
> drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
> index c4b28a00a3a2..032fdddbbecc 100644
> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
> @@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
> * Suspend/resume support.
> */
>
> -static int mmpcam_runtime_resume(struct device *dev)
> +static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
> struct mcam_camera *mcam = &cam->mcam;
> @@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static int mmpcam_runtime_suspend(struct device *dev)
> +static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
> struct mcam_camera *mcam = &cam->mcam;
> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int mmpcam_suspend(struct device *dev)
> +static int __maybe_unused mmpcam_suspend(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
>
> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
> return 0;
> }
>
> -static int mmpcam_resume(struct device *dev)
> +static int __maybe_unused mmpcam_resume(struct device *dev)
> {
> struct mmp_camera *cam = dev_get_drvdata(dev);
>
> --
> 2.17.1
>
>

2020-09-10 09:19:53

by Yue Haibing

Subject: Re: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings

On 2020/9/10 16:22, Lubomir Rintel wrote:
> On Thu, Sep 10, 2020 at 04:09:33PM +0800, YueHaibing wrote:
>> If CONFIG_PM is n, gcc warns:
>>
>> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function]
>> static int mmpcam_resume(struct device *dev)
>> ^~~~~~~~~~~~~
>> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function]
>> static int mmpcam_suspend(struct device *dev)
>> ^~~~~~~~~~~~~~
>> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
>> static int mmpcam_runtime_suspend(struct device *dev)
>> ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
>> static int mmpcam_runtime_resume(struct device *dev)
>> ^~~~~~~~~~~~~~~~~~~~~
>>
>> Mark them as __maybe_unused to fix this.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: YueHaibing <[email protected]>
>
> Your colleague seems to sent out an equivalent patch:
> https://lore.kernel.org/lkml/[email protected]/

This is my patch, paste an wrong link?

>
> Cheers
> Lubo
>
>> ---
>> drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
>> index c4b28a00a3a2..032fdddbbecc 100644
>> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
>> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
>> @@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
>> * Suspend/resume support.
>> */
>>
>> -static int mmpcam_runtime_resume(struct device *dev)
>> +static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
>> {
>> struct mmp_camera *cam = dev_get_drvdata(dev);
>> struct mcam_camera *mcam = &cam->mcam;
>> @@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
>> return 0;
>> }
>>
>> -static int mmpcam_runtime_suspend(struct device *dev)
>> +static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
>> {
>> struct mmp_camera *cam = dev_get_drvdata(dev);
>> struct mcam_camera *mcam = &cam->mcam;
>> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
>> return 0;
>> }
>>
>> -static int mmpcam_suspend(struct device *dev)
>> +static int __maybe_unused mmpcam_suspend(struct device *dev)
>> {
>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>
>> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
>> return 0;
>> }
>>
>> -static int mmpcam_resume(struct device *dev)
>> +static int __maybe_unused mmpcam_resume(struct device *dev)
>> {
>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>
>> --
>> 2.17.1
>>
>>
>
> .
>

2020-09-10 20:12:23

by Lubomir Rintel

Subject: Re: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings

On Thu, Sep 10, 2020 at 05:18:15PM +0800, Yuehaibing wrote:
> On 2020/9/10 16:22, Lubomir Rintel wrote:
> > On Thu, Sep 10, 2020 at 04:09:33PM +0800, YueHaibing wrote:
> >> If CONFIG_PM is n, gcc warns:
> >>
> >> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function]
> >> static int mmpcam_resume(struct device *dev)
> >> ^~~~~~~~~~~~~
> >> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function]
> >> static int mmpcam_suspend(struct device *dev)
> >> ^~~~~~~~~~~~~~
> >> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
> >> static int mmpcam_runtime_suspend(struct device *dev)
> >> ^~~~~~~~~~~~~~~~~~~~~~
> >> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
> >> static int mmpcam_runtime_resume(struct device *dev)
> >> ^~~~~~~~~~~~~~~~~~~~~
> >>
> >> Mark them as __maybe_unused to fix this.
> >>
> >> Reported-by: Hulk Robot <[email protected]>
> >> Signed-off-by: YueHaibing <[email protected]>
> >
> > Your colleague seems to sent out an equivalent patch:
> > https://lore.kernel.org/lkml/[email protected]/
>
> This is my patch, paste an wrong link?

Indeed, sorry for the confusion.

The original mail only went to linux-media, not lkml, which is why I
picked the wrong one from the archive. Here's the patch:

https://lore.kernel.org/linux-media/[email protected]/

Take care
Lubo

>
> >
> > Cheers
> > Lubo
> >
> >> ---
> >> drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
> >> index c4b28a00a3a2..032fdddbbecc 100644
> >> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
> >> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
> >> @@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
> >> * Suspend/resume support.
> >> */
> >>
> >> -static int mmpcam_runtime_resume(struct device *dev)
> >> +static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
> >> {
> >> struct mmp_camera *cam = dev_get_drvdata(dev);
> >> struct mcam_camera *mcam = &cam->mcam;
> >> @@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
> >> return 0;
> >> }
> >>
> >> -static int mmpcam_runtime_suspend(struct device *dev)
> >> +static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
> >> {
> >> struct mmp_camera *cam = dev_get_drvdata(dev);
> >> struct mcam_camera *mcam = &cam->mcam;
> >> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
> >> return 0;
> >> }
> >>
> >> -static int mmpcam_suspend(struct device *dev)
> >> +static int __maybe_unused mmpcam_suspend(struct device *dev)
> >> {
> >> struct mmp_camera *cam = dev_get_drvdata(dev);
> >>
> >> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
> >> return 0;
> >> }
> >>
> >> -static int mmpcam_resume(struct device *dev)
> >> +static int __maybe_unused mmpcam_resume(struct device *dev)
> >> {
> >> struct mmp_camera *cam = dev_get_drvdata(dev);
> >>
> >> --
> >> 2.17.1
> >>
> >>
> >
> > .
> >
>

2020-09-11 04:55:12

by Yue Haibing

Subject: Re: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings

On 2020/9/10 22:57, Lubomir Rintel wrote:
> On Thu, Sep 10, 2020 at 05:18:15PM +0800, Yuehaibing wrote:
>> On 2020/9/10 16:22, Lubomir Rintel wrote:
>>> On Thu, Sep 10, 2020 at 04:09:33PM +0800, YueHaibing wrote:
>>>> If CONFIG_PM is n, gcc warns:
>>>>
>>>> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function]
>>>> static int mmpcam_resume(struct device *dev)
>>>> ^~~~~~~~~~~~~
>>>> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function]
>>>> static int mmpcam_suspend(struct device *dev)
>>>> ^~~~~~~~~~~~~~
>>>> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
>>>> static int mmpcam_runtime_suspend(struct device *dev)
>>>> ^~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
>>>> static int mmpcam_runtime_resume(struct device *dev)
>>>> ^~~~~~~~~~~~~~~~~~~~~
>>>>
>>>> Mark them as __maybe_unused to fix this.
>>>>
>>>> Reported-by: Hulk Robot <[email protected]>
>>>> Signed-off-by: YueHaibing <[email protected]>
>>>
>>> Your colleague seems to sent out an equivalent patch:
>>> https://lore.kernel.org/lkml/[email protected]/
>>
>> This is my patch, paste an wrong link?
>
> Indeed, sorry for the confusion.
>
> The original mail only went to linux-media, not lkml, which is why I
> picked the wrong one from the archive. Here's the patch:
>
> https://lore.kernel.org/linux-media/[email protected]/

mmpcam_runtime_suspend/mmpcam_runtime_resume also should be cared, I'll adjust my patch based on it.

>
> Take care
> Lubo
>
>>
>>>
>>> Cheers
>>> Lubo
>>>
>>>> ---
>>>> drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
>>>> index c4b28a00a3a2..032fdddbbecc 100644
>>>> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
>>>> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
>>>> @@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
>>>> * Suspend/resume support.
>>>> */
>>>>
>>>> -static int mmpcam_runtime_resume(struct device *dev)
>>>> +static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
>>>> {
>>>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>>> struct mcam_camera *mcam = &cam->mcam;
>>>> @@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
>>>> return 0;
>>>> }
>>>>
>>>> -static int mmpcam_runtime_suspend(struct device *dev)
>>>> +static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
>>>> {
>>>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>>> struct mcam_camera *mcam = &cam->mcam;
>>>> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)
>>>> return 0;
>>>> }
>>>>
>>>> -static int mmpcam_suspend(struct device *dev)
>>>> +static int __maybe_unused mmpcam_suspend(struct device *dev)
>>>> {
>>>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>>>
>>>> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)
>>>> return 0;
>>>> }
>>>>
>>>> -static int mmpcam_resume(struct device *dev)
>>>> +static int __maybe_unused mmpcam_resume(struct device *dev)
>>>> {
>>>> struct mmp_camera *cam = dev_get_drvdata(dev);
>>>>
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>
>>> .
>>>
>>
>
> .
>

2020-09-11 11:48:44

by Yue Haibing

Subject: [PATCH v2 -next] media: marvell-ccic: Fix -Wunused-function warnings

If CONFIG_PM is n, gcc warns:

drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
static int mmpcam_runtime_suspend(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
static int mmpcam_runtime_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~

Mark them as __maybe_unused to fix this.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
v2: Adjust based on https://lore.kernel.org/linux-media/[email protected]/
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
index c4b28a00a3a2..c046a0ff3b85 100644
--- a/drivers/media/platform/marvell-ccic/mmp-driver.c
+++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
@@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)
* Suspend/resume support.
*/

-static int mmpcam_runtime_resume(struct device *dev)
+static int __maybe_unused mmpcam_runtime_resume(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);
struct mcam_camera *mcam = &cam->mcam;
@@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)
return 0;
}

-static int mmpcam_runtime_suspend(struct device *dev)
+static int __maybe_unused mmpcam_runtime_suspend(struct device *dev)
{
struct mmp_camera *cam = dev_get_drvdata(dev);
struct mcam_camera *mcam = &cam->mcam;
--
2.17.1

2020-10-14 21:47:44

by Geert Uytterhoeven

Subject: Re: [PATCH v2 -next] media: marvell-ccic: Fix -Wunused-function warnings

On Fri, Sep 11, 2020 at 1:50 PM YueHaibing <[email protected]> wrote:
> If CONFIG_PM is n, gcc warns:
>
> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function]
> static int mmpcam_runtime_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function]
> static int mmpcam_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds