2020-09-10 19:14:13

by Wang Hai

Subject: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

Wang Hai (3):
i40e: Fix some kernel-doc warnings in i40e_client.c
i40e: Fix some kernel-doc warnings in i40e_common.c
i40e: Fix a kernel-doc warning in i40e_ptp.c

drivers/net/ethernet/intel/i40e/i40e_client.c | 2 --
drivers/net/ethernet/intel/i40e/i40e_common.c | 2 --
drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 -
3 files changed, 5 deletions(-)

--
2.17.1

2020-09-10 19:14:57

by Wang Hai

Subject: [PATCH net-next 1/3] i40e: Fix some kernel-doc warnings in i40e_client.c

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/intel/i40e/i40e_client.c:286: warning: Excess function parameter 'client' description in 'i40e_client_add_instance'
drivers/net/ethernet/intel/i40e/i40e_client.c:286: warning: Excess function parameter 'existing' description in 'i40e_client_add_instance'

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
drivers/net/ethernet/intel/i40e/i40e_client.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index befd3018183f..a2dba32383f6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -278,8 +278,6 @@ void i40e_client_update_msix_info(struct i40e_pf *pf)
/**
* i40e_client_add_instance - add a client instance struct to the instance list
* @pf: pointer to the board struct
- * @client: pointer to a client struct in the client list.
- * @existing: if there was already an existing instance
*
**/
static void i40e_client_add_instance(struct i40e_pf *pf)
--
2.17.1

2020-09-10 19:16:27

by Wang Hai

Subject: [PATCH net-next 2/3] i40e: Fix some kernel-doc warnings in i40e_common.c

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/intel/i40e/i40e_common.c:3778: warning: Excess function parameter 'buff' description in 'i40e_aq_start_lldp'
drivers/net/ethernet/intel/i40e/i40e_common.c:3778: warning: Excess function parameter 'buff_size' description in 'i40e_aq_start_lldp'

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index 6ab52cbd697a..361329874d98 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -3766,9 +3766,7 @@ i40e_status i40e_aq_stop_lldp(struct i40e_hw *hw, bool shutdown_agent,
/**
* i40e_aq_start_lldp
* @hw: pointer to the hw struct
- * @buff: buffer for result
* @persist: True if start of LLDP should be persistent across power cycles
- * @buff_size: buffer size
* @cmd_details: pointer to command details structure or NULL
*
* Start the embedded LLDP Agent on all ports.
--
2.17.1

2020-09-11 00:51:22

by Jesse Brandeburg

Subject: Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

Wang Hai wrote:

> Wang Hai (3):
> i40e: Fix some kernel-doc warnings in i40e_client.c
> i40e: Fix some kernel-doc warnings in i40e_common.c
> i40e: Fix a kernel-doc warning in i40e_ptp.c
>
> drivers/net/ethernet/intel/i40e/i40e_client.c | 2 --
> drivers/net/ethernet/intel/i40e/i40e_common.c | 2 --
> drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 -
> 3 files changed, 5 deletions(-)
>


Please see my patchset [1]: I've already fixed all of these and many
others.

In fact, before you continue, I have a whole set done making the entire
drivers/net/ethernet directory compile cleanly with W=1, that I'm about
to send, but they depend on [1]

[1]
https://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=&submitter=189&state=&q=&archive=&delegate=