2020-09-11 07:14:17

by Jing Xiangfeng

Subject: [PATCH] sbus: char: Remove meaningless jump label out_free

After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
version of kzalloc"), The out_free jump label has nothing to do but goto
out. So remove it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/sbus/char/display7seg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
index fad936eb845f..00e72b97d0b6 100644
--- a/drivers/sbus/char/display7seg.c
+++ b/drivers/sbus/char/display7seg.c
@@ -186,7 +186,7 @@ static int d7s_probe(struct platform_device *op)
p->regs = of_ioremap(&op->resource[0], 0, sizeof(u8), "d7s");
if (!p->regs) {
printk(KERN_ERR PFX "Cannot map chip registers\n");
- goto out_free;
+ goto out;
}

err = misc_register(&d7s_miscdev);
@@ -228,8 +228,6 @@ static int d7s_probe(struct platform_device *op)

out_iounmap:
of_iounmap(&op->resource[0], p->regs, sizeof(u8));
-
-out_free:
goto out;
}

--
2.17.1

2020-09-15 00:07:35

by David Miller

Subject: Re: [PATCH] sbus: char: Remove meaningless jump label out_free

From: Jing Xiangfeng <[email protected]>
Date: Fri, 11 Sep 2020 15:13:41 +0800

> After commit 57a4a3d7f756 ("display7seg: Introduce the use of the managed
> version of kzalloc"), The out_free jump label has nothing to do but goto
> out. So remove it.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Applied, thank you.