2020-09-11 08:10:08

by Camel Guo

Subject: [PATCH v2 2/3] ASoC: tlv320adcx140: Add support for configuring GPIO pin

From: Camel Guo <[email protected]>

Add support to configure the GPIO pin to the specific configuration.
The GPIO pin can be configured as GPO, IRQ, SDOUT2, PDMCLK, MICBASE_EN,
GPI, MCLK, SDIN, PDMDIN1, PDMDIN2, PDMDIN3 or PDMDIN4 and the output
drive can be configured with various configuration.

Signed-off-by: Camel Guo <[email protected]>
---
sound/soc/codecs/tlv320adcx140.c | 44 ++++++++++++++++++++++++++++++++
sound/soc/codecs/tlv320adcx140.h | 4 +++
2 files changed, 48 insertions(+)

diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
index f33ee604ee78..97f16fbba441 100644
--- a/sound/soc/codecs/tlv320adcx140.c
+++ b/sound/soc/codecs/tlv320adcx140.c
@@ -837,6 +837,46 @@ static int adcx140_configure_gpo(struct adcx140_priv *adcx140)

}

+static int adcx140_configure_gpio(struct adcx140_priv *adcx140)
+{
+ int gpio_count = 0;
+ u32 gpio_outputs[2];
+ u32 gpio_output_val = 0;
+ int ret;
+
+ gpio_count = device_property_count_u32(adcx140->dev,
+ "ti,gpio-config");
+ if (gpio_count == 0)
+ return 0;
+
+ if (gpio_count != 2)
+ return -EINVAL;
+
+ ret = device_property_read_u32_array(adcx140->dev, "ti,gpio-config",
+ gpio_outputs, gpio_count);
+ if (ret)
+ return ret;
+
+ if (gpio_outputs[0] > ADCX140_GPIO_CFG_MAX) {
+ dev_err(adcx140->dev, "GPIO config out of range\n");
+ return -EINVAL;
+ }
+
+ if (gpio_outputs[1] > ADCX140_GPIO_DRV_MAX) {
+ dev_err(adcx140->dev, "GPIO drive out of range\n");
+ return -EINVAL;
+ }
+
+ gpio_output_val = gpio_outputs[0] << ADCX140_GPIO_SHIFT
+ | gpio_outputs[1];
+
+ ret = regmap_write(adcx140->regmap, ADCX140_GPIO_CFG0, gpio_output_val);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
static int adcx140_codec_probe(struct snd_soc_component *component)
{
struct adcx140_priv *adcx140 = snd_soc_component_get_drvdata(component);
@@ -934,6 +974,10 @@ static int adcx140_codec_probe(struct snd_soc_component *component)
return ret;
}

+ ret = adcx140_configure_gpio(adcx140);
+ if (ret)
+ return ret;
+
ret = adcx140_configure_gpo(adcx140);
if (ret)
goto out;
diff --git a/sound/soc/codecs/tlv320adcx140.h b/sound/soc/codecs/tlv320adcx140.h
index eedbc1d7221f..96f067e65e2a 100644
--- a/sound/soc/codecs/tlv320adcx140.h
+++ b/sound/soc/codecs/tlv320adcx140.h
@@ -145,4 +145,8 @@
#define ADCX140_GPO_CFG_MAX 4
#define ADCX140_GPO_DRV_MAX 5

+#define ADCX140_GPIO_SHIFT 4
+#define ADCX140_GPIO_CFG_MAX 15
+#define ADCX140_GPIO_DRV_MAX 5
+
#endif /* _TLV320ADCX140_ */
--
2.20.1

2020-09-15 18:45:12

by Dan Murphy

Subject: Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add support for configuring GPIO pin

Camel

On 9/11/20 3:07 AM, Camel Guo wrote:
> From: Camel Guo <[email protected]>
>
> Add support to configure the GPIO pin to the specific configuration.
> The GPIO pin can be configured as GPO, IRQ, SDOUT2, PDMCLK, MICBASE_EN,
> GPI, MCLK, SDIN, PDMDIN1, PDMDIN2, PDMDIN3 or PDMDIN4 and the output
> drive can be configured with various configuration.
>
> Signed-off-by: Camel Guo <[email protected]>
> ---
> sound/soc/codecs/tlv320adcx140.c | 44 ++++++++++++++++++++++++++++++++
> sound/soc/codecs/tlv320adcx140.h | 4 +++
> 2 files changed, 48 insertions(+)
>
> diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
> index f33ee604ee78..97f16fbba441 100644
> --- a/sound/soc/codecs/tlv320adcx140.c
> +++ b/sound/soc/codecs/tlv320adcx140.c
> @@ -837,6 +837,46 @@ static int adcx140_configure_gpo(struct adcx140_priv *adcx140)
>
> }
>
> +static int adcx140_configure_gpio(struct adcx140_priv *adcx140)
> +{
> + int gpio_count = 0;
> + u32 gpio_outputs[2];

This is #defined in configure_gpo and configure_gpi would like to see
the consistency here.

> + u32 gpio_output_val = 0;
> + int ret;
> +
> + gpio_count = device_property_count_u32(adcx140->dev,
> + "ti,gpio-config");
> + if (gpio_count == 0)
> + return 0;
> +
> + if (gpio_count != 2)
Same comment as above.
> + return -EINVAL;
> +
> + ret = device_property_read_u32_array(adcx140->dev, "ti,gpio-config",
> + gpio_outputs, gpio_count);
> + if (ret)
> + return ret;
> +
> + if (gpio_outputs[0] > ADCX140_GPIO_CFG_MAX) {
> + dev_err(adcx140->dev, "GPIO config out of range\n");
> + return -EINVAL;
> + }
> +
> + if (gpio_outputs[1] > ADCX140_GPIO_DRV_MAX) {
> + dev_err(adcx140->dev, "GPIO drive out of range\n");
> + return -EINVAL;
> + }
> +
> + gpio_output_val = gpio_outputs[0] << ADCX140_GPIO_SHIFT
> + | gpio_outputs[1];
> +
> + ret = regmap_write(adcx140->regmap, ADCX140_GPIO_CFG0, gpio_output_val);
> + if (ret)
> + return ret;

Just do return regmap_write no reason to check it. It is checked by the
caller.


Dan

2020-09-15 19:13:13

by Dan Murphy

Subject: Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add support for configuring GPIO pin

Camel

On 9/15/20 1:41 PM, Dan Murphy wrote:
> Camel
>
> On 9/11/20 3:07 AM, Camel Guo wrote:
>> From: Camel Guo <[email protected]>


One other thing for the device tree you need to add Rob Herring and
[email protected]