2020-09-11 19:47:59

by David E. Box

[permalink] [raw]
Subject: [PATCH 2/3] mfd: intel_pmt: Add Alder Lake (ADL) support

Add PMT support for Alder Lake (ADL). Use same quirks as Tiger Lake since
the design is the same, meaning no support for Watcher or Crashlog.

Signed-off-by: David E. Box <[email protected]>
---
drivers/mfd/intel_pmt.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_pmt.c
index 8f9970ab3026..1b57a970a9d7 100644
--- a/drivers/mfd/intel_pmt.c
+++ b/drivers/mfd/intel_pmt.c
@@ -202,9 +202,11 @@ static void pmt_pci_remove(struct pci_dev *pdev)
pm_runtime_get_sync(&pdev->dev);
}

+#define PCI_DEVICE_ID_INTEL_PMT_ADL 0x467d
#define PCI_DEVICE_ID_INTEL_PMT_OOBMSM 0x09a7
#define PCI_DEVICE_ID_INTEL_PMT_TGL 0x9a0d
static const struct pci_device_id pmt_pci_ids[] = {
+ { PCI_DEVICE_DATA(INTEL, PMT_ADL, &tgl_info) },
{ PCI_DEVICE_DATA(INTEL, PMT_OOBMSM, &pmt_info) },
{ PCI_DEVICE_DATA(INTEL, PMT_TGL, &tgl_info) },
{ }
--
2.20.1


2020-09-14 13:06:50

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH 2/3] mfd: intel_pmt: Add Alder Lake (ADL) support

Hi,

On 9/11/20 9:45 PM, David E. Box wrote:
> Add PMT support for Alder Lake (ADL). Use same quirks as Tiger Lake since
> the design is the same, meaning no support for Watcher or Crashlog.
>
> Signed-off-by: David E. Box <[email protected]>

Looks good to me:

Acked-by: Hans de Goede <[email protected]>

Lee, I expect you will pick this-one up (and the next also) ?

Regards,

Hans



> ---
> drivers/mfd/intel_pmt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_pmt.c
> index 8f9970ab3026..1b57a970a9d7 100644
> --- a/drivers/mfd/intel_pmt.c
> +++ b/drivers/mfd/intel_pmt.c
> @@ -202,9 +202,11 @@ static void pmt_pci_remove(struct pci_dev *pdev)
> pm_runtime_get_sync(&pdev->dev);
> }
>
> +#define PCI_DEVICE_ID_INTEL_PMT_ADL 0x467d
> #define PCI_DEVICE_ID_INTEL_PMT_OOBMSM 0x09a7
> #define PCI_DEVICE_ID_INTEL_PMT_TGL 0x9a0d
> static const struct pci_device_id pmt_pci_ids[] = {
> + { PCI_DEVICE_DATA(INTEL, PMT_ADL, &tgl_info) },
> { PCI_DEVICE_DATA(INTEL, PMT_OOBMSM, &pmt_info) },
> { PCI_DEVICE_DATA(INTEL, PMT_TGL, &tgl_info) },
> { }
>