This adds dt bindings for the APU present in the MT8183.
Signed-off-by: Alexandre Bailon <[email protected]>
---
.../bindings/remoteproc/mtk,apu.yaml | 107 ++++++++++++++++++
1 file changed, 107 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
new file mode 100644
index 000000000000..7a71d2f5c4e6
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
@@ -0,0 +1,107 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+
+---
+$id: "http://devicetree.org/schemas/remoteproc/mtk,apu.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MT8183 AI Processor Unit (APU) a.k.a. Vision Processor Unit (VPU)
+
+description:
+ This document defines the binding for the APU, a co-processor that could
+ offload the CPU for machine learning and neural network.
+
+maintainers:
+ - Alexandre Bailon <[email protected]>
+
+properties:
+ compatible:
+ const: mediatek,mt8183-apu
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ description:
+ Three clocks are expected for AXI, IPU and JTAG.
+ The JTAG clock seems to be required to run the DSP,
+ even when JTAG is not in use."
+ maxItems: 3
+
+ clock-names:
+ items:
+ - const: axi
+ - const: ipu
+ - const: jtag
+
+ iommus:
+ maxItems: 3
+
+ memory-region:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ pinctrl:
+ description: pinctrl handles, required to configure pins for JTAG.
+
+ pinctrl-names:
+ items:
+ - const: jtag
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - iommus
+ - memory-region
+ - power-domains
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8183-clk.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/memory/mt8183-larb-port.h>
+ #include <dt-bindings/power/mt8183-power.h>
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ apu_ram: apu_ram@0x60000000 {
+ compatible = "shared-dma-pool";
+ reg = <0x60000000 0x040000000>;
+ no-map;
+ linux,cma-default;
+ };
+ };
+
+ apu0: apu@19100000 {
+ compatible = "mediatek,mt8183-apu";
+ reg = <0x19180000 0x14000>;
+ interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_LOW>;
+
+ iommus = <&iommu M4U_PORT_IMG_IPUO>,
+ <&iommu M4U_PORT_IMG_IPU3O>,
+ <&iommu M4U_PORT_IMG_IPUI>;
+
+ clocks = <&ipu_core0 CLK_IPU_CORE0_AXI>,
+ <&ipu_core0 CLK_IPU_CORE0_IPU>,
+ <&ipu_core0 CLK_IPU_CORE0_JTAG>;
+
+ clock-names = "axi", "ipu", "jtag";
+
+ power-domains = <&scpsys MT8183_POWER_DOMAIN_VPU_CORE0>;
+ memory-region = <&apu_ram>;
+ };
+...
--
2.26.2
On Thu, 10 Sep 2020 15:01:45 +0200, Alexandre Bailon wrote:
> This adds dt bindings for the APU present in the MT8183.
>
> Signed-off-by: Alexandre Bailon <[email protected]>
> ---
> .../bindings/remoteproc/mtk,apu.yaml | 107 ++++++++++++++++++
> 1 file changed, 107 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/remoteproc/mtk,apu.example.dts:22:18: fatal error: dt-bindings/power/mt8183-power.h: No such file or directory
22 | #include <dt-bindings/power/mt8183-power.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/remoteproc/mtk,apu.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1366: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1362090
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
On Thu, 10 Sep 2020 15:01:45 +0200, Alexandre Bailon wrote:
> This adds dt bindings for the APU present in the MT8183.
>
> Signed-off-by: Alexandre Bailon <[email protected]>
> ---
> .../bindings/remoteproc/mtk,apu.yaml | 107 ++++++++++++++++++
> 1 file changed, 107 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
>
Reviewed-by: Rob Herring <[email protected]>
On Thu, Sep 10, 2020 at 03:01:45PM +0200, Alexandre Bailon wrote:
> This adds dt bindings for the APU present in the MT8183.
>
> Signed-off-by: Alexandre Bailon <[email protected]>
> ---
> .../bindings/remoteproc/mtk,apu.yaml | 107 ++++++++++++++++++
> 1 file changed, 107 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
> new file mode 100644
> index 000000000000..7a71d2f5c4e6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,apu.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +
> +---
> +$id: "http://devicetree.org/schemas/remoteproc/mtk,apu.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MT8183 AI Processor Unit (APU) a.k.a. Vision Processor Unit (VPU)
> +
> +description:
> + This document defines the binding for the APU, a co-processor that could
> + offload the CPU for machine learning and neural network.
> +
> +maintainers:
> + - Alexandre Bailon <[email protected]>
> +
> +properties:
> + compatible:
> + const: mediatek,mt8183-apu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + description:
> + Three clocks are expected for AXI, IPU and JTAG.
> + The JTAG clock seems to be required to run the DSP,
> + even when JTAG is not in use."
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: axi
> + - const: ipu
> + - const: jtag
> +
> + iommus:
> + maxItems: 3
> +
> + memory-region:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + pinctrl:
> + description: pinctrl handles, required to configure pins for JTAG.
> +
> + pinctrl-names:
> + items:
> + - const: jtag
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - iommus
> + - memory-region
> + - power-domains
> +
> +additionalProperties: false
> +
What about the pintctrl for the JTAG part?
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8183-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/memory/mt8183-larb-port.h>
> + #include <dt-bindings/power/mt8183-power.h>
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + apu_ram: apu_ram@0x60000000 {
> + compatible = "shared-dma-pool";
> + reg = <0x60000000 0x040000000>;
> + no-map;
> + linux,cma-default;
> + };
> + };
> +
> + apu0: apu@19100000 {
> + compatible = "mediatek,mt8183-apu";
> + reg = <0x19180000 0x14000>;
> + interrupts = <GIC_SPI 292 IRQ_TYPE_LEVEL_LOW>;
> +
> + iommus = <&iommu M4U_PORT_IMG_IPUO>,
> + <&iommu M4U_PORT_IMG_IPU3O>,
> + <&iommu M4U_PORT_IMG_IPUI>;
> +
> + clocks = <&ipu_core0 CLK_IPU_CORE0_AXI>,
> + <&ipu_core0 CLK_IPU_CORE0_IPU>,
> + <&ipu_core0 CLK_IPU_CORE0_JTAG>;
> +
> + clock-names = "axi", "ipu", "jtag";
> +
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_VPU_CORE0>;
> + memory-region = <&apu_ram>;
> + };
> +...
> --
> 2.26.2
>