2020-09-08 10:17:34

by Peng Fan

Subject: [PATCH] firmware: imx: scu-pd: ignore power domain not owned

From: Peng Fan <[email protected]>

Should not register power domain that not owned by current
partition.

Alought power domains will not be registered when power on failure,
we have to let CPU waste more cycles.

Whether power on or owned check, both need communicate with SCU,
but with owned check, we no need to run more code path to save CPU
cycles.

Signed-off-by: Peng Fan <[email protected]>
Reviewed-by: Leonard Crestez <[email protected]>
---
drivers/firmware/imx/scu-pd.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index af3d6d9ead28..946eea292b52 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -46,6 +46,7 @@

#include <dt-bindings/firmware/imx/rsrc.h>
#include <linux/firmware/imx/sci.h>
+#include <linux/firmware/imx/svc/rm.h>
#include <linux/io.h>
#include <linux/module.h>
#include <linux/of.h>
@@ -256,6 +257,9 @@ imx_scu_add_pm_domain(struct device *dev, int idx,
struct imx_sc_pm_domain *sc_pd;
int ret;

+ if (!imx_sc_rm_is_resource_owned(pm_ipc_handle, pd_ranges->rsrc + idx))
+ return NULL;
+
sc_pd = devm_kzalloc(dev, sizeof(*sc_pd), GFP_KERNEL);
if (!sc_pd)
return ERR_PTR(-ENOMEM);
--
2.28.0

2020-09-13 01:48:11

by Shawn Guo

Subject: Re: [PATCH] firmware: imx: scu-pd: ignore power domain not owned

On Tue, Sep 08, 2020 at 06:07:01PM +0800, [email protected] wrote:
> From: Peng Fan <[email protected]>
>
> Should not register power domain that not owned by current
> partition.
>
> Alought power domains will not be registered when power on failure,
> we have to let CPU waste more cycles.
>
> Whether power on or owned check, both need communicate with SCU,
> but with owned check, we no need to run more code path to save CPU
> cycles.
>
> Signed-off-by: Peng Fan <[email protected]>
> Reviewed-by: Leonard Crestez <[email protected]>

Applied, thanks.