2020-09-13 23:08:14

by Drew Fustini

Subject: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
to print the correct pinctrl register value when #pinctrl-cells is 2.

Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
Reported-by: Trent Piepho <[email protected]>
Link: https://lore.kernel.org/linux-omap/[email protected]/
Signed-off-by: Drew Fustini <[email protected]>
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3
which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/[email protected]/

drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 5cbf0e55087c..f3cd7e296712 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
}

dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",
- pinctrl_spec.np, offset, pinctrl_spec.args[1]);
+ pinctrl_spec.np, offset, vals[found].val);

pin = pcs_get_pin_by_offset(pcs, offset);
if (pin < 0) {
--
2.25.1

2020-09-23 06:56:04

by Tony Lindgren

Subject: Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

* Drew Fustini <[email protected]> [200913 23:04]:
> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
> to print the correct pinctrl register value when #pinctrl-cells is 2.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <[email protected]>
> Link: https://lore.kernel.org/linux-omap/[email protected]/
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> v2 change:
> this is a fix to my prior email where I referred to #pinctrl-cells = 3
> which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
> https://lore.kernel.org/linux-omap/[email protected]/

Acked-by: Tony Lindgren <[email protected]>

> drivers/pinctrl/pinctrl-single.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 5cbf0e55087c..f3cd7e296712 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
> }
>
> dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",
> - pinctrl_spec.np, offset, pinctrl_spec.args[1]);
> + pinctrl_spec.np, offset, vals[found].val);
>
> pin = pcs_get_pin_by_offset(pcs, offset);
> if (pin < 0) {
> --
> 2.25.1
>

2020-10-01 08:08:30

by Linus Walleij

Subject: Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

On Mon, Sep 14, 2020 at 1:04 AM Drew Fustini <[email protected]> wrote:

> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
> to print the correct pinctrl register value when #pinctrl-cells is 2.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <[email protected]>
> Link: https://lore.kernel.org/linux-omap/[email protected]/
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> v2 change:
> this is a fix to my prior email where I referred to #pinctrl-cells = 3
> which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
> https://lore.kernel.org/linux-omap/[email protected]/

Patch applied!

Yours,
Linus Walleij