2020-09-14 03:56:36

by Liu Shixin

Subject: [PATCH -next] soc/qman: convert to use be32_add_cpu()

Signed-off-by: Liu Shixin <[email protected]>
drivers/soc/fsl/qbman/qman_test_api.c---
drivers/soc/fsl/qbman/qman_test_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qbman/qman_test_api.c b/drivers/soc/fsl/qbman/qman_test_api.c
index 2895d062cf51..7066b2f1467c 100644
--- a/drivers/soc/fsl/qbman/qman_test_api.c
+++ b/drivers/soc/fsl/qbman/qman_test_api.c
@@ -86,7 +86,7 @@ static void fd_inc(struct qm_fd *fd)
len--;
qm_fd_set_param(fd, fmt, off, len);

- fd->cmd = cpu_to_be32(be32_to_cpu(fd->cmd) + 1);
+ be32_add_cpu(&fd->cmd, 1);
}

/* The only part of the 'fd' we can't memcmp() is the ppid */
--
2.25.1

2020-09-23 00:04:29

by Leo Li

Subject: Re: [PATCH -next] soc/qman: convert to use be32_add_cpu()

On Sun, Sep 13, 2020 at 10:56 PM Liu Shixin <[email protected]> wrote:
>
> Signed-off-by: Liu Shixin <[email protected]>
> drivers/soc/fsl/qbman/qman_test_api.c---

The patch seems to be messed up here.

I have fixed that, and applied for next. Thanks.

> drivers/soc/fsl/qbman/qman_test_api.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qbman/qman_test_api.c b/drivers/soc/fsl/qbman/qman_test_api.c
> index 2895d062cf51..7066b2f1467c 100644
> --- a/drivers/soc/fsl/qbman/qman_test_api.c
> +++ b/drivers/soc/fsl/qbman/qman_test_api.c
> @@ -86,7 +86,7 @@ static void fd_inc(struct qm_fd *fd)
> len--;
> qm_fd_set_param(fd, fmt, off, len);
>
> - fd->cmd = cpu_to_be32(be32_to_cpu(fd->cmd) + 1);
> + be32_add_cpu(&fd->cmd, 1);
> }
>
> /* The only part of the 'fd' we can't memcmp() is the ppid */
> --
> 2.25.1
>