2020-09-15 14:35:17

by Robert Foss

[permalink] [raw]
Subject: [PATCH v1] arm64: dts: qcom: msm8996: Add VFE1_GDSC power domain to camss node

As the MSM8996 has two VFE IP-blocks, and each has a power domain,
both of them have to be enabled. Previously only the power domain
of VFE0 was enabled, but not the domain for VFE1.

This patch adds the VFE1_GDSC power domain to the camss device tree
node of the MSM8996 soc.

Signed-off-by: Robert Foss <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 9951286db775..df6e1b246a19 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1009,7 +1009,8 @@ camss: camss@a00000 {
"ispif",
"vfe0",
"vfe1";
- power-domains = <&mmcc VFE0_GDSC>;
+ power-domains = <&mmcc VFE0_GDSC>,
+ <&mmcc VFE1_GDSC>;
clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
<&mmcc CAMSS_ISPIF_AHB_CLK>,
<&mmcc CAMSS_CSI0PHYTIMER_CLK>,
--
2.25.1


2020-09-15 22:56:12

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: qcom: msm8996: Add VFE1_GDSC power domain to camss node

On Tue 15 Sep 14:23 UTC 2020, Robert Foss wrote:

> As the MSM8996 has two VFE IP-blocks, and each has a power domain,
> both of them have to be enabled. Previously only the power domain
> of VFE0 was enabled, but not the domain for VFE1.
>
> This patch adds the VFE1_GDSC power domain to the camss device tree
> node of the MSM8996 soc.
>
> Signed-off-by: Robert Foss <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 9951286db775..df6e1b246a19 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1009,7 +1009,8 @@ camss: camss@a00000 {
> "ispif",
> "vfe0",
> "vfe1";
> - power-domains = <&mmcc VFE0_GDSC>;
> + power-domains = <&mmcc VFE0_GDSC>,
> + <&mmcc VFE1_GDSC>;

Fixed the indentation and applied this.

Thanks,
Bjorn

> clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
> <&mmcc CAMSS_ISPIF_AHB_CLK>,
> <&mmcc CAMSS_CSI0PHYTIMER_CLK>,
> --
> 2.25.1
>