2020-09-15 22:57:37

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH v2 0/3] arm64: dts: meson: add support for ODROID-N2+

This series splits the existing meson-g12b-odroid-n2.dts into a common
dtsi and dts, and then adds new bindings and dts for the ODROID-N2+
which uses an Amlogic S922X rev.C chip that Hardkernel supports with
the same OPPs as the A311D.

Changes since v1 at [1]:
- rebase on khilman's v5.10/dt64
- get all review tags from v1
- use the A311D OPPs, after review of Vendor kernel, the Rev, C uses the same OPPs (freq + voltage)
as the A311D SoC of the same family

[1] https://lkml.kernel.org/r/[email protected]

Christian Hewitt (3):
arm64: dts: meson: convert ODROID-N2 to dtsi
dt-bindings: arm: amlogic: add support for the ODROID-N2+
arm64: dts: meson: add support for the ODROID-N2+

.../devicetree/bindings/arm/amlogic.yaml | 1 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../dts/amlogic/meson-g12b-odroid-n2-plus.dts | 31 +
.../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 618 +----------------
.../dts/amlogic/meson-g12b-odroid-n2.dtsi | 625 ++++++++++++++++++
5 files changed, 659 insertions(+), 617 deletions(-)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi

--
2.22.0


2020-09-15 22:58:48

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH v2 2/3] dt-bindings: arm: amlogic: add support for the ODROID-N2+

From: Christian Hewitt <[email protected]>

HardKernel ODROID-N2+ uses a revised Amlogic S922X v2 chip that supports
higher cpu clock speeds than the original ODROID-N2.

Signed-off-by: Christian Hewitt <[email protected]>
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 5eba9f48823e..12ba8d074370 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -153,6 +153,7 @@ properties:
- azw,gtking
- azw,gtking-pro
- hardkernel,odroid-n2
+ - hardkernel,odroid-n2-plus
- khadas,vim3
- ugoos,am6
- const: amlogic,s922x
--
2.22.0

2020-09-15 22:59:03

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: meson: add support for the ODROID-N2+

From: Christian Hewitt <[email protected]>

HardKernel ODROID-N2+ uses an Amlogic S922X rev. C chip capable of higher
clock speeds than the original ODROID-N2.

The rev. C support a slighly higher VDDCPU_A & VDDCPU_B voltages and supports
the same OPPs as the Amlogic A311D SoC from the same G12B family.

Suggested-by: Dongjin Kim <[email protected]>
Signed-off-by: Christian Hewitt <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../dts/amlogic/meson-g12b-odroid-n2-plus.dts | 31 +++++++++++++++++++
2 files changed, 32 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 4e2239ffcaa5..b0b3d6791499 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-gtking-pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
new file mode 100644
index 000000000000..5de2815ba99d
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 BayLibre, SAS
+ * Author: Neil Armstrong <[email protected]>
+ */
+
+/dts-v1/;
+
+/* The Amlogic S922X Rev. C supports the same OPPs as the A311D variant */
+#include "meson-g12b-a311d.dtsi"
+#include "meson-g12b-odroid-n2.dtsi"
+
+/ {
+ compatible = "hardkernel,odroid-n2-plus", "amlogic,s922x", "amlogic,g12b";
+ model = "Hardkernel ODROID-N2Plus";
+};
+
+&vddcpu_a {
+ regulator-min-microvolt = <680000>;
+ regulator-max-microvolt = <1040000>;
+
+ pwms = <&pwm_AO_cd 1 1500 0>;
+};
+
+&vddcpu_b {
+ regulator-min-microvolt = <680000>;
+ regulator-max-microvolt = <1040000>;
+
+ pwms = <&pwm_AO_cd 1 1500 0>;
+};
+
--
2.22.0

2020-09-18 20:41:18

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] arm64: dts: meson: add support for ODROID-N2+

On Tue, 15 Sep 2020 17:24:29 +0200, Neil Armstrong wrote:
> This series splits the existing meson-g12b-odroid-n2.dts into a common
> dtsi and dts, and then adds new bindings and dts for the ODROID-N2+
> which uses an Amlogic S922X rev.C chip that Hardkernel supports with
> the same OPPs as the A311D.
>
> Changes since v1 at [1]:
> - rebase on khilman's v5.10/dt64
> - get all review tags from v1
> - use the A311D OPPs, after review of Vendor kernel, the Rev, C uses the same OPPs (freq + voltage)
> as the A311D SoC of the same family
>
> [...]

Applied, thanks!

[1/3] arm64: dts: meson: convert ODROID-N2 to dtsi
commit: ef599f5f3e10bf1979d8ece29fd7fa511fedd59d
[2/3] dt-bindings: arm: amlogic: add support for the ODROID-N2+
commit: 88ba71cdc5497390350c87e68ce35688e88be3e8
[3/3] arm64: dts: meson: add support for the ODROID-N2+
commit: 98d24896ee117b1f0969405476c943e9307e30d4

Best regards,
--
Kevin Hilman <[email protected]>