2020-09-15 07:05:01

by Jason Yan

Subject: [PATCH] bootconfig: init: make xbc_namebuf static

This eliminates the following sparse warning:

init/main.c:306:6: warning: symbol 'xbc_namebuf' was not declared.
Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/main.c b/init/main.c
index 92773a5daf8d..5ac07eb4a300 100644
--- a/init/main.c
+++ b/init/main.c
@@ -303,7 +303,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)

#ifdef CONFIG_BOOT_CONFIG

-char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
+static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;

#define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)

--
2.25.4

2020-09-15 07:27:09

by Masami Hiramatsu

Subject: Re: [PATCH] bootconfig: init: make xbc_namebuf static

On Tue, 15 Sep 2020 15:03:24 +0800
Jason Yan <[email protected]> wrote:

> This eliminates the following sparse warning:
>
> init/main.c:306:6: warning: symbol 'xbc_namebuf' was not declared.
> Should it be static?


Yes, this looks good to me.

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index 92773a5daf8d..5ac07eb4a300 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -303,7 +303,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
>
> #ifdef CONFIG_BOOT_CONFIG
>
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>
> #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>
> --
> 2.25.4
>


--
Masami Hiramatsu <[email protected]>