2020-09-16 06:13:27

by Satheesh Rajendran

Subject: [PATCH] Doc: admin-guide: Add entry for kvm_cma_resv_ratio kernel param

From: Satheesh Rajendran <[email protected]>

Add document entry for kvm_cma_resv_ratio kernel param which
is used to alter the KVM contiguous memory allocation percentage
for hash pagetable allocation used by hash mode PowerPC KVM guests.

Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Paul Mackerras <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Signed-off-by: Satheesh Rajendran <[email protected]>
---
Documentation/admin-guide/kernel-parameters.txt | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index a1068742a6df..9cb126573c71 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -599,6 +599,15 @@
altogether. For more information, see
include/linux/dma-contiguous.h

+ kvm_cma_resv_ratio=n
+ [PPC]
+ Reserves given percentage from system memory area for
+ contiguous memory allocation for KVM hash pagetable
+ allocation.
+ Bydefault it reserves 5% of total system memory.
+ Format: <integer>
+ Default: 5
+
cmo_free_hint= [PPC] Format: { yes | no }
Specify whether pages are marked as being inactive
when they are freed. This is used in CMO environments
--
2.26.2

2020-09-16 06:20:16

by Randy Dunlap

Subject: Re: [PATCH] Doc: admin-guide: Add entry for kvm_cma_resv_ratio kernel param

On 9/15/20 11:11 PM, [email protected] wrote:
> From: Satheesh Rajendran <[email protected]>
>
> Add document entry for kvm_cma_resv_ratio kernel param which
> is used to alter the KVM contiguous memory allocation percentage
> for hash pagetable allocation used by hash mode PowerPC KVM guests.
>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: Paul Mackerras <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Signed-off-by: Satheesh Rajendran <[email protected]>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index a1068742a6df..9cb126573c71 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -599,6 +599,15 @@
> altogether. For more information, see
> include/linux/dma-contiguous.h
>
> + kvm_cma_resv_ratio=n
> + [PPC]

You can put [PPC] on the line above.

> + Reserves given percentage from system memory area for
> + contiguous memory allocation for KVM hash pagetable
> + allocation.
> + Bydefault it reserves 5% of total system memory.

By default

> + Format: <integer>
> + Default: 5
> +

and please use tabs for indentation, not all spaces.

> cmo_free_hint= [PPC] Format: { yes | no }
> Specify whether pages are marked as being inactive
> when they are freed. This is used in CMO environments
>

Entries in kernel-parameters.txt should be sorted into dictionary order,
so please put that with the other kvm parameters.

thanks.
--
~Randy

2020-09-16 08:05:11

by Satheesh Rajendran

Subject: Re: [PATCH] Doc: admin-guide: Add entry for kvm_cma_resv_ratio kernel param

Hi Randy,

Thanks for the comments, will send a V2 fixing them.

On Tue, Sep 15, 2020 at 11:18:52PM -0700, Randy Dunlap wrote:
> On 9/15/20 11:11 PM, [email protected] wrote:
> > From: Satheesh Rajendran <[email protected]>
> >
> > Add document entry for kvm_cma_resv_ratio kernel param which
> > is used to alter the KVM contiguous memory allocation percentage
> > for hash pagetable allocation used by hash mode PowerPC KVM guests.
> >
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: Paul Mackerras <[email protected]>
> > Cc: Michael Ellerman <[email protected]>
> > Cc: Jonathan Corbet <[email protected]>
> > Signed-off-by: Satheesh Rajendran <[email protected]>
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index a1068742a6df..9cb126573c71 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -599,6 +599,15 @@
> > altogether. For more information, see
> > include/linux/dma-contiguous.h
> >
> > + kvm_cma_resv_ratio=n
> > + [PPC]
>
> You can put [PPC] on the line above.
>
sure
> > + Reserves given percentage from system memory area for
> > + contiguous memory allocation for KVM hash pagetable
> > + allocation.
> > + Bydefault it reserves 5% of total system memory.
>
> By default
>
> > + Format: <integer>
> > + Default: 5
> > +
>
> and please use tabs for indentation, not all spaces.
>
sure
> > cmo_free_hint= [PPC] Format: { yes | no }
> > Specify whether pages are marked as being inactive
> > when they are freed. This is used in CMO environments
> >
>
> Entries in kernel-parameters.txt should be sorted into dictionary order,
> so please put that with the other kvm parameters.
>
sure.
> thanks.
> --
> ~Randy
>

Thanks!
-Satheesh.