2020-09-16 06:25:36

by Qinglang Miao

Subject: [PATCH -next] s390/ap: remove unnecessary spin_lock_init()

The spinlock ap_poll_timer_lock is initialized statically. It is
unnecessary to initialize by spin_lock_init().

Signed-off-by: Qinglang Miao <[email protected]>
---
drivers/s390/crypto/ap_bus.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 24a1940b8..231a98c91 100644
--- a/drivers/s390/crypto/ap_bus.c
+++ b/drivers/s390/crypto/ap_bus.c
@@ -1575,7 +1575,6 @@ static int __init ap_module_init(void)
*/
if (MACHINE_IS_VM)
poll_timeout = 1500000;
- spin_lock_init(&ap_poll_timer_lock);
hrtimer_init(&ap_poll_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
ap_poll_timer.function = ap_poll_timeout;

--
2.23.0

2020-09-16 17:18:57

by Heiko Carstens

Subject: Re: [PATCH -next] s390/ap: remove unnecessary spin_lock_init()

On Wed, Sep 16, 2020 at 02:21:30PM +0800, Qinglang Miao wrote:
> The spinlock ap_poll_timer_lock is initialized statically. It is
> unnecessary to initialize by spin_lock_init().
>
> Signed-off-by: Qinglang Miao <[email protected]>
> ---
> drivers/s390/crypto/ap_bus.c | 1 -
> 1 file changed, 1 deletion(-)

Applied, thanks.