2020-09-16 21:06:21

by Georgi Djakov

[permalink] [raw]
Subject: [PATCH] drm/msm: Remove depends on interconnect

The dependency on interconnect in the Kconfig was introduced to avoid
the case of interconnect=m and driver=y, but the interconnect framework
has been converted from tristate to bool now. Remove the dependency as
the framework can't be a module anymore.

Signed-off-by: Georgi Djakov <[email protected]>
---
drivers/gpu/drm/msm/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 5c55cd0ce9f9..3348969460ab 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -6,7 +6,6 @@ config DRM_MSM
depends on ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)
depends on OF && COMMON_CLK
depends on MMU
- depends on INTERCONNECT || !INTERCONNECT
depends on QCOM_OCMEM || QCOM_OCMEM=n
select QCOM_MDT_LOADER if ARCH_QCOM
select REGULATOR


2020-09-23 14:37:34

by Jordan Crouse

[permalink] [raw]
Subject: Re: [Freedreno] [PATCH] drm/msm: Remove depends on interconnect

On Wed, Sep 16, 2020 at 02:07:06PM +0300, Georgi Djakov wrote:
> The dependency on interconnect in the Kconfig was introduced to avoid
> the case of interconnect=m and driver=y, but the interconnect framework
> has been converted from tristate to bool now. Remove the dependency as
> the framework can't be a module anymore.

QCOM interconnect is still selectable, right? I think we would need to retain
the dependency but drop the ! clause.

Jordan
> Signed-off-by: Georgi Djakov <[email protected]>
> ---
> drivers/gpu/drm/msm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 5c55cd0ce9f9..3348969460ab 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -6,7 +6,6 @@ config DRM_MSM
> depends on ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)
> depends on OF && COMMON_CLK
> depends on MMU
> - depends on INTERCONNECT || !INTERCONNECT
> depends on QCOM_OCMEM || QCOM_OCMEM=n
> select QCOM_MDT_LOADER if ARCH_QCOM
> select REGULATOR
> _______________________________________________
> Freedreno mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/freedreno

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project