2020-09-17 07:10:28

by Liu Shixin

[permalink] [raw]
Subject: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code

Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/scsi/dc395x.c | 25 +------------------------
1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 0c251a3b99b7..fa16894d8758 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -4721,30 +4721,7 @@ static struct pci_driver dc395x_driver = {
.probe = dc395x_init_one,
.remove = dc395x_remove_one,
};
-
-
-/**
- * dc395x_module_init - Module initialization function
- *
- * Used by both module and built-in driver to initialise this driver.
- **/
-static int __init dc395x_module_init(void)
-{
- return pci_register_driver(&dc395x_driver);
-}
-
-
-/**
- * dc395x_module_exit - Module cleanup function.
- **/
-static void __exit dc395x_module_exit(void)
-{
- pci_unregister_driver(&dc395x_driver);
-}
-
-
-module_init(dc395x_module_init);
-module_exit(dc395x_module_exit);
+module_pci_driver(dc395x_driver);

MODULE_AUTHOR("C.L. Huang / Erich Chen / Kurt Garloff");
MODULE_DESCRIPTION("SCSI host adapter driver for Tekram TRM-S1040 based adapters: Tekram DC395 and DC315 series");
--
2.25.1


2020-10-07 03:18:28

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code


Liu,

> Use the module_pci_driver() macro to make the code simpler by
> eliminating module_init and module_exit calls.

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-10-14 10:43:27

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code

On Thu, 17 Sep 2020 15:10:44 +0800, Liu Shixin wrote:

> Use the module_pci_driver() macro to make the code simpler
> by eliminating module_init and module_exit calls.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: dc395x: Use module_pci_driver() to simplify the code
https://git.kernel.org/mkp/scsi/c/75c31c80a77d

--
Martin K. Petersen Oracle Linux Engineering