2020-09-17 11:48:56

by Jing Xiangfeng

Subject: [PATCH] drm/ttm: remove redundant initialization of variable ret

The variable ret is being initialized with '-ENOMEM' that is
meaningless. So remove it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index 3437711ddb43..4db87b9b57a8 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -388,7 +388,7 @@ int ttm_tt_swapout(struct ttm_tt *ttm, struct file *persistent_swap_storage)
struct page *from_page;
struct page *to_page;
int i;
- int ret = -ENOMEM;
+ int ret;

BUG_ON(ttm->state != tt_unbound && ttm->state != tt_unpopulated);
BUG_ON(ttm->caching_state != tt_cached);
--
2.17.1

2020-09-17 12:00:08

by Christian König

Subject: Re: [PATCH] drm/ttm: remove redundant initialization of variable ret

Am 17.09.20 um 13:42 schrieb Jing Xiangfeng:
> The variable ret is being initialized with '-ENOMEM' that is
> meaningless. So remove it.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Stumbled over the same thing just a few days ago, so this is already
fixed in my branch.

> ---
> drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 3437711ddb43..4db87b9b57a8 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -388,7 +388,7 @@ int ttm_tt_swapout(struct ttm_tt *ttm, struct file *persistent_swap_storage)
> struct page *from_page;
> struct page *to_page;
> int i;
> - int ret = -ENOMEM;
> + int ret;
>
> BUG_ON(ttm->state != tt_unbound && ttm->state != tt_unpopulated);
> BUG_ON(ttm->caching_state != tt_cached);