2020-09-16 18:16:13

by Frank Ch. Eigler

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

Hi -

Nice, even uses the source code fetching part of the webapi!

- FChE


2020-09-16 18:55:30

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

Em Wed, Sep 16, 2020 at 02:13:07PM -0400, Frank Ch. Eigler escreveu:
> Hi -
>
> Nice, even uses the source code fetching part of the webapi!

So, can I take that as an Acked-by or Reviewed-by?

:-)

- Arnaldo

I need to support this in pahole...

> - FChE
>

--

- Arnaldo

2020-09-16 20:19:51

by Frank Ch. Eigler

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

Hi -

> > Nice, even uses the source code fetching part of the webapi!
>
> So, can I take that as an Acked-by or Reviewed-by?

Sure.

> I need to support this in pahole...

pahole/dwarves use elfutils, so it already has automatic support.

https://sourceware.org/elfutils/Debuginfod.html

- FChE

2020-09-17 03:17:08

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

On Wed, 16 Sep 2020 16:17:53 -0400
"Frank Ch. Eigler" <[email protected]> wrote:

> Hi -
>
> > > Nice, even uses the source code fetching part of the webapi!
> >
> > So, can I take that as an Acked-by or Reviewed-by?
>
> Sure.

Thanks Frank and Arnaldo!

>
> > I need to support this in pahole...
>
> pahole/dwarves use elfutils, so it already has automatic support.
>
> https://sourceware.org/elfutils/Debuginfod.html

I'm still not sure that which interface of elfutils I should use
for this "automatic" debuginfod support. Are there good documentation
about it?
Since this series just for the kernel binary, I have to check we
can do something on user-space binaries.

Thank you,

--
Masami Hiramatsu <[email protected]>

2020-09-17 14:13:08

by Frank Ch. Eigler

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

Hi -

> > > I need to support this in pahole...
> >
> > pahole/dwarves use elfutils, so it already has automatic support.
> > https://sourceware.org/elfutils/Debuginfod.html
>
> I'm still not sure that which interface of elfutils I should use
> for this "automatic" debuginfod support. Are there good documentation
> about it?

The libdwfl part of the elfutils API falls back to debuginfod lookups
internally, so e.g. systemtap had to do nothing to benefit.


> Since this series just for the kernel binary, I have to check we
> can do something on user-space binaries.

It should work identically & transparently. If you're using one of
a few key packages of a few mainstream distros, the public debuginfod
server may already have the material available.


- FChE

2020-09-17 19:58:49

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH 0/2] perf probe: Support debuginfod client

Em Wed, Sep 16, 2020 at 04:17:53PM -0400, Frank Ch. Eigler escreveu:
> Hi -
>
> > > Nice, even uses the source code fetching part of the webapi!
> >
> > So, can I take that as an Acked-by or Reviewed-by?
>
> Sure.

Thanks, applied both now that the things that made some 'perf probe'
'perf test' entries to fail is out of the way, all passes now with these
patches.

- Arnaldo