2020-09-15 23:46:19

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 000/177] 5.8.10-rc1 review

This is the start of the stable review cycle for the 5.8.10 release.
There are 177 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.8.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.8.10-rc1

Jordan Crouse <[email protected]>
drm/msm: Enable expanded apriv support for a650

Rob Clark <[email protected]>
drm/msm/gpu: make ringbuffer readonly

Utkarsh Patel <[email protected]>
usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes

Utkarsh Patel <[email protected]>
usb: typec: intel_pmc_mux: Do not configure Altmode HPD High

Madhusudanarao Amara <[email protected]>
usb: typec: intel_pmc_mux: Un-register the USB role switch

Heikki Krogerus <[email protected]>
usb: typec: ucsi: acpi: Check the _DEP dependencies

Mathias Nyman <[email protected]>
usb: Fix out of sync data toggle if a configured device is reconfigured

Aleksander Morgado <[email protected]>
USB: serial: option: add support for SIM7070/SIM7080/SIM7090 modules

Bjørn Mork <[email protected]>
USB: serial: option: support dynamic Quectel USB compositions

Patrick Riphagen <[email protected]>
USB: serial: ftdi_sio: add IDs for Xsens Mti USB converter

Zeng Tao <[email protected]>
usb: core: fix slab-out-of-bounds Read in read_descriptors

Sivaprakash Murugesan <[email protected]>
phy: qcom-qmp: Use correct values for ipq8074 PCIe Gen2 PHY init

Vaibhav Agarwal <[email protected]>
staging: greybus: audio: fix uninitialized value issue

Tetsuo Handa <[email protected]>
video: fbdev: fix OOB read in vga_8planes_imageblit()

Chris Healy <[email protected]>
ARM: dts: vfxxx: Add syscon compatible with OCOTP

Robin Gong <[email protected]>
arm64: dts: imx8mp: correct sdma1 clk setting

Kees Cook <[email protected]>
test_firmware: Test platform fw loading on non-EFI systems

Vladis Dronov <[email protected]>
debugfs: Fix module state check condition

Amjad Ouled-Ameur <[email protected]>
Revert "usb: dwc3: meson-g12a: fix shared reset control use"

Rustam Kovhaev <[email protected]>
KVM: fix memory leak in kvm_io_bus_unregister_dev()

Lai Jiangshan <[email protected]>
kvm x86/mmu: use KVM_REQ_MMU_SYNC to sync when needed

Marc Zyngier <[email protected]>
KVM: arm64: Do not try to map PUDs when they are folded into PMD

Wanpeng Li <[email protected]>
KVM: VMX: Don't freeze guest when event delivery causes an APIC-access exit

Linus Torvalds <[email protected]>
vgacon: remove software scrollback support

Linus Torvalds <[email protected]>
fbcon: remove now unusued 'softback_lines' cursor() argument

Linus Torvalds <[email protected]>
fbcon: remove soft scrollback code

Mark Bloch <[email protected]>
RDMA/mlx4: Read pkey table length instead of hardcoded value

Yi Zhang <[email protected]>
RDMA/rxe: Fix the parent sysfs read when the interface has 15 chars

Ilya Dryomov <[email protected]>
rbd: require global CAP_SYS_ADMIN for mapping and unmapping

James Smart <[email protected]>
nvme: Revert: Fix controller creation races with teardown flow

Chris Packham <[email protected]>
mmc: sdhci-of-esdhc: Don't walk device-tree on every interrupt

Adrian Hunter <[email protected]>
mmc: sdio: Use mmc_pre_req() / mmc_post_req()

Jordan Crouse <[email protected]>
drm/msm: Disable the RPTR shadow

Jordan Crouse <[email protected]>
drm/msm: Disable preemption on all 5xx targets

Jordan Crouse <[email protected]>
drm/msm: Split the a5xx preemption record

Linus Walleij <[email protected]>
drm/tve200: Stabilize enable/disable

Hou Pu <[email protected]>
scsi: target: iscsi: Fix hang in iscsit_access_np() when getting tpg->np_login_sem

James Smart <[email protected]>
scsi: lpfc: Fix setting IRQ affinity with an empty CPU mask

Varun Prakash <[email protected]>
scsi: target: iscsi: Fix data digest calculation

Vadym Kochan <[email protected]>
misc: eeprom: at24: register nvmem only after eeprom is ready to use

Dmitry Osipenko <[email protected]>
regulator: core: Fix slab-out-of-bounds in regulator_unlock_recursive()

Michał Mirosław <[email protected]>
regulator: plug of_node leak in regulator_register()'s error path

Michał Mirosław <[email protected]>
regulator: push allocation in set_consumer_device_supply() out of lock

Michał Mirosław <[email protected]>
regulator: push allocations in create_regulator() outside of lock

Michał Mirosław <[email protected]>
regulator: push allocation in regulator_init_coupling() outside of lock

Andy Shevchenko <[email protected]>
kobject: Restore old behaviour of kobject_del(NULL)

Nikunj A. Dadhania <[email protected]>
thunderbolt: Disable ports that are not implemented

Prateek Sood <[email protected]>
firmware_loader: fix memory leak for paged buffer

Filipe Manana <[email protected]>
btrfs: fix wrong address when faulting in pages in the search ioctl

Josef Bacik <[email protected]>
btrfs: free data reloc tree on failed mount

Josef Bacik <[email protected]>
btrfs: fix lockdep splat in add_missing_dev

Qu Wenruo <[email protected]>
btrfs: require only sector size alignment for parent eb bytenr

Rustam Kovhaev <[email protected]>
staging: wlan-ng: fix out of bounds read in prism2sta_probe_usb()

Jonathan Cameron <[email protected]>
iio:accel:mma8452: Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:accel:mma7455: Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio: accel: kxsd9: Fix alignment of local buffer.

Jonathan Cameron <[email protected]>
iio:chemical:ccs811: Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:light:max44000 Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:magnetometer:ak8975 Fix alignment and data leak issues.

Jonathan Cameron <[email protected]>
iio:adc:ti-adc081c Fix alignment and data leak issues

Jonathan Cameron <[email protected]>
iio:adc:max1118 Fix alignment of timestamp and data leak issues

Jonathan Cameron <[email protected]>
iio:adc:ina2xx Fix timestamp alignment issue.

Jonathan Cameron <[email protected]>
iio:adc:ti-adc084s021 Fix alignment and data leak issues.

Jonathan Cameron <[email protected]>
iio:accel:bmc150-accel: Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:proximity:mb1232: Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:light:ltr501 Fix timestamp alignment issue.

Gwendal Grignou <[email protected]>
iio: cros_ec: Set Gyroscope default frequency to 25Hz

Maxim Kochetkov <[email protected]>
iio: adc: ti-ads1015: fix conversion when CONFIG_PM is not set

Angelo Compagnucci <[email protected]>
iio: adc: mcp3422: fix locking scope

Leon Romanovsky <[email protected]>
gcov: Disable gcov build with GCC 10

Joerg Roedel <[email protected]>
iommu/amd: Do not use IOMMUv2 functionality when SME is active

Joerg Roedel <[email protected]>
iommu/amd: Do not force direct mapping when SME is active

Sandeep Raghuraman <[email protected]>
drm/amdgpu: Fix bug in reporting voltage for CIK

Xie He <[email protected]>
drivers/net/wan/hdlc: Change the default of hard_header_len to 0

Pierre-Louis Bossart <[email protected]>
ALSA: hda: use consistent HDAudio spelling in comments/docs

Rander Wang <[email protected]>
ALSA: hda: fix a runtime pm issue in SOF when integrated GPU is disabled

Rander Wang <[email protected]>
ALSA: hda: hdmi - add Rocketlake support

Jessica Yu <[email protected]>
arm64/module: set trampoline section flags regardless of CONFIG_DYNAMIC_FTRACE

Francisco Jerez <[email protected]>
cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max() for turbo disabled

Rafael J. Wysocki <[email protected]>
cpufreq: intel_pstate: Refuse to turn off with HWP enabled

Evgeniy Didin <[email protected]>
ARC: [plat-hsdk]: Switch ethernet phy-mode to rgmii-id

Dinghao Liu <[email protected]>
HID: elan: Fix memleak in elan_input_configured

Xie He <[email protected]>
drivers/net/wan/hdlc_cisco: Add hard_header_len

Nicholas Miell <[email protected]>
HID: microsoft: Add rumble support for the 8bitdo SN30 Pro+ controller

Nirenjan Krishnan <[email protected]>
HID: quirks: Set INCREMENT_USAGE_ON_DUPLICATE for all Saitek X52 devices

Tong Zhang <[email protected]>
nvme-pci: cancel nvme device request before disabling

Sagi Grimberg <[email protected]>
nvme-rdma: fix reset hang if controller died in the middle of a reset

Sagi Grimberg <[email protected]>
nvme-rdma: fix timeout handler

Sagi Grimberg <[email protected]>
nvme-rdma: serialize controller teardown sequences

Sagi Grimberg <[email protected]>
nvme-tcp: fix reset hang if controller died in the middle of a reset

Sagi Grimberg <[email protected]>
nvme-tcp: fix timeout handler

Sagi Grimberg <[email protected]>
nvme-tcp: serialize controller teardown sequences

Sagi Grimberg <[email protected]>
nvme: have nvme_wait_freeze_timeout return if it timed out

Sagi Grimberg <[email protected]>
nvme-fabrics: don't check state NVME_CTRL_NEW for request acceptance

Ziye Yang <[email protected]>
nvmet-tcp: Fix NULL dereference when a connect data comes in h2cdata pdu

Sean Young <[email protected]>
media: gpio-ir-tx: spinlock is not needed to disable interrupts

Vineet Gupta <[email protected]>
irqchip/eznps: Fix build error for !ARC700 builds

Vineet Gupta <[email protected]>
ARC: show_regs: fix r12 printing and simplify

Darrick J. Wong <[email protected]>
xfs: initialize the shortform attr header padding entry

Amar Singhal <[email protected]>
cfg80211: Adjust 6 GHz frequency to channel conversion

Felix Fietkau <[email protected]>
mac80211: reduce packet loss event false positives

Shay Bar <[email protected]>
wireless: fix wrong 160/80+80 MHz setting

Xie He <[email protected]>
drivers/net/wan/lapbether: Set network_header before transmitting

Brian Foster <[email protected]>
xfs: fix off-by-one in inode alloc block reservation calculation

Yi Li <[email protected]>
net: hns3: Fix for geneve tx checksum bug

Madhuparna Bhowmik <[email protected]>
drivers/dma/dma-jz4780: Fix race condition between probe and irq handler

Mohan Kumar <[email protected]>
ALSA: hda/tegra: Program WAKEEN register for Tegra

Mohan Kumar <[email protected]>
ALSA: hda: Fix 2 channel swapping for Tegra

Ye Bin <[email protected]>
scsi: qedf: Fix null ptr reference in qedf_stag_change_work

Dinghao Liu <[email protected]>
firestream: Fix memleak in fs_open

Dinghao Liu <[email protected]>
NFC: st95hf: Fix memleak in st95hf_in_send_cmd

Xie He <[email protected]>
drivers/net/wan/lapbether: Added needed_tailroom

Stefano Brivio <[email protected]>
netfilter: nft_set_rbtree: Detect partial overlap with start endpoint match

Florian Westphal <[email protected]>
netfilter: conntrack: allow sctp hearbeat after connection re-use

Jiaxun Yang <[email protected]>
MIPS: Loongson64: Do not override watch and ejtag feature

Hanjun Guo <[email protected]>
dmaengine: acpi: Put the CSRT table after using it

Vineet Gupta <[email protected]>
ARC: HSDK: wireup perf irq

Vitaly Kuznetsov <[email protected]>
KVM: x86: always allow writing '0' to MSR_KVM_ASYNC_PF_EN

Chenyi Qiang <[email protected]>
KVM: nVMX: Fix the update value of nested load IA32_PERF_GLOBAL_CTRL control

Florian Fainelli <[email protected]>
arm64: dts: ns2: Fixed QSPI compatible string

Florian Fainelli <[email protected]>
ARM: dts: BCM5301X: Fixed QSPI compatible string

Florian Fainelli <[email protected]>
ARM: dts: NSP: Fixed QSPI compatible string

Florian Fainelli <[email protected]>
ARM: dts: bcm: HR2: Fixed QSPI compatible string

Sagi Grimberg <[email protected]>
IB/isert: Fix unaligned immediate-data handling

Md Haris Iqbal <[email protected]>
RDMA/rtrs-srv: Set .release function for rtrs srv device during device init

Ritesh Harjani <[email protected]>
block: Set same_page to false in __bio_try_merge_page if ret is false

Dan Carpenter <[email protected]>
spi: stm32: fix pm_runtime_get_sync() error checking

Sagi Grimberg <[email protected]>
nvme-fabrics: allow to queue requests for live queues

Tycho Andersen <[email protected]>
seccomp: don't leak memory when filter install races

Christoph Hellwig <[email protected]>
block: restore a specific error code in bdev_del_partition

Tali Perry <[email protected]>
i2c: npcm7xx: Fix timeout calculation

Filipe Manana <[email protected]>
btrfs: fix NULL pointer dereference after failure to create snapshot

Marek Vasut <[email protected]>
spi: stm32: Rate-limit the 'Communication suspended' message

Douglas Anderson <[email protected]>
mmc: sdhci-msm: Add retries when all tuning phases are found valid

Raul E Rangel <[email protected]>
mmc: sdhci-acpi: Clear amd_sdhci_host on reset

Fugang Duan <[email protected]>
ARM: dts: imx6sx: fix the pad QSPI1B_SCLK mux mode for uart3

Alexandru Elisei <[email protected]>
KVM: arm64: Update page shift if stage 2 block mapping not supported

Maxime Ripard <[email protected]>
drm/sun4i: backend: Disable alpha on the lowest plane on the A20

Maxime Ripard <[email protected]>
drm/sun4i: backend: Support alpha property on lowest plane

Jernej Skrabec <[email protected]>
drm/sun4i: Fix DE2 YVU handling

Daniel Jordan <[email protected]>
padata: fix possible padata_works_lock deadlock

Mike Tipton <[email protected]>
interconnect: qcom: Fix small BW votes being truncated to zero

Josh Poimboeuf <[email protected]>
Revert "kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled"

Tom Rix <[email protected]>
soundwire: fix double free of dangling pointer

Tomas Henzl <[email protected]>
scsi: mpt3sas: Don't call disable_irq from IRQ poll handler

Tomas Henzl <[email protected]>
scsi: megaraid_sas: Don't call disable_irq from process IRQ poll

Kamal Heib <[email protected]>
RDMA/core: Fix reported speed and width

Xi Wang <[email protected]>
RDMA/core: Fix unsafe linked list traversal after failing to allocate CQ

Gerd Hoffmann <[email protected]>
drm/virtio: fix unblank

Luo Jiaxing <[email protected]>
scsi: libsas: Set data_dir as DMA_NONE if libata marks qc as NODATA

Angelo Compagnucci <[email protected]>
iio: adc: mcp3422: fix locking on error path

René Rebe <[email protected]>
scsi: qla2xxx: Fix regression on sparc64

Ondrej Jirman <[email protected]>
drm/sun4i: Fix dsi dcs long write function

Krzysztof Kozlowski <[email protected]>
arm64: dts: imx8mq: Fix TMU interrupt property

Yu Kuai <[email protected]>
drm/sun4i: add missing put_device() call in sun8i_r40_tcon_tv_set_mux()

Selvin Xavier <[email protected]>
RDMA/bnxt_re: Remove the qp from list only if the qp destroy succeeds

Naresh Kumar PBS <[email protected]>
RDMA/bnxt_re: Fix driver crash on unaligned PSN entry address

Naresh Kumar PBS <[email protected]>
RDMA/bnxt_re: Static NQ depth allocation

Selvin Xavier <[email protected]>
RDMA/bnxt_re: Fix the qp table indexing

Selvin Xavier <[email protected]>
RDMA/bnxt_re: Do not report transparent vlan from QP1

Kamal Heib <[email protected]>
RDMA/rxe: Fix panic when calling kmem_cache_create()

Kamal Heib <[email protected]>
RDMA/rxe: Drop pointless checks in rxe_init_ports

Dinghao Liu <[email protected]>
RDMA/rxe: Fix memleak in rxe_mem_init_user

Md Haris Iqbal <[email protected]>
RDMA/rtrs-srv: Replace device_register with device_initialize and device_add

Chris Healy <[email protected]>
ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

Rob Herring <[email protected]>
arm64: dts: imx: Add missing imx8mm-beacon-kit.dtb to build

Anson Huang <[email protected]>
ARM: dts: imx7ulp: Correct gpio ranges

Matthias Schiffer <[email protected]>
ARM: dts: ls1021a: fix QuadSPI-memory reg range

Po-Hsu Lin <[email protected]>
selftests/timers: Turn off timeout setting

David Shah <[email protected]>
ARM: dts: omap5: Fix DSI base address and clocks

Dinh Nguyen <[email protected]>
ARM: dts: socfpga: fix register entry for timer3 on Arria10

Michał Mirosław <[email protected]>
regulator: remove superfluous lock in regulator_resolve_coupling()

Michał Mirosław <[email protected]>
regulator: push allocation in regulator_ena_gpio_request() out of lock

Adam Ford <[email protected]>
ARM: dts: logicpd-som-lv-baseboard: Fix missing video

Adam Ford <[email protected]>
ARM: dts: logicpd-som-lv-baseboard: Fix broken audio

Adam Ford <[email protected]>
ARM: dts: logicpd-torpedo-baseboard: Fix broken audio

Jing Xiangfeng <[email protected]>
ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()


-------------

Diffstat:

Documentation/sound/designs/timestamping.rst | 2 +-
Makefile | 8 +-
arch/arc/boot/dts/hsdk.dts | 6 +-
arch/arc/kernel/troubleshoot.c | 77 ++---
arch/arc/plat-eznps/include/plat/ctop.h | 1 -
arch/arm/boot/dts/bcm-hr2.dtsi | 2 +-
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
arch/arm/boot/dts/imx6sx-pinfunc.h | 2 +-
arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +-
arch/arm/boot/dts/imx7ulp.dtsi | 8 +-
arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi | 29 +-
arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 2 +
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
arch/arm/boot/dts/omap5.dtsi | 20 +-
arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +-
arch/arm/boot/dts/vfxxx.dtsi | 2 +-
arch/arm/mach-omap2/omap-iommu.c | 2 +-
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +-
arch/arm64/boot/dts/freescale/Makefile | 1 +
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
arch/arm64/kernel/module-plts.c | 3 +-
arch/arm64/kvm/mmu.c | 8 +-
.../asm/mach-loongson64/cpu-feature-overrides.h | 2 -
arch/powerpc/configs/pasemi_defconfig | 1 -
arch/powerpc/configs/ppc6xx_defconfig | 1 -
arch/x86/configs/i386_defconfig | 1 -
arch/x86/configs/x86_64_defconfig | 1 -
arch/x86/kvm/mmu/mmu.c | 2 +-
arch/x86/kvm/vmx/nested.c | 2 +-
arch/x86/kvm/vmx/vmx.c | 1 +
arch/x86/kvm/x86.c | 2 +-
block/bio.c | 4 +-
block/partitions/core.c | 2 +-
drivers/atm/firestream.c | 1 +
drivers/base/firmware_loader/firmware.h | 2 +
drivers/base/firmware_loader/main.c | 17 +-
drivers/block/rbd.c | 12 +
drivers/cpufreq/intel_pstate.c | 14 +-
drivers/dma/acpi-dma.c | 4 +-
drivers/dma/dma-jz4780.c | 38 +--
drivers/firmware/efi/embedded-firmware.c | 10 +-
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 +-
drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 5 +
drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 10 +
drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 10 +
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 14 +-
drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 1 +
drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 25 +-
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 13 +-
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 27 +-
drivers/gpu/drm/msm/msm_gpu.c | 2 +-
drivers/gpu/drm/msm/msm_gpu.h | 11 +
drivers/gpu/drm/msm/msm_ringbuffer.c | 3 +-
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 +-
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 +-
drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +-
drivers/gpu/drm/tve200/tve200_display.c | 22 +-
drivers/gpu/drm/virtio/virtgpu_display.c | 11 +
drivers/gpu/drm/virtio/virtgpu_drv.h | 1 +
drivers/gpu/drm/virtio/virtgpu_plane.c | 4 +-
drivers/hid/hid-elan.c | 2 +
drivers/hid/hid-ids.h | 3 +
drivers/hid/hid-microsoft.c | 2 +
drivers/hid/hid-quirks.c | 2 +
drivers/i2c/busses/i2c-npcm7xx.c | 8 +-
drivers/iio/accel/bmc150-accel-core.c | 15 +-
drivers/iio/accel/kxsd9.c | 16 +-
drivers/iio/accel/mma7455_core.c | 16 +-
drivers/iio/accel/mma8452.c | 11 +-
drivers/iio/adc/ina2xx-adc.c | 11 +-
drivers/iio/adc/max1118.c | 10 +-
drivers/iio/adc/mcp3422.c | 16 +-
drivers/iio/adc/ti-adc081c.c | 11 +-
drivers/iio/adc/ti-adc084s021.c | 10 +-
drivers/iio/adc/ti-ads1015.c | 10 +
drivers/iio/chemical/ccs811.c | 13 +-
.../common/cros_ec_sensors/cros_ec_sensors_core.c | 5 +-
drivers/iio/light/ltr501.c | 15 +-
drivers/iio/light/max44000.c | 12 +-
drivers/iio/magnetometer/ak8975.c | 16 +-
drivers/iio/proximity/mb1232.c | 17 +-
drivers/infiniband/core/cq.c | 4 +-
drivers/infiniband/core/verbs.c | 2 +-
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 43 ++-
drivers/infiniband/hw/bnxt_re/main.c | 3 +-
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 26 +-
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 10 +-
drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 5 +
drivers/infiniband/hw/mlx4/main.c | 3 +-
drivers/infiniband/sw/rxe/rxe.c | 7 +-
drivers/infiniband/sw/rxe/rxe.h | 2 +
drivers/infiniband/sw/rxe/rxe_mr.c | 1 +
drivers/infiniband/sw/rxe/rxe_sysfs.c | 5 +
drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
drivers/infiniband/ulp/isert/ib_isert.c | 93 +++---
drivers/infiniband/ulp/isert/ib_isert.h | 41 ++-
drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 16 +-
drivers/infiniband/ulp/rtrs/rtrs-srv.c | 9 +
drivers/interconnect/qcom/bcm-voter.c | 27 +-
drivers/iommu/amd/iommu.c | 7 +-
drivers/iommu/amd/iommu_v2.c | 7 +
drivers/media/rc/gpio-ir-tx.c | 16 +-
drivers/misc/eeprom/at24.c | 11 +-
drivers/mmc/core/sdio_ops.c | 39 +--
drivers/mmc/host/sdhci-acpi.c | 31 +-
drivers/mmc/host/sdhci-msm.c | 18 +-
drivers/mmc/host/sdhci-of-esdhc.c | 10 +-
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 +-
drivers/net/wan/hdlc.c | 2 +-
drivers/net/wan/hdlc_cisco.c | 1 +
drivers/net/wan/lapbether.c | 3 +
drivers/nfc/st95hf/core.c | 2 +-
drivers/nvme/host/core.c | 8 +-
drivers/nvme/host/fabrics.c | 13 +-
drivers/nvme/host/nvme.h | 3 +-
drivers/nvme/host/pci.c | 4 +-
drivers/nvme/host/rdma.c | 68 +++--
drivers/nvme/host/tcp.c | 80 +++--
drivers/nvme/target/tcp.c | 10 +-
drivers/phy/qualcomm/phy-qcom-qmp.c | 16 +-
drivers/phy/qualcomm/phy-qcom-qmp.h | 2 +
drivers/regulator/core.c | 155 +++++-----
drivers/scsi/libsas/sas_ata.c | 5 +-
drivers/scsi/lpfc/lpfc_init.c | 1 -
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
drivers/scsi/qedf/qedf_main.c | 2 +-
drivers/scsi/qla2xxx/qla_def.h | 2 +-
drivers/scsi/qla2xxx/qla_init.c | 6 +-
drivers/soundwire/stream.c | 8 +-
drivers/spi/spi-stm32.c | 8 +-
drivers/staging/greybus/audio_topology.c | 29 +-
drivers/staging/wlan-ng/hfa384x_usb.c | 5 -
drivers/staging/wlan-ng/prism2usb.c | 19 +-
drivers/target/iscsi/iscsi_target.c | 17 +-
drivers/target/iscsi/iscsi_target_login.c | 6 +-
drivers/target/iscsi/iscsi_target_login.h | 3 +-
drivers/target/iscsi/iscsi_target_nego.c | 3 +-
drivers/thunderbolt/switch.c | 1 +
drivers/thunderbolt/tb.h | 2 +-
drivers/usb/core/message.c | 91 +++---
drivers/usb/core/sysfs.c | 5 +
drivers/usb/dwc3/dwc3-meson-g12a.c | 15 +-
drivers/usb/serial/ftdi_sio.c | 1 +
drivers/usb/serial/ftdi_sio_ids.h | 1 +
drivers/usb/serial/option.c | 22 +-
drivers/usb/typec/mux/intel_pmc_mux.c | 14 +-
drivers/usb/typec/ucsi/ucsi_acpi.c | 4 +
drivers/video/console/Kconfig | 46 ---
drivers/video/console/vgacon.c | 221 +-------------
drivers/video/fbdev/core/bitblit.c | 11 +-
drivers/video/fbdev/core/fbcon.c | 334 +--------------------
drivers/video/fbdev/core/fbcon.h | 2 +-
drivers/video/fbdev/core/fbcon_ccw.c | 11 +-
drivers/video/fbdev/core/fbcon_cw.c | 11 +-
drivers/video/fbdev/core/fbcon_ud.c | 11 +-
drivers/video/fbdev/core/tileblit.c | 2 +-
drivers/video/fbdev/vga16fb.c | 2 +-
fs/btrfs/disk-io.c | 2 +
fs/btrfs/extent-tree.c | 19 +-
fs/btrfs/ioctl.c | 3 +-
fs/btrfs/print-tree.c | 12 +-
fs/btrfs/transaction.c | 1 +
fs/btrfs/volumes.c | 10 +
fs/debugfs/file.c | 4 +-
fs/xfs/libxfs/xfs_attr_leaf.c | 4 +-
fs/xfs/libxfs/xfs_ialloc.c | 4 +-
fs/xfs/libxfs/xfs_trans_space.h | 2 +-
include/linux/efi_embedded_fw.h | 6 +-
include/linux/netfilter/nf_conntrack_sctp.h | 2 +
include/soc/nps/common.h | 6 +
kernel/gcov/Kconfig | 1 +
kernel/padata.c | 5 +-
kernel/seccomp.c | 13 +-
lib/kobject.c | 6 +-
lib/test_firmware.c | 9 +
net/mac80211/sta_info.h | 4 +-
net/mac80211/status.c | 31 +-
net/netfilter/nf_conntrack_proto_sctp.c | 39 ++-
net/netfilter/nft_set_rbtree.c | 34 ++-
net/wireless/chan.c | 15 +-
net/wireless/util.c | 8 +-
sound/hda/hdac_device.c | 2 +
sound/hda/intel-dsp-config.c | 10 +-
sound/pci/hda/hda_tegra.c | 7 +
sound/pci/hda/patch_hdmi.c | 6 +
sound/x86/Kconfig | 2 +-
tools/testing/selftests/timers/Makefile | 1 +
tools/testing/selftests/timers/settings | 1 +
virt/kvm/kvm_main.c | 21 +-
193 files changed, 1322 insertions(+), 1411 deletions(-)



2020-09-15 23:46:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 033/177] scsi: mpt3sas: Dont call disable_irq from IRQ poll handler

From: Tomas Henzl <[email protected]>

[ Upstream commit b614d55b970d08bcac5b0bc15a5526181b3e4459 ]

disable_irq() might sleep, replace it with disable_irq_nosync(). For
synchronisation 'irq_poll_scheduled' is sufficient

Fixes: 320e77acb3 scsi: mpt3sas: Irq poll to avoid CPU hard lockups
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Tomas Henzl <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 96b78fdc6b8a9..a85c9672c6ea3 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -1732,7 +1732,7 @@ _base_irqpoll(struct irq_poll *irqpoll, int budget)
reply_q = container_of(irqpoll, struct adapter_reply_queue,
irqpoll);
if (reply_q->irq_line_enable) {
- disable_irq(reply_q->os_irq);
+ disable_irq_nosync(reply_q->os_irq);
reply_q->irq_line_enable = false;
}
num_entries = _base_process_reply_queue(reply_q);
--
2.25.1



2020-09-15 23:46:49

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 036/177] interconnect: qcom: Fix small BW votes being truncated to zero

From: Mike Tipton <[email protected]>

[ Upstream commit 91e045b93db79a2ef66e045ad0d1f8f9d348e1f4 ]

Small BW votes that translate to less than a single BCM unit are
currently truncated to zero. Ensure that non-zero BW requests always
result in at least a vote of 1 to BCM.

Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support")
Signed-off-by: Mike Tipton <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Georgi Djakov <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/interconnect/qcom/bcm-voter.c | 27 +++++++++++++++++++--------
1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c
index 2a11a63e7217a..b360dc34c90c7 100644
--- a/drivers/interconnect/qcom/bcm-voter.c
+++ b/drivers/interconnect/qcom/bcm-voter.c
@@ -52,8 +52,20 @@ static int cmp_vcd(void *priv, struct list_head *a, struct list_head *b)
return 1;
}

+static u64 bcm_div(u64 num, u32 base)
+{
+ /* Ensure that small votes aren't lost. */
+ if (num && num < base)
+ return 1;
+
+ do_div(num, base);
+
+ return num;
+}
+
static void bcm_aggregate(struct qcom_icc_bcm *bcm)
{
+ struct qcom_icc_node *node;
size_t i, bucket;
u64 agg_avg[QCOM_ICC_NUM_BUCKETS] = {0};
u64 agg_peak[QCOM_ICC_NUM_BUCKETS] = {0};
@@ -61,22 +73,21 @@ static void bcm_aggregate(struct qcom_icc_bcm *bcm)

for (bucket = 0; bucket < QCOM_ICC_NUM_BUCKETS; bucket++) {
for (i = 0; i < bcm->num_nodes; i++) {
- temp = bcm->nodes[i]->sum_avg[bucket] * bcm->aux_data.width;
- do_div(temp, bcm->nodes[i]->buswidth * bcm->nodes[i]->channels);
+ node = bcm->nodes[i];
+ temp = bcm_div(node->sum_avg[bucket] * bcm->aux_data.width,
+ node->buswidth * node->channels);
agg_avg[bucket] = max(agg_avg[bucket], temp);

- temp = bcm->nodes[i]->max_peak[bucket] * bcm->aux_data.width;
- do_div(temp, bcm->nodes[i]->buswidth);
+ temp = bcm_div(node->max_peak[bucket] * bcm->aux_data.width,
+ node->buswidth);
agg_peak[bucket] = max(agg_peak[bucket], temp);
}

temp = agg_avg[bucket] * 1000ULL;
- do_div(temp, bcm->aux_data.unit);
- bcm->vote_x[bucket] = temp;
+ bcm->vote_x[bucket] = bcm_div(temp, bcm->aux_data.unit);

temp = agg_peak[bucket] * 1000ULL;
- do_div(temp, bcm->aux_data.unit);
- bcm->vote_y[bucket] = temp;
+ bcm->vote_y[bucket] = bcm_div(temp, bcm->aux_data.unit);
}

if (bcm->keepalive && bcm->vote_x[QCOM_ICC_BUCKET_AMC] == 0 &&
--
2.25.1



2020-09-15 23:47:13

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 039/177] drm/sun4i: backend: Support alpha property on lowest plane

From: Maxime Ripard <[email protected]>

[ Upstream commit e359c70462d2a82aae80274d027351d38792dde6 ]

Unlike what we previously thought, only the per-pixel alpha is broken on
the lowest plane and the per-plane alpha isn't. Remove the check on the
alpha property being set on the lowest plane to reject a mode.

Fixes: dcf496a6a608 ("drm/sun4i: sun4i: Introduce a quirk for lowest plane alpha support")
Signed-off-by: Maxime Ripard <[email protected]>
Reviewed-by: Chen-Yu Tsai <[email protected]>
Cc: Paul Kocialkowski <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 072ea113e6be5..30672c4c634da 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -589,8 +589,7 @@ static int sun4i_backend_atomic_check(struct sunxi_engine *engine,

/* We can't have an alpha plane at the lowest position */
if (!backend->quirks->supports_lowest_plane_alpha &&
- (plane_states[0]->fb->format->has_alpha ||
- (plane_states[0]->alpha != DRM_BLEND_ALPHA_OPAQUE)))
+ (plane_states[0]->alpha != DRM_BLEND_ALPHA_OPAQUE))
return -EINVAL;

for (i = 1; i < num_planes; i++) {
--
2.25.1



2020-09-15 23:47:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 009/177] selftests/timers: Turn off timeout setting

From: Po-Hsu Lin <[email protected]>

[ Upstream commit 5c1e4f7e9e49b6925b1fb5c507d2c614f3edb292 ]

The following 4 tests in timers can take longer than the default 45
seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
Add 45 second timeout per test") to run:
* nsleep-lat - 2m7.350s
* set-timer-lat - 2m0.66s
* inconsistency-check - 1m45.074s
* raw_skew - 2m0.013s

Thus they will be marked as failed with the current 45s setting:
not ok 3 selftests: timers: nsleep-lat # TIMEOUT
not ok 4 selftests: timers: set-timer-lat # TIMEOUT
not ok 6 selftests: timers: inconsistency-check # TIMEOUT
not ok 7 selftests: timers: raw_skew # TIMEOUT

Disable the timeout setting for timers can make these tests finish
properly:
ok 3 selftests: timers: nsleep-lat
ok 4 selftests: timers: set-timer-lat
ok 6 selftests: timers: inconsistency-check
ok 7 selftests: timers: raw_skew

https://bugs.launchpad.net/bugs/1864626
Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
Signed-off-by: Po-Hsu Lin <[email protected]>
Acked-by: John Stultz <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
tools/testing/selftests/timers/Makefile | 1 +
tools/testing/selftests/timers/settings | 1 +
2 files changed, 2 insertions(+)
create mode 100644 tools/testing/selftests/timers/settings

diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
index 7656c7ce79d90..0e73a16874c4c 100644
--- a/tools/testing/selftests/timers/Makefile
+++ b/tools/testing/selftests/timers/Makefile
@@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \

TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)

+TEST_FILES := settings

include ../lib.mk

diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
new file mode 100644
index 0000000000000..e7b9417537fbc
--- /dev/null
+++ b/tools/testing/selftests/timers/settings
@@ -0,0 +1 @@
+timeout=0
--
2.25.1



2020-09-15 23:48:03

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 007/177] ARM: dts: socfpga: fix register entry for timer3 on Arria10

From: Dinh Nguyen <[email protected]>

[ Upstream commit 0ff5a4812be4ebd4782bbb555d369636eea164f7 ]

Fixes the register address for the timer3 entry on Arria10.

Fixes: 475dc86d08de4 ("arm: dts: socfpga: Add a base DTSI for Altera's Arria10 SOC")
Signed-off-by: Dinh Nguyen <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/socfpga_arria10.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
index 8f614c4b0e3eb..9c71472c237bd 100644
--- a/arch/arm/boot/dts/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
@@ -819,7 +819,7 @@
timer3: timer3@ffd00100 {
compatible = "snps,dw-apb-timer";
interrupts = <0 118 IRQ_TYPE_LEVEL_HIGH>;
- reg = <0xffd01000 0x100>;
+ reg = <0xffd00100 0x100>;
clocks = <&l4_sys_free_clk>;
clock-names = "timer";
resets = <&rst L4SYSTIMER1_RESET>;
--
2.25.1



2020-09-15 23:48:43

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 031/177] RDMA/core: Fix reported speed and width

From: Kamal Heib <[email protected]>

[ Upstream commit 28b0865714b315e318ac45c4fc9156f3d4649646 ]

When the returned speed from __ethtool_get_link_ksettings() is
SPEED_UNKNOWN this will lead to reporting a wrong speed and width for
providers that uses ib_get_eth_speed(), fix that by defaulting the
netdev_speed to SPEED_1000 in case the returned value from
__ethtool_get_link_ksettings() is SPEED_UNKNOWN.

Fixes: d41861942fc5 ("IB/core: Add generic function to extract IB speed from netdev")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Kamal Heib <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/core/verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index f369f0a19e851..1b0ea945756f0 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1803,7 +1803,7 @@ int ib_get_eth_speed(struct ib_device *dev, u8 port_num, u8 *speed, u8 *width)

dev_put(netdev);

- if (!rc) {
+ if (!rc && lksettings.base.speed != (u32)SPEED_UNKNOWN) {
netdev_speed = lksettings.base.speed;
} else {
netdev_speed = SPEED_1000;
--
2.25.1



2020-09-15 23:50:24

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 006/177] regulator: remove superfluous lock in regulator_resolve_coupling()

From: Michał Mirosław <[email protected]>

[ Upstream commit a577f3456c0a2fac3dee037c483753e6e68f3e49 ]

The code modifies rdev, but locks c_rdev instead. Remove the lock
as this is held together by regulator_list_mutex taken in the caller.

Fixes: f9503385b187 ("regulator: core: Mutually resolve regulators coupling")
Signed-off-by: Michał Mirosław <[email protected]>
Reviewed-by: Dmitry Osipenko <[email protected]>
Link: https://lore.kernel.org/r/25eb81cefb37a646f3e44eaaf1d8ae8881cfde52.1597195321.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/regulator/core.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 86107d2e1733e..0ba5ca7082afd 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4891,13 +4891,9 @@ static void regulator_resolve_coupling(struct regulator_dev *rdev)
return;
}

- regulator_lock(c_rdev);
-
c_desc->coupled_rdevs[i] = c_rdev;
c_desc->n_resolved++;

- regulator_unlock(c_rdev);
-
regulator_resolve_coupling(c_rdev);
}
}
--
2.25.1



2020-09-15 23:50:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 019/177] RDMA/bnxt_re: Fix the qp table indexing

From: Selvin Xavier <[email protected]>

[ Upstream commit 84cf229f4001c1216afc3e4c7f05e1620a0dd4bc ]

qp->id can be a value outside the max number of qp. Indexing the qp table
with the id can cause out of bounds crash. So changing the qp table
indexing by (qp->id % max_qp -1).

Allocating one extra entry for QP1. Some adapters create one more than the
max_qp requested to accommodate QP1. If the qp->id is 1, store the
inforamtion in the last entry of the qp table.

Fixes: f218d67ef004 ("RDMA/bnxt_re: Allow posting when QPs are in error")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Selvin Xavier <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 22 ++++++++++++++--------
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 10 ++++++----
drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 5 +++++
3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index c5e29577cd434..b217208f6bcce 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -796,6 +796,7 @@ int bnxt_qplib_create_qp1(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
u16 cmd_flags = 0;
u32 qp_flags = 0;
u8 pg_sz_lvl;
+ u32 tbl_indx;
int rc;

RCFW_CMD_PREP(req, CREATE_QP1, cmd_flags);
@@ -891,8 +892,9 @@ int bnxt_qplib_create_qp1(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
rq->dbinfo.xid = qp->id;
rq->dbinfo.db = qp->dpi->dbr;
}
- rcfw->qp_tbl[qp->id].qp_id = qp->id;
- rcfw->qp_tbl[qp->id].qp_handle = (void *)qp;
+ tbl_indx = map_qp_id_to_tbl_indx(qp->id, rcfw);
+ rcfw->qp_tbl[tbl_indx].qp_id = qp->id;
+ rcfw->qp_tbl[tbl_indx].qp_handle = (void *)qp;

return 0;

@@ -950,6 +952,7 @@ int bnxt_qplib_create_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
u32 qp_flags = 0;
u8 pg_sz_lvl;
u16 max_rsge;
+ u32 tbl_indx;

RCFW_CMD_PREP(req, CREATE_QP, cmd_flags);

@@ -1118,8 +1121,9 @@ int bnxt_qplib_create_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
rq->dbinfo.xid = qp->id;
rq->dbinfo.db = qp->dpi->dbr;
}
- rcfw->qp_tbl[qp->id].qp_id = qp->id;
- rcfw->qp_tbl[qp->id].qp_handle = (void *)qp;
+ tbl_indx = map_qp_id_to_tbl_indx(qp->id, rcfw);
+ rcfw->qp_tbl[tbl_indx].qp_id = qp->id;
+ rcfw->qp_tbl[tbl_indx].qp_handle = (void *)qp;

return 0;

@@ -1467,10 +1471,12 @@ int bnxt_qplib_destroy_qp(struct bnxt_qplib_res *res,
struct cmdq_destroy_qp req;
struct creq_destroy_qp_resp resp;
u16 cmd_flags = 0;
+ u32 tbl_indx;
int rc;

- rcfw->qp_tbl[qp->id].qp_id = BNXT_QPLIB_QP_ID_INVALID;
- rcfw->qp_tbl[qp->id].qp_handle = NULL;
+ tbl_indx = map_qp_id_to_tbl_indx(qp->id, rcfw);
+ rcfw->qp_tbl[tbl_indx].qp_id = BNXT_QPLIB_QP_ID_INVALID;
+ rcfw->qp_tbl[tbl_indx].qp_handle = NULL;

RCFW_CMD_PREP(req, DESTROY_QP, cmd_flags);

@@ -1478,8 +1484,8 @@ int bnxt_qplib_destroy_qp(struct bnxt_qplib_res *res,
rc = bnxt_qplib_rcfw_send_message(rcfw, (void *)&req,
(void *)&resp, NULL, 0);
if (rc) {
- rcfw->qp_tbl[qp->id].qp_id = qp->id;
- rcfw->qp_tbl[qp->id].qp_handle = qp;
+ rcfw->qp_tbl[tbl_indx].qp_id = qp->id;
+ rcfw->qp_tbl[tbl_indx].qp_handle = qp;
return rc;
}

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
index 4e211162acee2..f7736e34ac64c 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
@@ -307,14 +307,15 @@ static int bnxt_qplib_process_qp_event(struct bnxt_qplib_rcfw *rcfw,
__le16 mcookie;
u16 cookie;
int rc = 0;
- u32 qp_id;
+ u32 qp_id, tbl_indx;

pdev = rcfw->pdev;
switch (qp_event->event) {
case CREQ_QP_EVENT_EVENT_QP_ERROR_NOTIFICATION:
err_event = (struct creq_qp_error_notification *)qp_event;
qp_id = le32_to_cpu(err_event->xid);
- qp = rcfw->qp_tbl[qp_id].qp_handle;
+ tbl_indx = map_qp_id_to_tbl_indx(qp_id, rcfw);
+ qp = rcfw->qp_tbl[tbl_indx].qp_handle;
dev_dbg(&pdev->dev, "Received QP error notification\n");
dev_dbg(&pdev->dev,
"qpid 0x%x, req_err=0x%x, resp_err=0x%x\n",
@@ -615,8 +616,9 @@ int bnxt_qplib_alloc_rcfw_channel(struct bnxt_qplib_res *res,

cmdq->bmap_size = bmap_size;

- rcfw->qp_tbl_size = qp_tbl_sz;
- rcfw->qp_tbl = kcalloc(qp_tbl_sz, sizeof(struct bnxt_qplib_qp_node),
+ /* Allocate one extra to hold the QP1 entries */
+ rcfw->qp_tbl_size = qp_tbl_sz + 1;
+ rcfw->qp_tbl = kcalloc(rcfw->qp_tbl_size, sizeof(struct bnxt_qplib_qp_node),
GFP_KERNEL);
if (!rcfw->qp_tbl)
goto fail;
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.h b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.h
index 157387636d004..5f2f0a5a3560f 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.h
+++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.h
@@ -216,4 +216,9 @@ int bnxt_qplib_deinit_rcfw(struct bnxt_qplib_rcfw *rcfw);
int bnxt_qplib_init_rcfw(struct bnxt_qplib_rcfw *rcfw,
struct bnxt_qplib_ctx *ctx, int is_virtfn);
void bnxt_qplib_mark_qp_error(void *qp_handle);
+static inline u32 map_qp_id_to_tbl_indx(u32 qid, struct bnxt_qplib_rcfw *rcfw)
+{
+ /* Last index of the qp_tbl is for QP1 ie. qp_tbl_size - 1*/
+ return (qid == 1) ? rcfw->qp_tbl_size - 1 : qid % rcfw->qp_tbl_size - 2;
+}
#endif /* __BNXT_QPLIB_RCFW_H__ */
--
2.25.1



2020-09-15 23:50:43

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 012/177] arm64: dts: imx: Add missing imx8mm-beacon-kit.dtb to build

From: Rob Herring <[email protected]>

[ Upstream commit 56e79dfd036b538940227fb31371c1cd67b2467f ]

The imx8mm-beacon-kit.dtb was never added to dtbs-y and wasn't getting
built. Fix it.

Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Cc: Shawn Guo <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index a39f0a1723e02..903c0eb61290d 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -28,6 +28,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb

+dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
--
2.25.1



2020-09-15 23:50:58

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 032/177] scsi: megaraid_sas: Dont call disable_irq from process IRQ poll

From: Tomas Henzl <[email protected]>

[ Upstream commit d2af39141eea34ef651961e885f49d96781a1016 ]

disable_irq() might sleep. Replace it with disable_irq_nosync() which is
sufficient as irq_poll_scheduled protects against concurrently running
complete_cmd_fusion() from megasas_irqpoll() and megasas_isr_fusion().

Link: https://lore.kernel.org/r/[email protected]
Fixes: a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ poll
Signed-off-by: Tomas Henzl <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index fcf03f733e417..1a0e2e4342ad8 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3690,7 +3690,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget)
instance = irq_ctx->instance;

if (irq_ctx->irq_line_enable) {
- disable_irq(irq_ctx->os_irq);
+ disable_irq_nosync(irq_ctx->os_irq);
irq_ctx->irq_line_enable = false;
}

--
2.25.1



2020-09-15 23:51:14

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 013/177] ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

From: Chris Healy <[email protected]>

[ Upstream commit 5cbb80d5236b47b149da292b86d5fc99a680894b ]

Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.

The end result is that network receive behaviour is marginal with lots of
RX CRC errors experienced and NFS frequently failing.

Quoting the explanation from Andrew Lunn in commit 0672d22a19244
("ARM: dts: imx: Fix the AR803X phy-mode"):

"The problem here is, all the DTs were broken since day 0. However,
because the PHY driver was also broken, nobody noticed and it
worked. Now that the PHY driver has been fixed, all the bugs in the
DTs now become an issue"

Fix it by switching to phy-mode = "rgmii-id".

Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Chris Healy <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7d-zii-rmu2.dts b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
index e5e20b07f184b..7cb6153fc650b 100644
--- a/arch/arm/boot/dts/imx7d-zii-rmu2.dts
+++ b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
@@ -58,7 +58,7 @@
<&clks IMX7D_ENET1_TIME_ROOT_CLK>;
assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
assigned-clock-rates = <0>, <100000000>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-handle = <&fec1_phy>;
status = "okay";

--
2.25.1



2020-09-15 23:51:21

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 008/177] ARM: dts: omap5: Fix DSI base address and clocks

From: David Shah <[email protected]>

[ Upstream commit 6542e2b613c2b1952e83973dc434831332ce8e27 ]

DSI was not probing due to base address off by 0x1000, and sys_clk
missing.

With this patch, the Pyra display works if HDMI is disabled in the
device tree.

Fixes: 5a507162f096 ("ARM: dts: Configure interconnect target module for omap5 dsi1")
Signed-off-by: David Shah <[email protected]>
Tested-by: H. Nikolaus Schaller <[email protected]>
[[email protected]: standardized subject line, added fixes tag]
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/omap5.dtsi | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index fb889c5b00c9d..de55ac5e60f39 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -463,11 +463,11 @@
};
};

- target-module@5000 {
+ target-module@4000 {
compatible = "ti,sysc-omap2", "ti,sysc";
- reg = <0x5000 0x4>,
- <0x5010 0x4>,
- <0x5014 0x4>;
+ reg = <0x4000 0x4>,
+ <0x4010 0x4>,
+ <0x4014 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
@@ -479,7 +479,7 @@
ti,syss-mask = <1>;
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0 0x5000 0x1000>;
+ ranges = <0 0x4000 0x1000>;

dsi1: encoder@0 {
compatible = "ti,omap5-dsi";
@@ -489,8 +489,9 @@
reg-names = "proto", "phy", "pll";
interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
- clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
- clock-names = "fck";
+ clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
+ <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
+ clock-names = "fck", "sys_clk";
};
};

@@ -520,8 +521,9 @@
reg-names = "proto", "phy", "pll";
interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
- clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
- clock-names = "fck";
+ clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
+ <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
+ clock-names = "fck", "sys_clk";
};
};

--
2.25.1



2020-09-15 23:51:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 017/177] RDMA/rxe: Fix panic when calling kmem_cache_create()

From: Kamal Heib <[email protected]>

[ Upstream commit d862060a4b43479887ae8e2c0b74a58c4e27e5f3 ]

To avoid the following kernel panic when calling kmem_cache_create() with
a NULL pointer from pool_cache(), Block the rxe_param_set_add() from
running if the rdma_rxe module is not initialized.

BUG: unable to handle kernel NULL pointer dereference at 000000000000000b
PGD 0 P4D 0
Oops: 0000 [#1] SMP NOPTI
CPU: 4 PID: 8512 Comm: modprobe Kdump: loaded Not tainted 4.18.0-231.el8.x86_64 #1
Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 10/02/2018
RIP: 0010:kmem_cache_alloc+0xd1/0x1b0
Code: 8b 57 18 45 8b 77 1c 48 8b 5c 24 30 0f 1f 44 00 00 5b 48 89 e8 5d 41 5c 41 5d 41 5e 41 5f c3 81 e3 00 00 10 00 75 0e 4d 89 fe <41> f6 47 0b 04 0f 84 6c ff ff ff 4c 89 ff e8 cc da 01 00 49 89 c6
RSP: 0018:ffffa2b8c773f9d0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000005
RDX: 0000000000000004 RSI: 00000000006080c0 RDI: 0000000000000000
RBP: ffff8ea0a8634fd0 R08: ffffa2b8c773f988 R09: 00000000006000c0
R10: 0000000000000000 R11: 0000000000000230 R12: 00000000006080c0
R13: ffffffffc0a97fc8 R14: 0000000000000000 R15: 0000000000000000
FS: 00007f9138ed9740(0000) GS:ffff8ea4ae800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000000000b CR3: 000000046d59a000 CR4: 00000000003406e0
Call Trace:
rxe_alloc+0xc8/0x160 [rdma_rxe]
rxe_get_dma_mr+0x25/0xb0 [rdma_rxe]
__ib_alloc_pd+0xcb/0x160 [ib_core]
ib_mad_init_device+0x296/0x8b0 [ib_core]
add_client_context+0x11a/0x160 [ib_core]
enable_device_and_get+0xdc/0x1d0 [ib_core]
ib_register_device+0x572/0x6b0 [ib_core]
? crypto_create_tfm+0x32/0xe0
? crypto_create_tfm+0x7a/0xe0
? crypto_alloc_tfm+0x58/0xf0
rxe_register_device+0x19d/0x1c0 [rdma_rxe]
rxe_net_add+0x3d/0x70 [rdma_rxe]
? dev_get_by_name_rcu+0x73/0x90
rxe_param_set_add+0xaf/0xc0 [rdma_rxe]
parse_args+0x179/0x370
? ref_module+0x1b0/0x1b0
load_module+0x135e/0x17e0
? ref_module+0x1b0/0x1b0
? __do_sys_init_module+0x13b/0x180
__do_sys_init_module+0x13b/0x180
do_syscall_64+0x5b/0x1a0
entry_SYSCALL_64_after_hwframe+0x65/0xca
RIP: 0033:0x7f9137ed296e

This can be triggered if a user tries to use the 'module option' which is
not actually a real module option but some idiotic (and thankfully no
obsolete) sysfs interface.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Kamal Heib <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/sw/rxe/rxe.c | 4 ++++
drivers/infiniband/sw/rxe/rxe.h | 2 ++
drivers/infiniband/sw/rxe/rxe_sysfs.c | 5 +++++
3 files changed, 11 insertions(+)

diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
index c7191b5e04a5a..d6b1236b114ab 100644
--- a/drivers/infiniband/sw/rxe/rxe.c
+++ b/drivers/infiniband/sw/rxe/rxe.c
@@ -48,6 +48,8 @@ static void rxe_cleanup_ports(struct rxe_dev *rxe)

}

+bool rxe_initialized;
+
/* free resources for a rxe device all objects created for this device must
* have been destroyed
*/
@@ -345,6 +347,7 @@ static int __init rxe_module_init(void)
return err;

rdma_link_register(&rxe_link_ops);
+ rxe_initialized = true;
pr_info("loaded\n");
return 0;
}
@@ -356,6 +359,7 @@ static void __exit rxe_module_exit(void)
rxe_net_exit();
rxe_cache_exit();

+ rxe_initialized = false;
pr_info("unloaded\n");
}

diff --git a/drivers/infiniband/sw/rxe/rxe.h b/drivers/infiniband/sw/rxe/rxe.h
index fb07eed9e4028..cae1b0a24c850 100644
--- a/drivers/infiniband/sw/rxe/rxe.h
+++ b/drivers/infiniband/sw/rxe/rxe.h
@@ -67,6 +67,8 @@

#define RXE_ROCE_V2_SPORT (0xc000)

+extern bool rxe_initialized;
+
static inline u32 rxe_crc32(struct rxe_dev *rxe,
u32 crc, void *next, size_t len)
{
diff --git a/drivers/infiniband/sw/rxe/rxe_sysfs.c b/drivers/infiniband/sw/rxe/rxe_sysfs.c
index ccda5f5a3bc0a..2af31d421bfc3 100644
--- a/drivers/infiniband/sw/rxe/rxe_sysfs.c
+++ b/drivers/infiniband/sw/rxe/rxe_sysfs.c
@@ -61,6 +61,11 @@ static int rxe_param_set_add(const char *val, const struct kernel_param *kp)
struct net_device *ndev;
struct rxe_dev *exists;

+ if (!rxe_initialized) {
+ pr_err("Module parameters are not supported, use rdma link add or rxe_cfg\n");
+ return -EAGAIN;
+ }
+
len = sanitize_arg(val, intf, sizeof(intf));
if (!len) {
pr_err("add: invalid interface name\n");
--
2.25.1



2020-09-15 23:51:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 016/177] RDMA/rxe: Drop pointless checks in rxe_init_ports

From: Kamal Heib <[email protected]>

[ Upstream commit 6112ef62826e91afbae5446d5d47b38e25f47e3f ]

Both pkey_tbl_len and gid_tbl_len are set in rxe_init_port_param() - so no
need to check if they aren't set.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Kamal Heib <[email protected]>
Reviewed-by: Leon Romanovsky <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/sw/rxe/rxe.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
index 5642eefb4ba1c..c7191b5e04a5a 100644
--- a/drivers/infiniband/sw/rxe/rxe.c
+++ b/drivers/infiniband/sw/rxe/rxe.c
@@ -147,9 +147,6 @@ static int rxe_init_ports(struct rxe_dev *rxe)

rxe_init_port_param(port);

- if (!port->attr.pkey_tbl_len || !port->attr.gid_tbl_len)
- return -EINVAL;
-
port->pkey_tbl = kcalloc(port->attr.pkey_tbl_len,
sizeof(*port->pkey_tbl), GFP_KERNEL);

--
2.25.1



2020-09-15 23:51:45

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 022/177] RDMA/bnxt_re: Remove the qp from list only if the qp destroy succeeds

From: Selvin Xavier <[email protected]>

[ Upstream commit 097a9d23b7250355b182c5fd47dd4c55b22b1c33 ]

Driver crashes when destroy_qp is re-tried because of an error
returned. This is because the qp entry was removed from the qp list during
the first call.

Remove qp from the list only if destroy_qp returns success.

The driver will still trigger a WARN_ON due to the memory leaking, but at
least it isn't corrupting memory too.

Fixes: 8dae419f9ec7 ("RDMA/bnxt_re: Refactor queue pair creation code")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Selvin Xavier <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index dad38aa06403d..cb6e873039df5 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -752,12 +752,6 @@ static int bnxt_re_destroy_gsi_sqp(struct bnxt_re_qp *qp)
gsi_sqp = rdev->gsi_ctx.gsi_sqp;
gsi_sah = rdev->gsi_ctx.gsi_sah;

- /* remove from active qp list */
- mutex_lock(&rdev->qp_lock);
- list_del(&gsi_sqp->list);
- mutex_unlock(&rdev->qp_lock);
- atomic_dec(&rdev->qp_count);
-
ibdev_dbg(&rdev->ibdev, "Destroy the shadow AH\n");
bnxt_qplib_destroy_ah(&rdev->qplib_res,
&gsi_sah->qplib_ah,
@@ -772,6 +766,12 @@ static int bnxt_re_destroy_gsi_sqp(struct bnxt_re_qp *qp)
}
bnxt_qplib_free_qp_res(&rdev->qplib_res, &gsi_sqp->qplib_qp);

+ /* remove from active qp list */
+ mutex_lock(&rdev->qp_lock);
+ list_del(&gsi_sqp->list);
+ mutex_unlock(&rdev->qp_lock);
+ atomic_dec(&rdev->qp_count);
+
kfree(rdev->gsi_ctx.sqp_tbl);
kfree(gsi_sah);
kfree(gsi_sqp);
@@ -792,11 +792,6 @@ int bnxt_re_destroy_qp(struct ib_qp *ib_qp, struct ib_udata *udata)
unsigned int flags;
int rc;

- mutex_lock(&rdev->qp_lock);
- list_del(&qp->list);
- mutex_unlock(&rdev->qp_lock);
- atomic_dec(&rdev->qp_count);
-
bnxt_qplib_flush_cqn_wq(&qp->qplib_qp);

rc = bnxt_qplib_destroy_qp(&rdev->qplib_res, &qp->qplib_qp);
@@ -819,6 +814,11 @@ int bnxt_re_destroy_qp(struct ib_qp *ib_qp, struct ib_udata *udata)
goto sh_fail;
}

+ mutex_lock(&rdev->qp_lock);
+ list_del(&qp->list);
+ mutex_unlock(&rdev->qp_lock);
+ atomic_dec(&rdev->qp_count);
+
ib_umem_release(qp->rumem);
ib_umem_release(qp->sumem);

--
2.25.1



2020-09-15 23:51:54

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 005/177] regulator: push allocation in regulator_ena_gpio_request() out of lock

From: Michał Mirosław <[email protected]>

[ Upstream commit 467bf30142c64f2eb64e2ac67fa4595126230efd ]

Move another allocation out of regulator_list_mutex-protected region, as
reclaim might want to take the same lock.

WARNING: possible circular locking dependency detected
5.7.13+ #534 Not tainted
------------------------------------------------------
kswapd0/383 is trying to acquire lock:
c0e5d920 (regulator_list_mutex){+.+.}-{3:3}, at: regulator_lock_dependent+0x54/0x2c0

but task is already holding lock:
c0e38518 (fs_reclaim){+.+.}-{0:0}, at: __fs_reclaim_acquire+0x0/0x50

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 (fs_reclaim){+.+.}-{0:0}:
fs_reclaim_acquire.part.11+0x40/0x50
fs_reclaim_acquire+0x24/0x28
kmem_cache_alloc_trace+0x40/0x1e8
regulator_register+0x384/0x1630
devm_regulator_register+0x50/0x84
reg_fixed_voltage_probe+0x248/0x35c
[...]
other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(fs_reclaim);
lock(regulator_list_mutex);
lock(fs_reclaim);
lock(regulator_list_mutex);

*** DEADLOCK ***
[...]
2 locks held by kswapd0/383:
#0: c0e38518 (fs_reclaim){+.+.}-{0:0}, at: __fs_reclaim_acquire+0x0/0x50
#1: cb70e5e0 (hctx->srcu){....}-{0:0}, at: hctx_lock+0x60/0xb8
[...]

Fixes: 541d052d7215 ("regulator: core: Only support passing enable GPIO descriptors")
[this commit only changes context]
Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
[this is when the regulator_list_mutex was introduced in reclaim locking path]

Signed-off-by: Michał Mirosław <[email protected]>
Link: https://lore.kernel.org/r/41fe6a9670335721b48e8f5195038c3d67a3bf92.1597195321.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/regulator/core.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 720f28844795b..86107d2e1733e 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2222,10 +2222,13 @@ EXPORT_SYMBOL_GPL(regulator_bulk_unregister_supply_alias);
static int regulator_ena_gpio_request(struct regulator_dev *rdev,
const struct regulator_config *config)
{
- struct regulator_enable_gpio *pin;
+ struct regulator_enable_gpio *pin, *new_pin;
struct gpio_desc *gpiod;

gpiod = config->ena_gpiod;
+ new_pin = kzalloc(sizeof(*new_pin), GFP_KERNEL);
+
+ mutex_lock(&regulator_list_mutex);

list_for_each_entry(pin, &regulator_ena_gpio_list, list) {
if (pin->gpiod == gpiod) {
@@ -2234,9 +2237,13 @@ static int regulator_ena_gpio_request(struct regulator_dev *rdev,
}
}

- pin = kzalloc(sizeof(struct regulator_enable_gpio), GFP_KERNEL);
- if (pin == NULL)
+ if (new_pin == NULL) {
+ mutex_unlock(&regulator_list_mutex);
return -ENOMEM;
+ }
+
+ pin = new_pin;
+ new_pin = NULL;

pin->gpiod = gpiod;
list_add(&pin->list, &regulator_ena_gpio_list);
@@ -2244,6 +2251,10 @@ static int regulator_ena_gpio_request(struct regulator_dev *rdev,
update_ena_gpio_to_rdev:
pin->request_count++;
rdev->ena_pin = pin;
+
+ mutex_unlock(&regulator_list_mutex);
+ kfree(new_pin);
+
return 0;
}

@@ -5137,9 +5148,7 @@ regulator_register(const struct regulator_desc *regulator_desc,
}

if (config->ena_gpiod) {
- mutex_lock(&regulator_list_mutex);
ret = regulator_ena_gpio_request(rdev, config);
- mutex_unlock(&regulator_list_mutex);
if (ret != 0) {
rdev_err(rdev, "Failed to request enable GPIO: %d\n",
ret);
--
2.25.1



2020-09-15 23:52:06

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 014/177] RDMA/rtrs-srv: Replace device_register with device_initialize and device_add

From: Md Haris Iqbal <[email protected]>

[ Upstream commit baa5b28b7a474f66a511ebf71a2ade510652a2f6 ]

There are error cases when we will call free_srv before device kobject is
initialized; in such cases calling put_device generates the following
warning:

kobject: '(null)' (000000009f5445ed): is not initialized, yet
kobject_put() is being called.

So call device_initialize() only once when the server is allocated. If we
end up calling put_srv() and subsequently free_srv(), our call to
put_device() would result in deletion of the obj. Call device_add() later
when we actually have a connection. Correspondingly, call device_del()
instead of device_unregister() when srv->dev_ref falls to 0.

Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality")
Link: https://lore.kernel.org/r/[email protected]
Suggested-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Md Haris Iqbal <[email protected]>
Reviewed-by: Jack Wang <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 ++++----
drivers/infiniband/ulp/rtrs/rtrs-srv.c | 1 +
2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
index 3d7877534bcc9..2f981ae970767 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
@@ -182,16 +182,16 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
* sysfs files are created
*/
dev_set_uevent_suppress(&srv->dev, true);
- err = device_register(&srv->dev);
+ err = device_add(&srv->dev);
if (err) {
- pr_err("device_register(): %d\n", err);
+ pr_err("device_add(): %d\n", err);
goto put;
}
srv->kobj_paths = kobject_create_and_add("paths", &srv->dev.kobj);
if (!srv->kobj_paths) {
err = -ENOMEM;
pr_err("kobject_create_and_add(): %d\n", err);
- device_unregister(&srv->dev);
+ device_del(&srv->dev);
goto unlock;
}
dev_set_uevent_suppress(&srv->dev, false);
@@ -216,7 +216,7 @@ rtrs_srv_destroy_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
kobject_del(srv->kobj_paths);
kobject_put(srv->kobj_paths);
mutex_unlock(&srv->paths_mutex);
- device_unregister(&srv->dev);
+ device_del(&srv->dev);
} else {
mutex_unlock(&srv->paths_mutex);
}
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
index a219bd1bdbc26..b61a18e57aeba 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
@@ -1336,6 +1336,7 @@ static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
uuid_copy(&srv->paths_uuid, paths_uuid);
srv->queue_depth = sess_queue_depth;
srv->ctx = ctx;
+ device_initialize(&srv->dev);

srv->chunks = kcalloc(srv->queue_depth, sizeof(*srv->chunks),
GFP_KERNEL);
--
2.25.1



2020-09-15 23:52:12

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 018/177] RDMA/bnxt_re: Do not report transparent vlan from QP1

From: Selvin Xavier <[email protected]>

[ Upstream commit 2d0e60ee322d512fa6bc62d23a6760b39a380847 ]

QP1 Rx CQE reports transparent VLAN ID in the completion and this is used
while reporting the completion for received MAD packet. Check if the vlan
id is configured before reporting it in the work completion.

Fixes: 84511455ac5b ("RDMA/bnxt_re: report vlan_id and sl in qp1 recv completion")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Selvin Xavier <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index 8b6ad5cddfce9..dad38aa06403d 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -3178,6 +3178,19 @@ static void bnxt_re_process_res_rawqp1_wc(struct ib_wc *wc,
wc->wc_flags |= IB_WC_GRH;
}

+static bool bnxt_re_check_if_vlan_valid(struct bnxt_re_dev *rdev,
+ u16 vlan_id)
+{
+ /*
+ * Check if the vlan is configured in the host. If not configured, it
+ * can be a transparent VLAN. So dont report the vlan id.
+ */
+ if (!__vlan_find_dev_deep_rcu(rdev->netdev,
+ htons(ETH_P_8021Q), vlan_id))
+ return false;
+ return true;
+}
+
static bool bnxt_re_is_vlan_pkt(struct bnxt_qplib_cqe *orig_cqe,
u16 *vid, u8 *sl)
{
@@ -3246,9 +3259,11 @@ static void bnxt_re_process_res_shadow_qp_wc(struct bnxt_re_qp *gsi_sqp,
wc->src_qp = orig_cqe->src_qp;
memcpy(wc->smac, orig_cqe->smac, ETH_ALEN);
if (bnxt_re_is_vlan_pkt(orig_cqe, &vlan_id, &sl)) {
- wc->vlan_id = vlan_id;
- wc->sl = sl;
- wc->wc_flags |= IB_WC_WITH_VLAN;
+ if (bnxt_re_check_if_vlan_valid(rdev, vlan_id)) {
+ wc->vlan_id = vlan_id;
+ wc->sl = sl;
+ wc->wc_flags |= IB_WC_WITH_VLAN;
+ }
}
wc->port_num = 1;
wc->vendor_err = orig_cqe->status;
--
2.25.1



2020-09-15 23:52:41

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 001/177] ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()

From: Jing Xiangfeng <[email protected]>

[ Upstream commit a58cfdba2039ff2d5758840e97a23a2dedecf1e8 ]

The of_clk_get() function returns error pointers, it never returns NULL.

Fixes: 4ea3711aece4 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc")
Signed-off-by: Jing Xiangfeng <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/mach-omap2/omap-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c
index 54aff33e55e6e..bfa5e1b8dba7f 100644
--- a/arch/arm/mach-omap2/omap-iommu.c
+++ b/arch/arm/mach-omap2/omap-iommu.c
@@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev)
return pwrdm;

clk = of_clk_get(dev->of_node->parent, 0);
- if (!clk) {
+ if (IS_ERR(clk)) {
dev_err(dev, "no fck found\n");
return NULL;
}
--
2.25.1



2020-09-15 23:52:41

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 003/177] ARM: dts: logicpd-som-lv-baseboard: Fix broken audio

From: Adam Ford <[email protected]>

[ Upstream commit 4d26e9a028e3d88223e06fa133c3d55af7ddbceb ]

Older versions of U-Boot would pinmux the whole board, but as
the bootloader got updated, it started to only pinmux the pins
it needed, and expected Linux to configure what it needed.

Unfortunately this caused an issue with the audio, because the
mcbsp2 pins were configured in the device tree but never
referenced by the driver. When U-Boot stopped muxing the audio
pins, the audio died.

This patch adds the references to the associate the pin controller
with the mcbsp2 driver which makes audio operate again.

Fixes: 5cb8b0fa55a9 ("ARM: dts: Move most of logicpd-som-lv-37xx-devkit.dts to logicpd-som-lv-baseboard.dtsi")

Signed-off-by: Adam Ford <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
index 100396f6c2feb..c310c33ca6f3f 100644
--- a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
@@ -51,6 +51,8 @@

&mcbsp2 {
status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mcbsp2_pins>;
};

&charger {
--
2.25.1



2020-09-15 23:52:51

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 002/177] ARM: dts: logicpd-torpedo-baseboard: Fix broken audio

From: Adam Ford <[email protected]>

[ Upstream commit d7dfee67688ac7f2dfd4c3bc70c053ee990c40b5 ]

Older versions of U-Boot would pinmux the whole board, but as
the bootloader got updated, it started to only pinmux the pins
it needed, and expected Linux to configure what it needed.

Unfortunately this caused an issue with the audio, because the
mcbsp2 pins were configured in the device tree, they were never
referenced by the driver. When U-Boot stopped muxing the audio
pins, the audio died.

This patch adds the references to the associate the pin controller
with the mcbsp2 driver which makes audio operate again.

Fixes: 739f85bba5ab ("ARM: dts: Move most of logicpd-torpedo-37xx-devkit to logicpd-torpedo-baseboard")

Signed-off-by: Adam Ford <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi
index 381f0e82bb706..b0f6613e6d549 100644
--- a/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi
+++ b/arch/arm/boot/dts/logicpd-torpedo-baseboard.dtsi
@@ -81,6 +81,8 @@
};

&mcbsp2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&mcbsp2_pins>;
status = "okay";
};

--
2.25.1



2020-09-15 23:52:51

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 011/177] ARM: dts: imx7ulp: Correct gpio ranges

From: Anson Huang <[email protected]>

[ Upstream commit deb6323b739c54e1a1e83cd3a2bae4901e3eebf6 ]

Correct gpio ranges according to i.MX7ULP pinctrl driver:

gpio_ptc: ONLY pin 0~19 are available;
gpio_ptd: ONLY pin 0~11 are available;
gpio_pte: ONLY pin 0~15 are available;
gpio_ptf: ONLY pin 0~19 are available;

Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
Signed-off-by: Anson Huang <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/imx7ulp.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index f7c4878534c8e..1bff3efe8aafe 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -394,7 +394,7 @@
clocks = <&pcc2 IMX7ULP_CLK_RGPIO2P1>,
<&pcc3 IMX7ULP_CLK_PCTLC>;
clock-names = "gpio", "port";
- gpio-ranges = <&iomuxc1 0 0 32>;
+ gpio-ranges = <&iomuxc1 0 0 20>;
};

gpio_ptd: gpio@40af0000 {
@@ -408,7 +408,7 @@
clocks = <&pcc2 IMX7ULP_CLK_RGPIO2P1>,
<&pcc3 IMX7ULP_CLK_PCTLD>;
clock-names = "gpio", "port";
- gpio-ranges = <&iomuxc1 0 32 32>;
+ gpio-ranges = <&iomuxc1 0 32 12>;
};

gpio_pte: gpio@40b00000 {
@@ -422,7 +422,7 @@
clocks = <&pcc2 IMX7ULP_CLK_RGPIO2P1>,
<&pcc3 IMX7ULP_CLK_PCTLE>;
clock-names = "gpio", "port";
- gpio-ranges = <&iomuxc1 0 64 32>;
+ gpio-ranges = <&iomuxc1 0 64 16>;
};

gpio_ptf: gpio@40b10000 {
@@ -436,7 +436,7 @@
clocks = <&pcc2 IMX7ULP_CLK_RGPIO2P1>,
<&pcc3 IMX7ULP_CLK_PCTLF>;
clock-names = "gpio", "port";
- gpio-ranges = <&iomuxc1 0 96 32>;
+ gpio-ranges = <&iomuxc1 0 96 20>;
};
};

--
2.25.1



2020-09-15 23:53:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 010/177] ARM: dts: ls1021a: fix QuadSPI-memory reg range

From: Matthias Schiffer <[email protected]>

[ Upstream commit 81dbbb417da4d1ac407dca5b434d39d5b6b91ef3 ]

According to the Reference Manual, the correct size is 512 MiB.

Without this fix, probing the QSPI fails:

fsl-quadspi 1550000.spi: ioremap failed for resource
[mem 0x40000000-0x7fffffff]
fsl-quadspi 1550000.spi: Freescale QuadSPI probe failed
fsl-quadspi: probe of 1550000.spi failed with error -12

Fixes: 85f8ee78ab72 ("ARM: dts: ls1021a: Add support for QSPI with ls1021a SoC")
Signed-off-by: Matthias Schiffer <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index b2ff27af090ec..9435ce527e855 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -181,7 +181,7 @@
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x1550000 0x0 0x10000>,
- <0x0 0x40000000 0x0 0x40000000>;
+ <0x0 0x40000000 0x0 0x20000000>;
reg-names = "QuadSPI", "QuadSPI-memory";
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
--
2.25.1



2020-09-15 23:53:19

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 015/177] RDMA/rxe: Fix memleak in rxe_mem_init_user

From: Dinghao Liu <[email protected]>

[ Upstream commit e3ddd6067ee62f6e76ebcf61ff08b2c729ae412b ]

When page_address() fails, umem should be freed just like when
rxe_mem_alloc() fails.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dinghao Liu <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_mr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index e83c7b518bfa2..bfb96a0d071bb 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -207,6 +207,7 @@ int rxe_mem_init_user(struct rxe_pd *pd, u64 start,
vaddr = page_address(sg_page_iter_page(&sg_iter));
if (!vaddr) {
pr_warn("null vaddr\n");
+ ib_umem_release(umem);
err = -ENOMEM;
goto err1;
}
--
2.25.1



2020-09-15 23:53:32

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 004/177] ARM: dts: logicpd-som-lv-baseboard: Fix missing video

From: Adam Ford <[email protected]>

[ Upstream commit d1db7b80a6c8c5f81db0e80664d29b374750e2c6 ]

A previous commit removed the panel-dpi driver, which made the
SOM-LV video stop working because it relied on the DPI driver
for setting video timings. Now that the simple-panel driver is
available in omap2plus, this patch migrates the SOM-LV dev kits
to use a similar panel and remove the manual timing requirements.
A similar patch was already done and applied to the Torpedo family.

Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")

Signed-off-by: Adam Ford <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
.../boot/dts/logicpd-som-lv-baseboard.dtsi | 27 ++++---------------
1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
index c310c33ca6f3f..395e05f10d36c 100644
--- a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
@@ -104,35 +104,18 @@
regulator-max-microvolt = <3300000>;
};

- lcd0: display@0 {
- compatible = "panel-dpi";
- label = "28";
- status = "okay";
- /* default-on; */
+ lcd0: display {
+ /* This isn't the exact LCD, but the timings meet spec */
+ compatible = "logicpd,type28";
pinctrl-names = "default";
pinctrl-0 = <&lcd_enable_pin>;
- enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; /* gpio155, lcd INI */
+ backlight = <&bl>;
+ enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
port {
lcd_in: endpoint {
remote-endpoint = <&dpi_out>;
};
};
-
- panel-timing {
- clock-frequency = <9000000>;
- hactive = <480>;
- vactive = <272>;
- hfront-porch = <3>;
- hback-porch = <2>;
- hsync-len = <42>;
- vback-porch = <3>;
- vfront-porch = <2>;
- vsync-len = <11>;
- hsync-active = <1>;
- vsync-active = <1>;
- de-active = <1>;
- pixelclk-active = <0>;
- };
};

bl: backlight {
--
2.25.1



2020-09-15 23:54:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.8 020/177] RDMA/bnxt_re: Static NQ depth allocation

From: Naresh Kumar PBS <[email protected]>

[ Upstream commit f86b31c6a28f06eed3f6d9dc958079853b0792f1 ]

At first, driver allocates memory for NQ based on qplib_ctx->cq_count and
qplib_ctx->srqc_count. Later when creating ring, it uses a static value
of 128K -1.

Fixing this with a static value for now.

Fixes: b08fe048a69d ("RDMA/bnxt_re: Refactor net ring allocation function")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Naresh Kumar PBS <[email protected]>
Signed-off-by: Selvin Xavier <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/infiniband/hw/bnxt_re/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 5c41e13496a02..882c4f49d3a87 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1027,8 +1027,7 @@ static int bnxt_re_alloc_res(struct bnxt_re_dev *rdev)
struct bnxt_qplib_nq *nq;

nq = &rdev->nq[i];
- nq->hwq.max_elements = (qplib_ctx->cq_count +
- qplib_ctx->srqc_count + 2);
+ nq->hwq.max_elements = BNXT_QPLIB_NQE_MAX_CNT;
rc = bnxt_qplib_alloc_nq(&rdev->qplib_res, &rdev->nq[i]);
if (rc) {
ibdev_err(&rdev->ibdev, "Alloc Failed NQ%d rc:%#x",
--
2.25.1



2020-09-16 11:13:56

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Tue, 15 Sep 2020 at 19:55, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.8.10 release.
> There are 177 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.8.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <[email protected]>

Summary
------------------------------------------------------------------------

kernel: 5.8.10-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-5.8.y
git commit: 337aafeeb4cdb1868fff6b6689b715ff376249a2
git describe: v5.8.9-178-g337aafeeb4cd
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.8.y/build/v5.8.9-178-g337aafeeb4cd

No regressions (compared to build v5.8.9)


No fixes (compared to build v5.8.9)

Ran 37876 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c
- hi6220-hikey
- i386
- juno-r2
- juno-r2-compat
- juno-r2-kasan
- nxp-ls2088
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15
- x86
- x86-kasan

Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* kselftest/drivers
* kselftest/filesystems
* kselftest/net
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-tracing-tests
* perf
* v4l2-compliance
* ltp-ipc-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* network-basic-tests
* ltp-cve-tests
* ltp-open-posix-tests
* ltp-syscalls-tests
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-native/drivers
* kselftest-vsyscall-mode-native/filesystems
* kselftest-vsyscall-mode-native/net
* kselftest-vsyscall-mode-none
* kselftest-vsyscall-mode-none/drivers
* kselftest-vsyscall-mode-none/filesystems
* kselftest-vsyscall-mode-none/net
* ssuite

--
Linaro LKFT
https://lkft.linaro.org

2020-09-16 17:30:20

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
> On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
> > On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
> > > On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
> > > > On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
> > > > > On 9/15/20 3:06 PM, Shuah Khan wrote:
> > > > > > On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
> > > > > > > This is the start of the stable review cycle for the 5.8.10 release.
> > > > > > > There are 177 patches in this series, all will be posted as a response
> > > > > > > to this one.? If anyone has any issues with these being applied, please
> > > > > > > let me know.
> > > > > > >
> > > > > > > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> > > > > > > Anything received after that time might be too late.
> > > > > > >
> > > > > > > The whole patch series can be found in one patch at:
> > > > > > > ????https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
> > > > > > >
> > > > > > > or in the git tree and branch at:
> > > > > > > ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > > > > linux-5.8.y
> > > > > > > and the diffstat can be found below.
> > > > > > >
> > > > > > > thanks,
> > > > > > >
> > > > > > > greg k-h
> > > > > > >
> > > > > >
> > > > > > Compiled and booted fine. wifi died:
> > > > > >
> > > > > > ath10k_pci 0000:02:00.0: could not init core (-110)
> > > > > > ath10k_pci 0000:02:00.0: could not probe fw (-110)
> > > > > >
> > > > > > This is regression from 5.8.9 and 5.9-rc5 works just fine.
> > > > > >
> > > > > > I will try to bisect later this evening to see if I can isolate the
> > > > > > commit.
> > > > > >
> > > > >
> > > > > The following commit is what caused ath10k_pci driver problem
> > > > > that killed wifi.
> > > > >
> > > > > Prateek Sood <[email protected]>
> > > > > firmware_loader: fix memory leak for paged buffer
> > > > >
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271
> > > >
> > > > Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For
> > > > reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory
> > > > leak for paged buffer") in Linus's tree.
> > > >
> > >
> > > I am not seeing this on Linux 5.9-rc5 for sure.
> > >
> > > > And it should be showing up in 5.4.y at the moment too, as this patch is
> > > > in that tree right now...
> > > >
> > >
> > > I don't see this patch in 4.19.146-rc1
> >
> > It's not there, it's in 5.4.66-rc1, which worked for you somehow, right?
> >
> > > Linus's tree works for with this patch in. I compared the two files
> > > for differences in commit between Linus's tree and 5.8.10-rc1
> > >
> > > Couldn't find anything obvious.
> >
> > Again, really odd...
> >
> > I don't have a problem dropping it, but I should drop it from both 5.4.y
> > and 5.8.y, right?
> >
>
> Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out
> why this patch causes problems.
>
> I will continue debugging and let you know what I find.

Thanks, now dropped from both trees.

greg k-h

2020-09-16 20:41:04

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Tue, Sep 15, 2020 at 04:11:11PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.8.10 release.
> There are 177 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 154 pass: 154 fail: 0
Qemu test results:
total: 430 pass: 430 fail: 0

Tested-by: Guenter Roeck <[email protected]>

Guenter

2020-09-17 14:37:11

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Wed, Sep 16, 2020 at 04:02:57PM +0530, Naresh Kamboju wrote:
> On Tue, 15 Sep 2020 at 19:55, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.8.10 release.
> > There are 177 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.8.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Results from Linaro’s test farm.
> No regressions on arm64, arm, x86_64, and i386.
>
> Tested-by: Linux Kernel Functional Testing <[email protected]>

Thanks for testing all of these and letting me know.

greg k-h

2020-09-17 14:38:10

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Wed, Sep 16, 2020 at 10:06:37AM -0700, Guenter Roeck wrote:
> On Tue, Sep 15, 2020 at 04:11:11PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.8.10 release.
> > There are 177 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> > Anything received after that time might be too late.
> >
>
> Build results:
> total: 154 pass: 154 fail: 0
> Qemu test results:
> total: 430 pass: 430 fail: 0
>
> Tested-by: Guenter Roeck <[email protected]>

Thanks for testing them all and letting me know.

greg k-h

2020-09-17 14:41:42

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
>> On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
>>> On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
>>>> On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
>>>>> On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
>>>>>> On 9/15/20 3:06 PM, Shuah Khan wrote:
>>>>>>> On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
>>>>>>>> This is the start of the stable review cycle for the 5.8.10 release.
>>>>>>>> There are 177 patches in this series, all will be posted as a response
>>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>>> let me know.
>>>>>>>>
>>>>>>>> Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
>>>>>>>> Anything received after that time might be too late.
>>>>>>>>
>>>>>>>> The whole patch series can be found in one patch at:
>>>>>>>>     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
>>>>>>>>
>>>>>>>> or in the git tree and branch at:
>>>>>>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>>>>>>> linux-5.8.y
>>>>>>>> and the diffstat can be found below.
>>>>>>>>
>>>>>>>> thanks,
>>>>>>>>
>>>>>>>> greg k-h
>>>>>>>>
>>>>>>>
>>>>>>> Compiled and booted fine. wifi died:
>>>>>>>
>>>>>>> ath10k_pci 0000:02:00.0: could not init core (-110)
>>>>>>> ath10k_pci 0000:02:00.0: could not probe fw (-110)
>>>>>>>
>>>>>>> This is regression from 5.8.9 and 5.9-rc5 works just fine.
>>>>>>>
>>>>>>> I will try to bisect later this evening to see if I can isolate the
>>>>>>> commit.
>>>>>>>
>>>>>>
>>>>>> The following commit is what caused ath10k_pci driver problem
>>>>>> that killed wifi.
>>>>>>
>>>>>> Prateek Sood <[email protected]>
>>>>>> firmware_loader: fix memory leak for paged buffer
>>>>>>
>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271
>>>>>
>>>>> Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For
>>>>> reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory
>>>>> leak for paged buffer") in Linus's tree.
>>>>>
>>>>
>>>> I am not seeing this on Linux 5.9-rc5 for sure.
>>>>
>>>>> And it should be showing up in 5.4.y at the moment too, as this patch is
>>>>> in that tree right now...
>>>>>
>>>>
>>>> I don't see this patch in 4.19.146-rc1
>>>
>>> It's not there, it's in 5.4.66-rc1, which worked for you somehow, right?
>>>
>>>> Linus's tree works for with this patch in. I compared the two files
>>>> for differences in commit between Linus's tree and 5.8.10-rc1
>>>>
>>>> Couldn't find anything obvious.
>>>
>>> Again, really odd...
>>>
>>> I don't have a problem dropping it, but I should drop it from both 5.4.y
>>> and 5.8.y, right?
>>>
>>
>> Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out
>> why this patch causes problems.
>>
>> I will continue debugging and let you know what I find.
>

With this it boots and wifi is good for me. I am very puzzled by why
this made a difference to make sure I am not narrowing in on the wrong
patch.

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2020-09-17 17:15:09

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On 9/17/20 8:46 AM, Greg Kroah-Hartman wrote:
> On Thu, Sep 17, 2020 at 08:34:58AM -0600, Shuah Khan wrote:
>> On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
>>> On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
>>>> On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
>>>>> On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
>>>>>> On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
>>>>>>> On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
>>>>>>>> On 9/15/20 3:06 PM, Shuah Khan wrote:
>>>>>>>>> On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
>>>>>>>>>> This is the start of the stable review cycle for the 5.8.10 release.
>>>>>>>>>> There are 177 patches in this series, all will be posted as a response
>>>>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>>>>> let me know.
>>>>>>>>>>
>>>>>>>>>> Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
>>>>>>>>>> Anything received after that time might be too late.
>>>>>>>>>>
>>>>>>>>>> The whole patch series can be found in one patch at:
>>>>>>>>>>     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
>>>>>>>>>>
>>>>>>>>>> or in the git tree and branch at:
>>>>>>>>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>>>>>>>>> linux-5.8.y
>>>>>>>>>> and the diffstat can be found below.
>>>>>>>>>>
>>>>>>>>>> thanks,
>>>>>>>>>>
>>>>>>>>>> greg k-h
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Compiled and booted fine. wifi died:
>>>>>>>>>
>>>>>>>>> ath10k_pci 0000:02:00.0: could not init core (-110)
>>>>>>>>> ath10k_pci 0000:02:00.0: could not probe fw (-110)
>>>>>>>>>
>>>>>>>>> This is regression from 5.8.9 and 5.9-rc5 works just fine.
>>>>>>>>>
>>>>>>>>> I will try to bisect later this evening to see if I can isolate the
>>>>>>>>> commit.
>>>>>>>>>
>>>>>>>>
>>>>>>>> The following commit is what caused ath10k_pci driver problem
>>>>>>>> that killed wifi.
>>>>>>>>
>>>>>>>> Prateek Sood <[email protected]>
>>>>>>>> firmware_loader: fix memory leak for paged buffer
>>>>>>>>
>>>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271
>>>>>>>
>>>>>>> Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For
>>>>>>> reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory
>>>>>>> leak for paged buffer") in Linus's tree.
>>>>>>>
>>>>>>
>>>>>> I am not seeing this on Linux 5.9-rc5 for sure.
>>>>>>
>>>>>>> And it should be showing up in 5.4.y at the moment too, as this patch is
>>>>>>> in that tree right now...
>>>>>>>
>>>>>>
>>>>>> I don't see this patch in 4.19.146-rc1
>>>>>
>>>>> It's not there, it's in 5.4.66-rc1, which worked for you somehow, right?
>>>>>
>>>>>> Linus's tree works for with this patch in. I compared the two files
>>>>>> for differences in commit between Linus's tree and 5.8.10-rc1
>>>>>>
>>>>>> Couldn't find anything obvious.
>>>>>
>>>>> Again, really odd...
>>>>>
>>>>> I don't have a problem dropping it, but I should drop it from both 5.4.y
>>>>> and 5.8.y, right?
>>>>>
>>>>
>>>> Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out
>>>> why this patch causes problems.
>>>>
>>>> I will continue debugging and let you know what I find.
>>>
>>
>> With this it boots and wifi is good for me. I am very puzzled by why
>> this made a difference to make sure I am not narrowing in on the wrong
>> patch.
>>

Update on this. I did a series of reboots and boots with the patch
I asked you to drop and I am not seeing the wifi problem.

Prateek Sood <[email protected]>
firmware_loader: fix memory leak for paged buffer

With my testing, I think it is an unrelated issue and the error
messages from the fw load code path in the driver when wifi failed
through me off.

Sorry for making you drop the patch from 5.8.y and 5.4.y.
Please include them in the next rc.

thanks,
-- Shuah


2020-09-17 17:45:22

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Thu, Sep 17, 2020 at 11:06:05AM -0600, Shuah Khan wrote:
> On 9/17/20 8:46 AM, Greg Kroah-Hartman wrote:
> > On Thu, Sep 17, 2020 at 08:34:58AM -0600, Shuah Khan wrote:
> > > On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
> > > > On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
> > > > > On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
> > > > > > On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
> > > > > > > On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
> > > > > > > > On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
> > > > > > > > > On 9/15/20 3:06 PM, Shuah Khan wrote:
> > > > > > > > > > On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
> > > > > > > > > > > This is the start of the stable review cycle for the 5.8.10 release.
> > > > > > > > > > > There are 177 patches in this series, all will be posted as a response
> > > > > > > > > > > to this one.? If anyone has any issues with these being applied, please
> > > > > > > > > > > let me know.
> > > > > > > > > > >
> > > > > > > > > > > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> > > > > > > > > > > Anything received after that time might be too late.
> > > > > > > > > > >
> > > > > > > > > > > The whole patch series can be found in one patch at:
> > > > > > > > > > > ????https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
> > > > > > > > > > >
> > > > > > > > > > > or in the git tree and branch at:
> > > > > > > > > > > ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > > > > > > > > linux-5.8.y
> > > > > > > > > > > and the diffstat can be found below.
> > > > > > > > > > >
> > > > > > > > > > > thanks,
> > > > > > > > > > >
> > > > > > > > > > > greg k-h
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > Compiled and booted fine. wifi died:
> > > > > > > > > >
> > > > > > > > > > ath10k_pci 0000:02:00.0: could not init core (-110)
> > > > > > > > > > ath10k_pci 0000:02:00.0: could not probe fw (-110)
> > > > > > > > > >
> > > > > > > > > > This is regression from 5.8.9 and 5.9-rc5 works just fine.
> > > > > > > > > >
> > > > > > > > > > I will try to bisect later this evening to see if I can isolate the
> > > > > > > > > > commit.
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > The following commit is what caused ath10k_pci driver problem
> > > > > > > > > that killed wifi.
> > > > > > > > >
> > > > > > > > > Prateek Sood <[email protected]>
> > > > > > > > > firmware_loader: fix memory leak for paged buffer
> > > > > > > > >
> > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271
> > > > > > > >
> > > > > > > > Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For
> > > > > > > > reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory
> > > > > > > > leak for paged buffer") in Linus's tree.
> > > > > > > >
> > > > > > >
> > > > > > > I am not seeing this on Linux 5.9-rc5 for sure.
> > > > > > >
> > > > > > > > And it should be showing up in 5.4.y at the moment too, as this patch is
> > > > > > > > in that tree right now...
> > > > > > > >
> > > > > > >
> > > > > > > I don't see this patch in 4.19.146-rc1
> > > > > >
> > > > > > It's not there, it's in 5.4.66-rc1, which worked for you somehow, right?
> > > > > >
> > > > > > > Linus's tree works for with this patch in. I compared the two files
> > > > > > > for differences in commit between Linus's tree and 5.8.10-rc1
> > > > > > >
> > > > > > > Couldn't find anything obvious.
> > > > > >
> > > > > > Again, really odd...
> > > > > >
> > > > > > I don't have a problem dropping it, but I should drop it from both 5.4.y
> > > > > > and 5.8.y, right?
> > > > > >
> > > > >
> > > > > Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out
> > > > > why this patch causes problems.
> > > > >
> > > > > I will continue debugging and let you know what I find.
> > > >
> > >
> > > With this it boots and wifi is good for me. I am very puzzled by why
> > > this made a difference to make sure I am not narrowing in on the wrong
> > > patch.
> > >
>
> Update on this. I did a series of reboots and boots with the patch
> I asked you to drop and I am not seeing the wifi problem.
>
> Prateek Sood <[email protected]>
> firmware_loader: fix memory leak for paged buffer
>
> With my testing, I think it is an unrelated issue and the error
> messages from the fw load code path in the driver when wifi failed
> through me off.
>
> Sorry for making you drop the patch from 5.8.y and 5.4.y.
> Please include them in the next rc.

No worries, now added back, thanks for testing some more.

greg k-h

2020-09-17 19:58:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review

On Thu, Sep 17, 2020 at 08:34:58AM -0600, Shuah Khan wrote:
> On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote:
> > On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote:
> > > On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote:
> > > > On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote:
> > > > > On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote:
> > > > > > On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote:
> > > > > > > On 9/15/20 3:06 PM, Shuah Khan wrote:
> > > > > > > > On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote:
> > > > > > > > > This is the start of the stable review cycle for the 5.8.10 release.
> > > > > > > > > There are 177 patches in this series, all will be posted as a response
> > > > > > > > > to this one.? If anyone has any issues with these being applied, please
> > > > > > > > > let me know.
> > > > > > > > >
> > > > > > > > > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000.
> > > > > > > > > Anything received after that time might be too late.
> > > > > > > > >
> > > > > > > > > The whole patch series can be found in one patch at:
> > > > > > > > > ????https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz
> > > > > > > > >
> > > > > > > > > or in the git tree and branch at:
> > > > > > > > > ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > > > > > > linux-5.8.y
> > > > > > > > > and the diffstat can be found below.
> > > > > > > > >
> > > > > > > > > thanks,
> > > > > > > > >
> > > > > > > > > greg k-h
> > > > > > > > >
> > > > > > > >
> > > > > > > > Compiled and booted fine. wifi died:
> > > > > > > >
> > > > > > > > ath10k_pci 0000:02:00.0: could not init core (-110)
> > > > > > > > ath10k_pci 0000:02:00.0: could not probe fw (-110)
> > > > > > > >
> > > > > > > > This is regression from 5.8.9 and 5.9-rc5 works just fine.
> > > > > > > >
> > > > > > > > I will try to bisect later this evening to see if I can isolate the
> > > > > > > > commit.
> > > > > > > >
> > > > > > >
> > > > > > > The following commit is what caused ath10k_pci driver problem
> > > > > > > that killed wifi.
> > > > > > >
> > > > > > > Prateek Sood <[email protected]>
> > > > > > > firmware_loader: fix memory leak for paged buffer
> > > > > > >
> > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271
> > > > > >
> > > > > > Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For
> > > > > > reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory
> > > > > > leak for paged buffer") in Linus's tree.
> > > > > >
> > > > >
> > > > > I am not seeing this on Linux 5.9-rc5 for sure.
> > > > >
> > > > > > And it should be showing up in 5.4.y at the moment too, as this patch is
> > > > > > in that tree right now...
> > > > > >
> > > > >
> > > > > I don't see this patch in 4.19.146-rc1
> > > >
> > > > It's not there, it's in 5.4.66-rc1, which worked for you somehow, right?
> > > >
> > > > > Linus's tree works for with this patch in. I compared the two files
> > > > > for differences in commit between Linus's tree and 5.8.10-rc1
> > > > >
> > > > > Couldn't find anything obvious.
> > > >
> > > > Again, really odd...
> > > >
> > > > I don't have a problem dropping it, but I should drop it from both 5.4.y
> > > > and 5.8.y, right?
> > > >
> > >
> > > Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out
> > > why this patch causes problems.
> > >
> > > I will continue debugging and let you know what I find.
> >
>
> With this it boots and wifi is good for me. I am very puzzled by why
> this made a difference to make sure I am not narrowing in on the wrong
> patch.
>
> Compiled and booted on my test system. No dmesg regressions.
>
> Tested-by: Shuah Khan <[email protected]>

Great, thanks for testing them all and letting me know.

greg k-h