2020-09-17 06:57:05

by Liu Shixin

Subject: [PATCH -next] dmaengine: sf-pdma: Remove set but not used variable "desc"

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]

After commit 8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice"),
variable 'desc' is never used. Remove it to avoid build warning.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/dma/sf-pdma/sf-pdma.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 754994087e5f..1e66c6990d81 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -284,7 +284,6 @@ static void sf_pdma_free_desc(struct virt_dma_desc *vdesc)
static void sf_pdma_donebh_tasklet(unsigned long arg)
{
struct sf_pdma_chan *chan = (struct sf_pdma_chan *)arg;
- struct sf_pdma_desc *desc = chan->desc;
unsigned long flags;

spin_lock_irqsave(&chan->lock, flags);
--
2.25.1

2020-09-18 07:16:50

by Vinod Koul

Subject: Re: [PATCH -next] dmaengine: sf-pdma: Remove set but not used variable "desc"

On 17-09-20, 15:17, Liu Shixin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
>
> After commit 8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice"),
> variable 'desc' is never used. Remove it to avoid build warning.

This was already reported by SFR and patch posted, so picked that one

>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> drivers/dma/sf-pdma/sf-pdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
> index 754994087e5f..1e66c6990d81 100644
> --- a/drivers/dma/sf-pdma/sf-pdma.c
> +++ b/drivers/dma/sf-pdma/sf-pdma.c
> @@ -284,7 +284,6 @@ static void sf_pdma_free_desc(struct virt_dma_desc *vdesc)
> static void sf_pdma_donebh_tasklet(unsigned long arg)
> {
> struct sf_pdma_chan *chan = (struct sf_pdma_chan *)arg;
> - struct sf_pdma_desc *desc = chan->desc;
> unsigned long flags;
>
> spin_lock_irqsave(&chan->lock, flags);
> --
> 2.25.1

--
~Vinod