2020-09-18 08:41:58

by Tomi Valkeinen

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: phy: cdns,torrent-phy: add reset-names

Add reset-names as a required property.

There are no dts files using torrent phy yet, so it is safe to add a new
required property.

Signed-off-by: Tomi Valkeinen <[email protected]>
---

Changes in v2:

* Base on phy-next
* Update example
* Add torrent_apb

.../devicetree/bindings/phy/phy-cadence-torrent.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
index 26480f89627d..e266ade53d87 100644
--- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
+++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
@@ -57,6 +57,13 @@ properties:
- description: Torrent PHY reset.
- description: Torrent APB reset. This is optional.

+ reset-names:
+ minItems: 1
+ maxItems: 2
+ items:
+ - const: torrent_reset
+ - const: torrent_apb
+
patternProperties:
'^phy@[0-3]$':
type: object
@@ -127,6 +134,7 @@ required:
- reg
- reg-names
- resets
+ - reset-names

additionalProperties: false

@@ -144,6 +152,7 @@ examples:
<0xf0 0xfb030a00 0x0 0x00000040>;
reg-names = "torrent_phy", "dptx_phy";
resets = <&phyrst 0>;
+ reset-names = "torrent_reset";
clocks = <&ref_clk>;
clock-names = "refclk";
#address-cells = <1>;
@@ -172,6 +181,7 @@ examples:
reg = <0xf0 0xfb500000 0x0 0x00100000>;
reg-names = "torrent_phy";
resets = <&phyrst 0>, <&phyrst 1>;
+ reset-names = "torrent_reset", "torrent_apb";
clocks = <&ref_clk>;
clock-names = "refclk";
#address-cells = <1>;
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


2020-09-23 05:30:14

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: cdns,torrent-phy: add reset-names

On 18-09-20, 11:37, Tomi Valkeinen wrote:
> Add reset-names as a required property.
>
> There are no dts files using torrent phy yet, so it is safe to add a new
> required property.

Applied both, thanks

--
~Vinod