2020-09-18 19:18:44

by Dan Murphy

Subject: [PATCH net-next v2 3/3] net: phy: dp83822: Update the fiber advertisement for speed

Update the fiber advertisement for speed and duplex modes with the
100base-FX full and half linkmode entries.

Signed-off-by: Dan Murphy <[email protected]>
---
drivers/net/phy/dp83822.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 732c8bec7452..c162c9551bd1 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -110,9 +110,8 @@
#define DP83822_RX_ER_SHIFT 8

#define MII_DP83822_FIBER_ADVERTISE (ADVERTISED_TP | ADVERTISED_MII | \
- ADVERTISED_FIBRE | ADVERTISED_BNC | \
- ADVERTISED_Pause | ADVERTISED_Asym_Pause | \
- ADVERTISED_100baseT_Full)
+ ADVERTISED_FIBRE | \
+ ADVERTISED_Pause | ADVERTISED_Asym_Pause)

struct dp83822_private {
bool fx_signal_det_low;
@@ -406,6 +405,14 @@ static int dp83822_config_init(struct phy_device *phydev)
phydev->supported);
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
phydev->advertising);
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
+ phydev->supported);
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
+ phydev->supported);
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
+ phydev->advertising);
+ linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
+ phydev->advertising);

/* Auto neg is not supported in fiber mode */
bmcr = phy_read(phydev, MII_BMCR);
--
2.28.0

2020-09-18 19:31:27

by Andrew Lunn

Subject: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Update the fiber advertisement for speed

On Fri, Sep 18, 2020 at 02:14:53PM -0500, Dan Murphy wrote:
> Update the fiber advertisement for speed and duplex modes with the
> 100base-FX full and half linkmode entries.
>
> Signed-off-by: Dan Murphy <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-09-18 20:19:23

by Florian Fainelli

Subject: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Update the fiber advertisement for speed

On 9/18/2020 12:14 PM, Dan Murphy wrote:
> Update the fiber advertisement for speed and duplex modes with the
> 100base-FX full and half linkmode entries.
>
> Signed-off-by: Dan Murphy <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian