2020-09-15 09:15:24

by Alain Volmat

[permalink] [raw]
Subject: [PATCH 1/2] i2c: stm32: fix slot id after introduction of host-notify support

Commit 68302245720a ("i2c: stm32f7: Add SMBus Host-Notify protocol support")
added a new slot specific for handling host-notify however failed
to update the previous slot ID leading to having the 7bit address
only slot with the wrong number.

Signed-off-by: Alain Volmat <[email protected]>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index b401940c5580..0880f6a4cd44 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1355,7 +1355,7 @@ static int stm32f7_i2c_get_free_slave_id(struct stm32f7_i2c_dev *i2c_dev,
}

for (i = STM32F7_I2C_MAX_SLAVE - 1; i > 0; i--) {
- if (i == 1 && (slave->flags & I2C_CLIENT_TEN))
+ if (i == 2 && (slave->flags & I2C_CLIENT_TEN))
continue;
if (!i2c_dev->slave[i]) {
*id = i;
--
2.7.4


2020-09-18 21:08:46

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 1/2] i2c: stm32: fix slot id after introduction of host-notify support

On Tue, Sep 15, 2020 at 11:11:30AM +0200, Alain Volmat wrote:
> Commit 68302245720a ("i2c: stm32f7: Add SMBus Host-Notify protocol support")
> added a new slot specific for handling host-notify however failed
> to update the previous slot ID leading to having the 7bit address
> only slot with the wrong number.
>
> Signed-off-by: Alain Volmat <[email protected]>

Folded this into 68302245720a in for-next, thanks!


Attachments:
(No filename) (430.00 B)
signature.asc (849.00 B)
Download all attachments