2020-09-19 09:51:42

by Liu Shixin

[permalink] [raw]
Subject: [PATCH -next] rtc: meson: simplify the return expression of meson_vrtc_probe

Simplify the return expression.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/rtc/rtc-meson-vrtc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c
index 89e5ba0dae69..e6bd0808a092 100644
--- a/drivers/rtc/rtc-meson-vrtc.c
+++ b/drivers/rtc/rtc-meson-vrtc.c
@@ -65,7 +65,6 @@ static const struct rtc_class_ops meson_vrtc_ops = {
static int meson_vrtc_probe(struct platform_device *pdev)
{
struct meson_vrtc_data *vrtc;
- int ret;

vrtc = devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL);
if (!vrtc)
@@ -84,11 +83,7 @@ static int meson_vrtc_probe(struct platform_device *pdev)
return PTR_ERR(vrtc->rtc);

vrtc->rtc->ops = &meson_vrtc_ops;
- ret = rtc_register_device(vrtc->rtc);
- if (ret)
- return ret;
-
- return 0;
+ return rtc_register_device(vrtc->rtc);
}

static int __maybe_unused meson_vrtc_suspend(struct device *dev)
--
2.25.1


2020-09-21 15:08:10

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH -next] rtc: meson: simplify the return expression of meson_vrtc_probe

Liu Shixin <[email protected]> writes:

> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

2020-09-29 20:23:24

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH -next] rtc: meson: simplify the return expression of meson_vrtc_probe

On Sat, 19 Sep 2020 18:08:56 +0800, Liu Shixin wrote:
> Simplify the return expression.

Applied, thanks!

[1/1] rtc: meson: simplify the return expression of meson_vrtc_probe
commit: 9ce42e8e0323d39fad01f3d17c35dd16d91c4f46

Best regards,
--
Alexandre Belloni <[email protected]>