2020-09-18 13:18:32

by Yue Haibing

Subject: [PATCH net-next] ipvs: Remove unused macros

They are not used since commit e4ff67513096 ("ipvs: add
sync_maxlen parameter for the sync daemon")

Signed-off-by: YueHaibing <[email protected]>
---
net/netfilter/ipvs/ip_vs_sync.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index 2b8abbfe018c..16b48064f715 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -242,9 +242,6 @@ struct ip_vs_sync_thread_data {
| IPVS Sync Connection (1) |
*/

-#define SYNC_MESG_HEADER_LEN 4
-#define MAX_CONNS_PER_SYNCBUFF 255 /* nr_conns in ip_vs_sync_mesg is 8 bit */
-
/* Version 0 header */
struct ip_vs_sync_mesg_v0 {
__u8 nr_conns;
--
2.17.1

2020-09-21 07:33:33

by Simon Horman

Subject: Re: [PATCH net-next] ipvs: Remove unused macros

On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
>
> Signed-off-by: YueHaibing <[email protected]>

Thanks, this look good to me.

Acked-by: Simon Horman <[email protected]>

Pablo, please consider this for nf-next.

> ---
> net/netfilter/ipvs/ip_vs_sync.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index 2b8abbfe018c..16b48064f715 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -242,9 +242,6 @@ struct ip_vs_sync_thread_data {
> | IPVS Sync Connection (1) |
> */
>
> -#define SYNC_MESG_HEADER_LEN 4
> -#define MAX_CONNS_PER_SYNCBUFF 255 /* nr_conns in ip_vs_sync_mesg is 8 bit */
> -
> /* Version 0 header */
> struct ip_vs_sync_mesg_v0 {
> __u8 nr_conns;
> --
> 2.17.1
>

2020-09-22 00:59:07

by Pablo Neira Ayuso

Subject: Re: [PATCH net-next] ipvs: Remove unused macros

On Mon, Sep 21, 2020 at 09:24:40AM +0200, Simon Horman wrote:
> On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> > They are not used since commit e4ff67513096 ("ipvs: add
> > sync_maxlen parameter for the sync daemon")
> >
> > Signed-off-by: YueHaibing <[email protected]>
>
> Thanks, this look good to me.
>
> Acked-by: Simon Horman <[email protected]>
>
> Pablo, please consider this for nf-next.

Applied, thanks.