2020-09-17 07:58:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 13/13] x86/platform/uv: Update Copyrights to conform to HPE standards

On Wed, Sep 16, 2020 at 02:20:39PM -0500, Mike Travis wrote:
> Add Copyrights to those files that have been updated for UV5 changes.
>
> Signed-off-by: Mike Travis <[email protected]>
> ---
> arch/x86/include/asm/uv/bios.h | 1 +
> arch/x86/include/asm/uv/uv_hub.h | 1 +
> arch/x86/include/asm/uv/uv_mmrs.h | 1 +
> arch/x86/kernel/apic/x2apic_uv_x.c | 1 +
> arch/x86/platform/uv/bios_uv.c | 1 +
> arch/x86/platform/uv/uv_nmi.c | 1 +
> arch/x86/platform/uv/uv_time.c | 1 +
> drivers/misc/sgi-gru/grufile.c | 1 +
> drivers/misc/sgi-xp/xp.h | 1 +
> drivers/misc/sgi-xp/xp_main.c | 1 +
> drivers/misc/sgi-xp/xp_uv.c | 1 +
> drivers/misc/sgi-xp/xpc_main.c | 1 +
> drivers/misc/sgi-xp/xpc_partition.c | 1 +
> drivers/misc/sgi-xp/xpnet.c | 1 +
> 14 files changed, 14 insertions(+)
>
> diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
> index 97ac595ebc6a..08b3d810dfba 100644
> --- a/arch/x86/include/asm/uv/bios.h
> +++ b/arch/x86/include/asm/uv/bios.h
> @@ -5,6 +5,7 @@
> /*
> * UV BIOS layer definitions.
> *
> + * (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> * Copyright (C) 2007-2017 Silicon Graphics, Inc. All rights reserved.
> * Copyright (c) Russ Anderson <[email protected]>

Gotta love the different ways of text here :(

Anyway, much better than before, thanks.

greg k-h


2020-09-22 05:15:33

by Russ Anderson

[permalink] [raw]
Subject: Re: [PATCH v2 13/13] x86/platform/uv: Update Copyrights to conform to HPE standards

On Thu, Sep 17, 2020 at 09:54:29AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 16, 2020 at 02:20:39PM -0500, Mike Travis wrote:
> > Add Copyrights to those files that have been updated for UV5 changes.
> >
> > Signed-off-by: Mike Travis <[email protected]>
> > ---
> > arch/x86/include/asm/uv/bios.h | 1 +
> > arch/x86/include/asm/uv/uv_hub.h | 1 +
> > arch/x86/include/asm/uv/uv_mmrs.h | 1 +
> > arch/x86/kernel/apic/x2apic_uv_x.c | 1 +
> > arch/x86/platform/uv/bios_uv.c | 1 +
> > arch/x86/platform/uv/uv_nmi.c | 1 +
> > arch/x86/platform/uv/uv_time.c | 1 +
> > drivers/misc/sgi-gru/grufile.c | 1 +
> > drivers/misc/sgi-xp/xp.h | 1 +
> > drivers/misc/sgi-xp/xp_main.c | 1 +
> > drivers/misc/sgi-xp/xp_uv.c | 1 +
> > drivers/misc/sgi-xp/xpc_main.c | 1 +
> > drivers/misc/sgi-xp/xpc_partition.c | 1 +
> > drivers/misc/sgi-xp/xpnet.c | 1 +
> > 14 files changed, 14 insertions(+)
> >
> > diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
> > index 97ac595ebc6a..08b3d810dfba 100644
> > --- a/arch/x86/include/asm/uv/bios.h
> > +++ b/arch/x86/include/asm/uv/bios.h
> > @@ -5,6 +5,7 @@
> > /*
> > * UV BIOS layer definitions.
> > *
> > + * (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > * Copyright (C) 2007-2017 Silicon Graphics, Inc. All rights reserved.
> > * Copyright (c) Russ Anderson <[email protected]>
>
> Gotta love the different ways of text here :(
>
> Anyway, much better than before, thanks.

The HPE copyright text is different than the old SGI copyright text.
We could update the SGI copyright line to be consistent, change
"Copyright (C)" to "(C) Copyright", if that is desired.

The HPE lawyers said the old SGI copyrights do not need to be
updated as far as they are concerned, because HPE owns the SGI
copyrights, but they can. So the two lines could be combined to

* (C) Copyright 2007-2017, 2020 Hewlett Packard Enterprise Development LP

I will do whatever the lawyers and community want as far as format.

For what it's worth, the [email protected] email still works, as does [email protected].

Thanks.
--
Russ Anderson, SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI) [email protected]

2020-09-22 08:28:17

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 13/13] x86/platform/uv: Update Copyrights to conform to HPE standards

On Mon, Sep 21, 2020 at 09:25:04PM -0500, Russ Anderson wrote:
> On Thu, Sep 17, 2020 at 09:54:29AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Sep 16, 2020 at 02:20:39PM -0500, Mike Travis wrote:
> > > Add Copyrights to those files that have been updated for UV5 changes.
> > >
> > > Signed-off-by: Mike Travis <[email protected]>
> > > ---
> > > arch/x86/include/asm/uv/bios.h | 1 +
> > > arch/x86/include/asm/uv/uv_hub.h | 1 +
> > > arch/x86/include/asm/uv/uv_mmrs.h | 1 +
> > > arch/x86/kernel/apic/x2apic_uv_x.c | 1 +
> > > arch/x86/platform/uv/bios_uv.c | 1 +
> > > arch/x86/platform/uv/uv_nmi.c | 1 +
> > > arch/x86/platform/uv/uv_time.c | 1 +
> > > drivers/misc/sgi-gru/grufile.c | 1 +
> > > drivers/misc/sgi-xp/xp.h | 1 +
> > > drivers/misc/sgi-xp/xp_main.c | 1 +
> > > drivers/misc/sgi-xp/xp_uv.c | 1 +
> > > drivers/misc/sgi-xp/xpc_main.c | 1 +
> > > drivers/misc/sgi-xp/xpc_partition.c | 1 +
> > > drivers/misc/sgi-xp/xpnet.c | 1 +
> > > 14 files changed, 14 insertions(+)
> > >
> > > diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
> > > index 97ac595ebc6a..08b3d810dfba 100644
> > > --- a/arch/x86/include/asm/uv/bios.h
> > > +++ b/arch/x86/include/asm/uv/bios.h
> > > @@ -5,6 +5,7 @@
> > > /*
> > > * UV BIOS layer definitions.
> > > *
> > > + * (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > > * Copyright (C) 2007-2017 Silicon Graphics, Inc. All rights reserved.
> > > * Copyright (c) Russ Anderson <[email protected]>
> >
> > Gotta love the different ways of text here :(
> >
> > Anyway, much better than before, thanks.
>
> The HPE copyright text is different than the old SGI copyright text.
> We could update the SGI copyright line to be consistent, change
> "Copyright (C)" to "(C) Copyright", if that is desired.
>
> The HPE lawyers said the old SGI copyrights do not need to be
> updated as far as they are concerned, because HPE owns the SGI
> copyrights, but they can. So the two lines could be combined to
>
> * (C) Copyright 2007-2017, 2020 Hewlett Packard Enterprise Development LP
>
> I will do whatever the lawyers and community want as far as format.

What you did here is fine, it's just "fun" to see lawyers change their
minds over time as to what the "correct" way to write these lines are.

For extra fun, it turns out none of these lines are actually needed,
it's just a real-world case of lawyer cargo-cult behavior :)

thanks,

greg k-h