2020-09-22 08:35:30

by Jing Xiangfeng

Subject: [PATCH] udf: Remove redundant initialization of variable ret

After commit 9293fcfbc181 ("udf: Remove struct ustr as non-needed
intermediate storage"), the variable ret is being initialized with
'-ENOMEM' that is meaningless. So remove it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
fs/udf/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/udf/super.c b/fs/udf/super.c
index 1c42f544096d..c0c8068116c1 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -854,7 +854,7 @@ static int udf_load_pvoldesc(struct super_block *sb, sector_t block)
uint8_t *outstr;
struct buffer_head *bh;
uint16_t ident;
- int ret = -ENOMEM;
+ int ret;
struct timestamp *ts;

outstr = kmalloc(128, GFP_NOFS);
--
2.17.1

2020-09-22 09:26:19

by Jan Kara

Subject: Re: [PATCH] udf: Remove redundant initialization of variable ret

On Tue 22-09-20 16:13:22, Jing Xiangfeng wrote:
> After commit 9293fcfbc181 ("udf: Remove struct ustr as non-needed
> intermediate storage"), the variable ret is being initialized with
> '-ENOMEM' that is meaningless. So remove it.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Thanks. I've queued the patch to my tree.

Honza

> ---
> fs/udf/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 1c42f544096d..c0c8068116c1 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -854,7 +854,7 @@ static int udf_load_pvoldesc(struct super_block *sb, sector_t block)
> uint8_t *outstr;
> struct buffer_head *bh;
> uint16_t ident;
> - int ret = -ENOMEM;
> + int ret;
> struct timestamp *ts;
>
> outstr = kmalloc(128, GFP_NOFS);
> --
> 2.17.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR