2020-09-23 06:55:45

by liwei (GF)

Subject: [PATCH] MIPS: BCM47XX: Remove the needless check with the 1074K

As there is no known soc powered by mips 1074K in bcm47xx series,
the check with 1074K is needless. So just remove it.

Link: https://wireless.wiki.kernel.org/en/users/Drivers/b43/soc
Fixes: 442e14a2c55e ("MIPS: Add 1074K CPU support explicitly.")
Signed-off-by: Wei Li <[email protected]>
---
arch/mips/bcm47xx/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/bcm47xx/setup.c b/arch/mips/bcm47xx/setup.c
index 82627c264964..01427bde2397 100644
--- a/arch/mips/bcm47xx/setup.c
+++ b/arch/mips/bcm47xx/setup.c
@@ -148,7 +148,7 @@ void __init plat_mem_setup(void)
{
struct cpuinfo_mips *c = &current_cpu_data;

- if ((c->cputype == CPU_74K) || (c->cputype == CPU_1074K)) {
+ if (c->cputype == CPU_74K) {
pr_info("Using bcma bus\n");
#ifdef CONFIG_BCM47XX_BCMA
bcm47xx_bus_type = BCM47XX_BUS_TYPE_BCMA;
--
2.17.1

2020-09-23 06:58:47

by Rafał Miłecki

Subject: Re: [PATCH] MIPS: BCM47XX: Remove the needless check with the 1074K

On Wed, 23 Sep 2020 at 08:54, Wei Li <[email protected]> wrote:
> As there is no known soc powered by mips 1074K in bcm47xx series,
> the check with 1074K is needless. So just remove it.
>
> Link: https://wireless.wiki.kernel.org/en/users/Drivers/b43/soc
> Fixes: 442e14a2c55e ("MIPS: Add 1074K CPU support explicitly.")
> Signed-off-by: Wei Li <[email protected]>

Acked-by: Rafał Miłecki <[email protected]>

2020-09-24 14:01:26

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: BCM47XX: Remove the needless check with the 1074K

On Wed, Sep 23, 2020 at 02:53:26PM +0800, Wei Li wrote:
> As there is no known soc powered by mips 1074K in bcm47xx series,
> the check with 1074K is needless. So just remove it.
>
> Link: https://wireless.wiki.kernel.org/en/users/Drivers/b43/soc
> Fixes: 442e14a2c55e ("MIPS: Add 1074K CPU support explicitly.")
> Signed-off-by: Wei Li <[email protected]>
> ---
> arch/mips/bcm47xx/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-fixes.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]