2020-09-23 10:17:14

by Artem Lapkin

Subject: [PATCH 0/2] arm64: dts: rockchip: rk3399-khadas-edge: missed nodes

From: Artem Lapkin <[email protected]>

add missed spiflash and ir-receiver dts nodes to Khadas Edge Board

Artem Lapkin (2):
arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node
arm64: dts: rockchip: rk3399-khadas-edge: add missed ir-recevier and
ir_rx pinctl nodes

.../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)

--
2.25.1

2020-09-23 10:17:25

by Artem Lapkin

Subject: [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node

From: Artem Lapkin <[email protected]>

The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz
---
.../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
index e36837c04dc..42ebbd6fa46 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
@@ -805,3 +805,17 @@ &vopl {
&vopl_mmu {
status = "okay";
};
+
+
+&spi1 {
+ max-freq = <104000000>;
+ status = "okay";
+
+ spiflash: flash@0 {
+ u-boot,dm-pre-reloc;
+ compatible = "winbond,w25q128fw", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <104000000>;
+ };
+};
+
--
2.25.1

2020-09-23 10:59:47

by Heiko Stübner

Subject: Re: [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node

Hi Artem,

please make the subject something like
"arm64: dts: rockchip: add spiflash node to rk3399-khadas-edge"

Am Mittwoch, 23. September 2020, 12:12:24 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <[email protected]>
>
> The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz

Missing "Signed-off-by: ..."

> ---
> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index e36837c04dc..42ebbd6fa46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -805,3 +805,17 @@ &vopl {
> &vopl_mmu {
> status = "okay";
> };
> +
> +
no double empty lines please

> +&spi1 {

please group the &spi1 alphabetically in the file

> + max-freq = <104000000>;

not part of any binding, spi-max-frequency below should be enough.

> + status = "okay";
> +
> + spiflash: flash@0 {
> + u-boot,dm-pre-reloc;

u-boot specific, please drop

> + compatible = "winbond,w25q128fw", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <104000000>;
> + };
> +};
> +
>


Heiko