2020-09-25 09:13:06

by Wei Yang

Subject: [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root()

This step is already done in rebind_subsystems().

Not necessary to do it again.

Signed-off-by: Wei Yang <[email protected]>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index dd247747ec14..809b13588124 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2006,7 +2006,6 @@ int cgroup_setup_root(struct cgroup_root *root, u16 ss_mask)
BUG_ON(!list_empty(&root_cgrp->self.children));
BUG_ON(atomic_read(&root->nr_cgrps) != 1);

- kernfs_activate(root_cgrp->kn);
ret = 0;
goto out;

--
2.20.1 (Apple Git-117)

2020-09-30 16:07:22

by Tejun Heo

Subject: Re: [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root()

On Fri, Sep 25, 2020 at 05:11:10PM +0800, Wei Yang wrote:
> This step is already done in rebind_subsystems().
>
> Not necessary to do it again.
>
> Signed-off-by: Wei Yang <[email protected]>

Applied to cgroup/for-5.10.

Thanks.

--
tejun