2020-09-25 23:46:27

by Tobias Jordan

Subject: [PATCH] bus: qcom: ebi2: fix device node iterator leak

In the for_each_available_child_of_node loop of qcom_ebi2_probe, add a
call to of_node_put to avoid leaking the iterator if we bail out.

Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")

Signed-off-by: Tobias Jordan <[email protected]>
---
drivers/bus/qcom-ebi2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 03ddcf426887..0b8f53a688b8 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev)

/* Figure out the chipselect */
ret = of_property_read_u32(child, "reg", &csindex);
- if (ret)
+ if (ret) {
+ of_node_put(child);
return ret;
+ }

if (csindex > 5) {
dev_err(dev,
--
2.20.1

2020-09-29 20:48:23

by Linus Walleij

Subject: Re: [PATCH] bus: qcom: ebi2: fix device node iterator leak

On Sat, Sep 26, 2020 at 1:45 AM Tobias Jordan <[email protected]> wrote:

> In the for_each_available_child_of_node loop of qcom_ebi2_probe, add a
> call to of_node_put to avoid leaking the iterator if we bail out.
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
>
> Signed-off-by: Tobias Jordan <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Bjorn can you apply this to the Qualcomm SoC tree?

Yours,
Linus Walleij