2020-09-24 20:14:57

by Alexandru Gagniuc

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: display: sii902x: Add supply bindings

The sii902x chip family requires IO and core voltages to reach the
correct voltage before chip initialization. Add binding for describing
the two supplies.

Signed-off-by: Alexandru Gagniuc <[email protected]>
---
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
index 0d1db3f9da84..02c21b584741 100644
--- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
+++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
@@ -8,6 +8,8 @@ Optional properties:
- interrupts: describe the interrupt line used to inform the host
about hotplug events.
- reset-gpios: OF device-tree gpio specification for RST_N pin.
+ - iovcc-supply: I/O Supply Voltage (1.8V or 3.3V)
+ - cvcc12-supply: Digital Core Supply Voltage (1.2V)

HDMI audio properties:
- #sound-dai-cells: <0> or <1>. <0> if only i2s or spdif pin
@@ -54,6 +56,8 @@ Example:
compatible = "sil,sii9022";
reg = <0x39>;
reset-gpios = <&pioA 1 0>;
+ iovcc-supply = <&v3v3_hdmi>;
+ cvcc12-supply = <&v1v2_hdmi>;

#sound-dai-cells = <0>;
sil,i2s-data-lanes = < 0 1 2 >;
--
2.25.4


2020-09-26 18:46:15

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: display: sii902x: Add supply bindings

Hi Alexandru

On Thu, Sep 24, 2020 at 03:05:06PM -0500, Alexandru Gagniuc wrote:
> The sii902x chip family requires IO and core voltages to reach the
> correct voltage before chip initialization. Add binding for describing
> the two supplies.
>
> Signed-off-by: Alexandru Gagniuc <[email protected]>

It is not mandatory but encouraged to convert a binding to DT schema
format before updating it. This is in order to reach a point
in time where all bindings are in DT Schema format thus
allowing much better verification of the DT files.

Sam

> ---
> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> index 0d1db3f9da84..02c21b584741 100644
> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> @@ -8,6 +8,8 @@ Optional properties:
> - interrupts: describe the interrupt line used to inform the host
> about hotplug events.
> - reset-gpios: OF device-tree gpio specification for RST_N pin.
> + - iovcc-supply: I/O Supply Voltage (1.8V or 3.3V)
> + - cvcc12-supply: Digital Core Supply Voltage (1.2V)
>
> HDMI audio properties:
> - #sound-dai-cells: <0> or <1>. <0> if only i2s or spdif pin
> @@ -54,6 +56,8 @@ Example:
> compatible = "sil,sii9022";
> reg = <0x39>;
> reset-gpios = <&pioA 1 0>;
> + iovcc-supply = <&v3v3_hdmi>;
> + cvcc12-supply = <&v1v2_hdmi>;
>
> #sound-dai-cells = <0>;
> sil,i2s-data-lanes = < 0 1 2 >;
> --
> 2.25.4
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel