2020-09-29 02:28:45

by Jing Xiangfeng

[permalink] [raw]
Subject: [PATCH] scsi: myrb: remove redundant assignment to variable timeout

The variable timeout has been initialized with a value '0'. The assignment
before while loop is redundant. So remove it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/scsi/myrb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index b2869c5dd7fb..687a808969ac 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -2732,7 +2732,6 @@ static int DAC960_LA_hw_init(struct pci_dev *pdev,
DAC960_LA_disable_intr(base);
DAC960_LA_ack_hw_mbox_status(base);
udelay(1000);
- timeout = 0;
while (DAC960_LA_init_in_progress(base) &&
timeout < MYRB_MAILBOX_TIMEOUT) {
if (DAC960_LA_read_error_status(base, &error,
--
2.17.1


2020-10-08 03:11:18

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: myrb: remove redundant assignment to variable timeout


Jing,

> The variable timeout has been initialized with a value '0'. The assignment
> before while loop is redundant. So remove it.

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-10-14 07:15:41

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: myrb: remove redundant assignment to variable timeout

On Tue, 29 Sep 2020 10:24:58 +0800, Jing Xiangfeng wrote:

> The variable timeout has been initialized with a value '0'. The assignment
> before while loop is redundant. So remove it.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: myrb: Remove redundant assignment to variable timeout
https://git.kernel.org/mkp/scsi/c/5f6dcb55a7fa

--
Martin K. Petersen Oracle Linux Engineering