2020-09-21 08:06:16

by Liu Shixin

Subject: [PATCH -next] PCI: mobiveil: simplify the return expression of mobiveil_pcie_init_irq_domain

Simplify the return expression.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
index 3adec419a45b..a2632d02ce8f 100644
--- a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
+++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
@@ -480,7 +480,6 @@ static int mobiveil_pcie_init_irq_domain(struct mobiveil_pcie *pcie)
struct device *dev = &pcie->pdev->dev;
struct device_node *node = dev->of_node;
struct mobiveil_root_port *rp = &pcie->rp;
- int ret;

/* setup INTx */
rp->intx_domain = irq_domain_add_linear(node, PCI_NUM_INTX,
@@ -494,11 +493,7 @@ static int mobiveil_pcie_init_irq_domain(struct mobiveil_pcie *pcie)
raw_spin_lock_init(&rp->intx_mask_lock);

/* setup MSI */
- ret = mobiveil_allocate_msi_domains(pcie);
- if (ret)
- return ret;
-
- return 0;
+ return mobiveil_allocate_msi_domains(pcie);
}

static int mobiveil_pcie_integrated_interrupt_init(struct mobiveil_pcie *pcie)
--
2.25.1

2020-10-01 14:41:20

by Rob Herring (Arm)

Subject: Re: [PATCH -next] PCI: mobiveil: simplify the return expression of mobiveil_pcie_init_irq_domain

On Mon, 21 Sep 2020 16:24:47 +0800, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>